Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] MTRDevice write should reset expected value on error #25966

Merged
merged 5 commits into from
Apr 14, 2023
Merged

[Darwin] MTRDevice write should reset expected value on error #25966

merged 5 commits into from
Apr 14, 2023

Conversation

jtung-apple
Copy link
Contributor

Fixes #23620

@github-actions github-actions bot added the darwin label Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

PR #25966: Size comparison from d81d4e3 to 553dda2

Increases (1 build for cc32xx)
platform target config section d81d4e3 553dda2 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302987 20302988 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section d81d4e3 553dda2 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644409 644409 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302988 1 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466152 2466152 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1428796 1428796 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Apr 4, 2023
View reviewed changes
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIPTests/MTRDeviceTests.m Outdated Show resolved Hide resolved
src/darwin/Framework/CHIPTests/MTRDeviceTests.m Outdated Show resolved Hide resolved
src/darwin/Framework/CHIPTests/MTRDeviceTests.m Show resolved Hide resolved
@jtung-apple jtung-apple force-pushed the jtung/issue-23620-reset-expected-value-on-write-error branch from 553dda2 to 24c40ad Compare April 13, 2023 16:32
@jtung-apple
Copy link
Contributor Author

Rebased to current master and addressed review comments with substantial change.

@github-actions
Copy link

PR #25966: Size comparison from a235160 to 24c40ad

Increases (1 build for cc32xx)
platform target config section a235160 24c40ad change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20326061 1 0.0
Full report (1 build for cc32xx)
platform target config section a235160 24c40ad change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20326061 1 0.0
.debug_line 2687403 2687403 0 0.0
.debug_loc 2838361 2838361 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042379 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377626 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@github-actions
Copy link

PR #25966: Size comparison from a235160 to d6fa772

Increases (1 build for cc32xx)
platform target config section a235160 d6fa772 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20326061 1 0.0
Full report (1 build for cc32xx)
platform target config section a235160 d6fa772 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20326061 1 0.0
.debug_line 2687403 2687403 0 0.0
.debug_loc 2838361 2838361 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042379 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377626 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Apr 13, 2023
View reviewed changes
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
@jtung-apple @bzbarsky-apple
Better comment doc for expected value cache property
9cf7283 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@github-actions
Copy link

PR #25966: Size comparison from a235160 to 9cf7283

Increases (1 build for cc32xx)
platform target config section a235160 9cf7283 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20326062 2 0.0
Full report (1 build for cc32xx)
platform target config section a235160 9cf7283 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20326062 2 0.0
.debug_line 2687403 2687403 0 0.0
.debug_loc 2838361 2838361 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042379 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377626 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@github-actions
Copy link

PR #25966: Size comparison from a235160 to 7eca7bf

Increases (1 build for cc32xx)
platform target config section a235160 7eca7bf change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20326061 1 0.0
Full report (1 build for cc32xx)
platform target config section a235160 7eca7bf change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20326061 1 0.0
.debug_line 2687403 2687403 0 0.0
.debug_loc 2838361 2838361 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042379 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377626 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@bzbarsky-apple
Copy link
Contributor

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit 533f84c into project-chip:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Darwin] MTRDevice write should reset expected value on error
2 participants
@jtung-apple @bzbarsky-apple