Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Simplifies SimpleNamespace creation for generating factory partition with and without encryption #26015

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

dhairyashah1
Copy link
Contributor

Aim - To simplify SimpleNamespace creation logic and arguments required to generate nvs factory partition binary for esp32 with and without encryption in scripts/tools/generate_esp32_chip_factory_bin.py.

Change Overview -

  • A common, single NameSpace created in the generate_nvs_bin function instead of different ones.
  • Specific arguments added for factory partition generation with and without nvs encryption.

…nvs binary with and without encryption in 'scripts/tools/generate_esp32_chip_factory_bin.py'

Signed-off-by: dhairyashah1 <dhairya.shah@espressif.com>
@CLAassistant
Copy link

CLAassistant commented Apr 7, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

PR #26015: Size comparison from 6eded52 to 36d0ea4

Decreases (1 build for cc32xx)
platform target config section 6eded52 36d0ea4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302992 20302990 -2 -0.0
Full report (1 build for cc32xx)
platform target config section 6eded52 36d0ea4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933119 933119 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302992 20302990 -2 -0.0
.debug_line 2679759 2679759 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@andy31415 andy31415 merged commit 958d646 into project-chip:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants