Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lint for SuccessOrExit(CHIP_ERROR_*). #26057

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Since it's not changing state, it's identical to ExitNow(), but it looks like it's going to somehow return the provided error code.

Since it's not changing state, it's identical to ExitNow(), but it _looks_ like
it's going to somehow return the provided error code.
@github-actions
Copy link

PR #26057: Size comparison from 6f7af6c to 202158e

Increases (1 build for cc32xx)
platform target config section 6f7af6c 202158e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20303347 20303348 1 0.0
Full report (1 build for cc32xx)
platform target config section 6f7af6c 202158e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642953 642953 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303347 20303348 1 0.0
.debug_line 2679969 2679969 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039557 3039557 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536480 536480 0 0.0

@andy31415 andy31415 merged commit d85124e into project-chip:master Apr 12, 2023
@bzbarsky-apple bzbarsky-apple deleted the success-or-exit-lint branch April 12, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants