[ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros #26348

shubhamdp · 2023-05-03T12:28:01Z

Basically this un-reverts the #26282 with additional changes to fixed the rpc logging problem introduced in #26227.

Change Overview

Earlier a buffer was used to create a log, we won't need that buffer, so getting rid of that buffer.
[ESP32] Suppressing the logs related to Long dispatch time and Log re… #26227 tried doing the same thing, but introduced the bug in rpc logging and that PR was reverted with minor changes in Fix pigweed RPC logging on ESP32 #26282.
Took the changes from [ESP32] Suppressing the logs related to Long dispatch time and Log re… #26227 and fixed the RPC logging bug.
Fix the ESP32 to Chip log level mapping.

Tests

RPC
- Compiled using ./scripts/build/build_examples.py --target esp32-m5stack-all-clusters-rpc build.
- Flashed onto ESP32 devkit using ./out/esp32-m5stack-all-clusters-rpc/chip-all-clusters-app.flash.py
- Attached to pigweed rpc console python3 -m chip_rpc.console --device /dev/cu.usbserial-14340
- Confirmed that chip and other logs can be seen on rpc console.
- Tried commissioning using chip-tool
non-RPC
- Compiled all-clusters-app/esp32, flashed on ESP32, commissioned the device and verified all CHIP[..] and other logs were seen.
For log level mapping
- Validated the build/esp-idf/chip/args.gn, before change all log levels were set to true in here. After the change, correct values are being set.

tehampson

Thanks so much for making sure this works with pigweed!

src/platform/ESP32/Logging.cpp

examples/platform/esp32/PigweedLogger.cpp

src/platform/ESP32/Logging.cpp

examples/platform/esp32/PigweedLogger.cpp

github-actions · 2023-05-04T18:27:03Z

PR #26348: Size comparison from de1c64a to 2ebccbe

Full report (1 build for cc32xx)

platform	target	config	section	`de1c64a`	`2ebccbe`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	604866	604866
			(read/write)	204156	204156
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197568	197568
			.comment	206	206
			.data	1468	1468
			.debug_abbrev	957005	957005
			.debug_aranges	101104	101104
			.debug_frame	341416	341416
			.debug_info	19522697	19522697
			.debug_line	2666219	2666219
			.debug_line_str	513	513
			.debug_loc	33340	33340
			.debug_loclists	1488771	1488771
			.debug_ranges	4984	4984
			.debug_rnglists	94291	94291
			.debug_str	3100491	3100491
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104346	104346
			.shstrtab	265	265
			.stack	2048	2048
			.strtab	482872	482872
			.symtab	287120	287120
			.text	498396	498396

Basically this unreverts the project-chip#26282 with additional changes to fixed the rpc logging problem introduced in project-chip#26227.

github-actions · 2023-05-08T11:45:37Z

PR #26348: Size comparison from 6c0c5ea to 8cd120b

Increases (1 build for cc32xx)

platform	target	config	section	`6c0c5ea`	`8cd120b`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19609755	19609756	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`6c0c5ea`	`8cd120b`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	605090	605090	0
			(read/write)	204164	204164	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197576	197576	0
			.comment	206	206	0
			.data	1468	1468	0
			.debug_abbrev	957621	957621	0
			.debug_aranges	101136	101136	0
			.debug_frame	341512	341512	0
			.debug_info	19609755	19609756	1
			.debug_line	`2666632`	`2666632`	0
			.debug_line_str	513	513	0
			.debug_loc	33340	33340	0
			.debug_loclists	1489225	1489225	0
			.debug_ranges	4984	4984	0
			.debug_rnglists	94315	94315	0
			.debug_str	3108982	3108982	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104354	104354	0
			.shstrtab	265	265	0
			.stack	2048	2048	0
			.strtab	483384	483384	0
			.symtab	287328	287328	0
			.text	498612	498612	0

examples/platform/esp32/PigweedLogger.cpp

github-actions · 2023-05-08T13:30:38Z

PR #26348: Size comparison from 6c0c5ea to 30854b9

Full report (1 build for cc32xx)

platform	target	config	section	`6c0c5ea`	`30854b9`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	605090	605090
			(read/write)	204164	204164
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197576	197576
			.comment	206	206
			.data	1468	1468
			.debug_abbrev	957621	957621
			.debug_aranges	101136	101136
			.debug_frame	341512	341512
			.debug_info	19609755	19609755
			.debug_line	`2666632`	`2666632`
			.debug_line_str	513	513
			.debug_loc	33340	33340
			.debug_loclists	1489225	1489225
			.debug_ranges	4984	4984
			.debug_rnglists	94315	94315
			.debug_str	3108982	3108982
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104354	104354
			.shstrtab	265	265
			.stack	2048	2048
			.strtab	483384	483384
			.symtab	287328	287328
			.text	498612	498612

…roject-chip#26348) * [ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros Basically this unreverts the project-chip#26282 with additional changes to fixed the rpc logging problem introduced in project-chip#26227. * Fix the bug when setting the log level * remove the log level check * Fix the color codes for pigweed logs * Added comment explaining the addition of color codes in pigweed logger

…26348) (#26477) * [ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros Basically this unreverts the #26282 with additional changes to fixed the rpc logging problem introduced in #26227. * Fix the bug when setting the log level * remove the log level check * Fix the color codes for pigweed logs * Added comment explaining the addition of color codes in pigweed logger

pullapprove bot requested review from amitnj and andy31415 May 3, 2023 12:28

github-actions bot added the config label May 3, 2023

pullapprove bot requested a review from anush-apple May 3, 2023 12:28

github-actions bot added the esp32 label May 3, 2023

pullapprove bot requested a review from arkq May 3, 2023 12:28

github-actions bot added the examples label May 3, 2023

pullapprove bot requested a review from bzbarsky-apple May 3, 2023 12:28

github-actions bot added the platform label May 3, 2023

tehampson reviewed May 3, 2023

View reviewed changes

src/platform/ESP32/Logging.cpp Outdated Show resolved Hide resolved

examples/platform/esp32/PigweedLogger.cpp Show resolved Hide resolved

src/platform/ESP32/Logging.cpp Show resolved Hide resolved

src/platform/ESP32/Logging.cpp Show resolved Hide resolved

tehampson reviewed May 3, 2023

View reviewed changes

examples/platform/esp32/PigweedLogger.cpp Show resolved Hide resolved

examples/platform/esp32/PigweedLogger.cpp Show resolved Hide resolved

shubhamdp force-pushed the esp32_logging branch from f01db6b to 2ebccbe Compare May 4, 2023 18:08

github-actions bot added config esp32 examples platform labels May 4, 2023

shubhamdp added 3 commits May 8, 2023 17:02

[ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros

dd4b4d7

Basically this unreverts the project-chip#26282 with additional changes to fixed the rpc logging problem introduced in project-chip#26227.

Fix the bug when setting the log level

c4e4566

remove the log level check

8cd120b

shubhamdp force-pushed the esp32_logging branch from 71da028 to 8cd120b Compare May 8, 2023 11:33

dhrishi reviewed May 8, 2023

View reviewed changes

examples/platform/esp32/PigweedLogger.cpp Outdated Show resolved Hide resolved

examples/platform/esp32/PigweedLogger.cpp Outdated Show resolved Hide resolved

Fix the color codes for pigweed logs

fc2105d

shubhamdp requested review from dhrishi and tehampson May 8, 2023 12:53

tehampson approved these changes May 8, 2023

View reviewed changes

examples/platform/esp32/PigweedLogger.cpp Show resolved Hide resolved

Added comment explaining the addition of color codes in pigweed logger

30854b9

dhrishi approved these changes May 8, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels May 8, 2023

tehampson merged commit fda94b3 into project-chip:master May 8, 2023

shubhamdp deleted the esp32_logging branch May 10, 2023 05:21

shubhamdp mentioned this pull request May 10, 2023

cherry-pick [ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros #26348 #26477

Merged

andy31415 added the cherry picked to 1.1 label May 10, 2023

shubhamdp mentioned this pull request Oct 10, 2024

esp32-fix-empty-logs(#35939) #35965

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros #26348

[ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros #26348

shubhamdp commented May 3, 2023 •

edited

Loading

tehampson left a comment

github-actions bot commented May 4, 2023

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

[ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros #26348

[ESP32] Use esp_log_writev() for logging rather than ESP_LOGx macros #26348

Conversation

shubhamdp commented May 3, 2023 • edited Loading

Change Overview

Tests

tehampson left a comment

Choose a reason for hiding this comment

github-actions bot commented May 4, 2023

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

shubhamdp commented May 3, 2023 •

edited

Loading