Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implemented Json to Tlv and Tlv to Json Converter in Kotlin (#26458)" #26492

Merged
merged 1 commit into from
May 11, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This reverts commit 60866e8.

#26458 was merged with failing CI, and the failure is in the files the PR added. CI is now permanently failing.

…roject-chip#26458)"

This reverts commit 60866e8.

project-chip#26458 was merged with
failing CI, and the failure is in the files the PR added.  CI is now permanently
failing.
@bzbarsky-apple bzbarsky-apple added the hotfix urgent fix needed, can bypass review label May 10, 2023
@github-actions
Copy link

PR #26492: Size comparison from 8a5b352 to fab113f

Increases (2 builds for bl602, bl702)
platform target config section 8a5b352 fab113f change % change
bl602 lighting-app bl602+rpc .text 1067330 1067334 4 0.0
bl702 lighting-app bl702+rpc (read/write) 1273555 1273571 16 0.0
.debug_info 45848902 45848903 1 0.0
.text 1038096 1038098 2 0.0
Full report (7 builds for bl602, bl702, linux, mbed)
platform target config section 8a5b352 fab113f change % change
bl602 lighting-app bl602 (read/write) 1354990 1354990 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035976 1035976 0 0.0
bl602+rpc (read/write) 1401266 1401266 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067330 1067334 4 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185759 1185759 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1550204 1550204 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488804 488804 0 0.0
.debug_info 40943089 40943089 0 0.0
.debug_line 5301455 5301455 0 0.0
.debug_loc 3424613 3424613 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708223 3708223 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106304 106304 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580786 580786 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 965472 965472 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1273555 1273571 16 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1706954 1706954 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516776 516776 0 0.0
.debug_info 45848902 45848903 1 0.0
.debug_line 5716360 5716360 0 0.0
.debug_loc 3626917 3626917 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133328 4133328 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641456 641456 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1038096 1038098 2 0.0
linux chip-tool-ipv6only arm64 (read only) 12259676 12259676 0 0.0
(read/write) 746696 746696 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 570208 570208 0 0.0
.text 9916724 9916724 0 0.0
thermostat-no-ble arm64 (read only) 2528308 2528308 0 0.0
(read/write) 145816 145816 0 0.0
.bss 56392 56392 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 78048 78048 0 0.0
.dynamic 560 560 0 0.0
.got 5472 5472 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 130136 130136 0 0.0
.text 2133440 2133440 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495056 2495056 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457740 1457740 0 0.0

@emargolis emargolis merged commit bf14d4a into project-chip:master May 11, 2023
@bzbarsky-apple bzbarsky-apple deleted the revert-json-to-tlv branch May 11, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller examples hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants