-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JNI type casts in matter jni layer #26559
Fix JNI type casts in matter jni layer #26559
Conversation
35b11b0
to
e39eaa6
Compare
PR #26559: Size comparison from 42f38de to e39eaa6 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
1a56b54
to
9286a86
Compare
11fcece
to
3b2a2bb
Compare
PR #26559: Size comparison from 42f38de to 3b2a2bb Increases (1 build for cc32xx)
Decreases (2 builds for bl702)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
3b2a2bb
to
f19507e
Compare
dd69c81
to
4ac4ad0
Compare
68c1169
to
2a450aa
Compare
PR #26559: Size comparison from 4083b32 to 2a450aa Increases (3 builds for bl602, cc32xx, psoc6)
Decreases (3 builds for bl702, cyw30739, psoc6)
Full report (22 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6)
|
2a450aa
to
9c44788
Compare
PR #26559: Size comparison from 4083b32 to 9c44788 Increases (8 builds for bl602, cc13x2_26x2, cc32xx, esp32, psoc6)
Decreases (3 builds for bl702, cyw30739)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6)
|
9c44788
to
7994afc
Compare
PR #26559: Size comparison from 4083b32 to 7994afc Increases (6 builds for cc32xx, esp32, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, telink)
Full report (62 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
The Android TV App seems to be giving build errors. |
a90b157
to
ab38ab9
Compare
PR #26559: Size comparison from a33249d to ab38ab9 Increases (1 build for qpg)
Decreases (1 build for cc32xx)
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
ab38ab9
to
a5aa595
Compare
PR #26559: Size comparison from a33249d to a5aa595 Increases (12 builds for bl602, bl702, esp32, psoc6, qpg, telink)
Decreases (4 builds for psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
a5aa595
to
79c89d6
Compare
PR #26559: Size comparison from a33249d to 79c89d6 Increases (7 builds for cc32xx, esp32, psoc6, qpg, telink)
Decreases (8 builds for nrfconnect, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
79c89d6
to
1e73a07
Compare
PR #26559: Size comparison from b4fb147 to 1e73a07 Increases (7 builds for bl602, bl702, cc32xx, psoc6)
Decreases (4 builds for cyw30739, esp32, psoc6)
Full report (42 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
1e73a07
to
6e298c8
Compare
PR #26559: Size comparison from 6e6a2a6 to 6e298c8 Increases (14 builds for bl602, bl702, cyw30739, efr32, esp32, psoc6, telink)
Decreases (10 builds for cc32xx, cyw30739, esp32, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fix JNI type casts in matter jni layer
Changes:
J
for long instead ofI
for int as methods evolved)static_cast
to JNI-specific types. Without this we found that auto-promotion may break on architectures wheresizeof(jlong) > sizeof(jint)
, in which case we were passing a 32-bit integer but java was taking out 64-bit integers via varargs, resulting in illegal memory access.