Enable ThreadSanitizer in Darwin CI. #26614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #26614: Size comparison from 06921da to d51e360 Increases above 0.2%:
Increases (6 builds for bl702, esp32, nrfconnect, telink)
Decreases (11 builds for bl602, bl702, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26614: Size comparison from 06921da to 93ba582 Increases above 0.2%:
Increases (14 builds for bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (13 builds for bl602, bl702, nrfconnect, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
May 16, 2023
|
Fast-tracking platform-specific change with platform owner review. |
|
PR #26614: Size comparison from 06921da to a952fbf Increases above 0.2%:
Increases (42 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl702, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 24, 2023
Unfortunately, "-enableAddressSanitizer NO" does not seem to override the scheme, and you can't do both AddressSanitizer and ThreadSanitizer at once, so this turns off AddressSanitizer in the scheme and manually enables it in the command line for the test.
bzbarsky-apple
force-pushed
the
enable-tsan-darwin-ci
branch
from
a952fbf
to
1628617
Compare
|
PR #26614: Size comparison from 80bce56 to 1628617 Increases (3 builds for esp32, telink)
Decreases (13 builds for bl602, efr32, esp32, nrfconnect, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, "-enableAddressSanitizer NO" does not seem to override the scheme, and you can't do both AddressSanitizer and ThreadSanitizer at once, so this turns off AddressSanitizer in the scheme and manually enables it in the command line for the test.