Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reporting of event path errors in MTRBaseDevice. #26822

Merged
merged 1 commit into from
May 25, 2023
Merged

Fix reporting of event path errors in MTRBaseDevice. #26822

merged 1 commit into from
May 25, 2023

Commits on May 25, 2023

  1. Fix reporting of event path errors in MTRBaseDevice. 

    Two main fixes here:

* Don't lose the prceise error if we have one in OnEventData.
* Use the right path key in our report dictionary for event errors.

The path key problem has not been shipped in any releases before, so no
backports needed.

The other changes are just aligning the attribute and event cases on checking
"is this a path we expected a report for?" before actually looking at the report
we got.
    @bzbarsky-apple
    bzbarsky-apple committed May 25, 2023
    Configuration menu
    Copy the full SHA
    fd200bc View commit details
    Browse the repository at this point in the history