Add Air Quality Cluster to All Clusters Example (#26765) #26834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #26834: Size comparison from 9f43988 to 157702d Decreases (1 build for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
|
PR #26834: Size comparison from 9f43988 to 2ed0cc0 Increases (2 builds for bl702)
Decreases (2 builds for efr32, qpg)
Full report (15 builds for bl602, bl702, cc32xx, efr32, k32w, mbed, qpg)
|
needed for some build targets (#26765)
|
PR #26834: Size comparison from 9f43988 to 31a7540 Increases (20 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (5 builds for efr32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 25, 2023
To include all the features in the all clusters example app.
cecille
approved these changes
May 26, 2023
tobiasgraf
deleted the
26765-add-air-quality-cluster-to-all-clusters-example
branch
rfortunatov
pushed a commit
to rfortunatov/connectedhomeip
that referenced
this pull request
Jun 8, 2023
…roject-chip#26834) * Add Air Quality Cluster to All Clusters Example (project-chip#26765) * Add missing .matter file * Add MatterAirQualityPluginServerInitCallback() to util.cpp needed for some build targets (project-chip#26765) * Update Featuremap from 0 to 15 To include all the features in the all clusters example app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR adds the air quality cluster to the all clusters example app.
🔎 Details
examples/all-clusters-app/all-clusters-common/all-clusters-app.zapfile.src/app/zap_cluster_list.jsonfile.🧪 How Has This Been Tested
all-clusters-example-app built and paired with chip-tool.
requested air-quality attribute, featuremap, etc. from the air quality cluster of the all-clusters-example-app
🔗 Links/References
closes #26765