Make output class directory unique for java #26893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #26893: Size comparison from 8f16fe9 to 5a90fbc Increases (9 builds for bl602, bl702, cc13x4_26x4, cc32xx, psoc6, qpg)
Decreases (3 builds for efr32, esp32)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yufengwangca
approved these changes
May 26, 2023
yufengwangca
approved these changes
May 26, 2023
yunhanw-google
approved these changes
May 26, 2023
yunhanw-google
approved these changes
May 26, 2023
…nux and mac generally)
…f controller anymore
emargolis
approved these changes
May 26, 2023
|
PR #26893: Size comparison from 8f16fe9 to 9c83e76 Increases (15 builds for bl702, cc13x4_26x4, cc32xx, esp32, linux, nrfconnect, psoc6, qpg)
Decreases (6 builds for bl602, cc13x4_26x4, efr32, k32w, psoc6, qpg)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #26893: Size comparison from 8f16fe9 to d05fb64 Increases (14 builds for bl602, bl702, cc13x4_26x4, cc32xx, linux, nrfconnect, psoc6, qpg)
Decreases (2 builds for efr32, psoc6)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
approved these changes
May 27, 2023
|
PR #26893: Size comparison from 8f16fe9 to 9f669d8 Increases above 0.2%:
Increases (28 builds for bl702, cc13x4_26x4, cc32xx, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for cc13x4_26x4, efr32, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26893: Size comparison from 8f16fe9 to 47f9555 Increases above 0.2%:
Increases (30 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for cc13x4_26x4, efr32, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks to fix the
chip.jsontlv.toJsonStringerror that we seem to be getting (i.e. fixes #26815)From what I can tell, each compilation used to codegen under
classessubdirectory, so if different classes compile things, we may end up with different versions of the same code.From my local tests, applying this change fixed an always-reproducible fromJsonString error, so I assume this works on current codebase as well.
Before this change, every jar file built ended up containing ALL the class files that were built for all targets (but random content because racy). After this change I see the correct content, like:
As a sideffect now,
CHIPController.jardoes not contain tlv classes anymore, so had to:libsfolder.The classpath iterations could use some more revisions ... they feel a bit hardcoded now, I would rather expect our builds to be able to output some form of dependencies to automate things.