Replace usages of emberPrintln with ChipLogProgress calls #27035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
rg emberAfPrintln src examples --files-with-matches | xargs sd 'emberAfPrintln\(EMBER_AF_PRINT_DEBUG, ("[^)]*\);)' 'ChipLogDetail($1'
```
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
andy31415
changed the title
|
PR #27035: Size comparison from d7dbc7a to c1fef18 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jmartinez-silabs
approved these changes
Jun 2, 2023
I believe we may, however maybe as a followup by people with domain knowledge. |
|
PR #27035: Size comparison from 0d6dfde to d859985 Increases above 0.2%:
Increases (27 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (33 builds for bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jun 2, 2023
|
PR #27035: Size comparison from 0d6dfde to 30f007d Increases above 0.2%:
Increases (21 builds for cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (43 builds for bl602, bl702, cc32xx, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 2, 2023
yufengwangca
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHIP debug logs should use ChipLogProgress/Detail/Error rather than ember macros. Only few usages of ember macros
still existed.
Changes:
previous per-cluster code seems to have been guarded by
EMBER_AF_PRINT_ENABLEwhich was not set, hence the increase in size of the lock example. However it seemed odd to actually disable printouts of several error messages because of this, so for now I will assume that the print disabling was an oversight (especially for errors). We can iterate and convert things to LogDetail or guard logs with additional defines as a followup.