[Android] Decouple generated API - 2 #28010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonhaengHeo
changed the title
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs and
jmartinez-silabs
andy31415
approved these changes
Jul 31, 2023
It turns out our CI forces format, pushed new revisions with formating applied. Codegen should probably do this automatically, but we don't have that yet. |
|
PR #28010: Size comparison from 12a1d38 to 220822a Increases (1 build for bl602)
Decreases (3 builds for bl702, cc32xx, nrfconnect)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
|
PR #28010: Size comparison from 12a1d38 to dd77b5e Increases above 0.2%:
Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for k32w)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #28010: Size comparison from 0d81aa5 to 35e6049 Increases (10 builds for cc32xx, cyw30739, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, bl702, bl702l, k32w, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #28010: Size comparison from 7df6d0a to b849f7a Increases (9 builds for bl702l, cyw30739, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc32xx, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
force-pushed
the
decouple_generated_api_2
branch
from
ae2cec6
to
dd77b5e
Compare
|
PR #28010: Size comparison from 32efabd to 766c3ff Increases (7 builds for bl702, cc32xx, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702l, cyw30739, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@andy31415 Exception in thread "main" java.lang.UnsupportedClassVersionError: com/google/googlejavaformat/FormattingError has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0 I think "ZAP / ZAP templates generation" is running in Java 8. Do you know how to solve this? |
Will have to use an updated java it seems. Will have to check how. |
|
PR #28010: Size comparison from efc6c7d to 36b97e2 Full report (4 builds for cc32xx, mbed, qpg)
|
|
PR #28010: Size comparison from efc6c7d to b9ac195 Increases (18 builds for bl702, bl702l, efr32, esp32, linux, psoc6, telink)
Decreases (8 builds for cc32xx, cyw30739, efr32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* decouple ChipStructs, ChipIDMapping * modify build.gn * restore kotlin file * Restyled by autopep8 * add matter idl file * Seperate each class * Restyled by autopep8 * add exclude kotlin check (generated file) * remove previous generated file * add kotlin check config * relocation * remodified * Remove MagicNumber check * remove kotlin check exception * Update generated kt file * update TlvReaderExt * modify unused import * Update generated file * Update unit test * fix kotlin static check error * Restyled by whitespace * update build.gn * Kotlin format * Run kotlin format during zap regen * Restyled by autopep8 * Fix traceback print * Install a newer openjdk for zap generation * Try to make linter happy * Try to make linter happy * Fix unit tests --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27398
Make CHIPClusterID.jar (Cluster / Attribute / Event / Command ID)
Make CHIPCluster.jar -> ChipStruct.kt, ChipEventStruct.kt
-> For reduce CHIPController.jar size.