Get configure working again and fix the minimal build #28547
Merged
+49
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configure script is a replacement for running PW bootstrap, so running bootstrap first makes this no longer a valid test of how the configure script sets up the build environment from scratch.
This is a workaround for the Debian / Ubuntu missing the ensurepip module used by venv unless python3-venv is installed, which is "suggested" but not required by the python3 package, and hence may or may not be installed in build environments. (https://bugs.launchpad.net/bugs/1290847) Also avoid := syntax which is unavailable on Python 3.7
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
Minimal build regressed in #28404 which picked up this Pigweed change: google/pigweed@0889de6 |
|
PR #28547: Size comparison from 8363494 to 29015b8 Increases (14 builds for bl602, k32w, nrfconnect, psoc6, telink)
Decreases (3 builds for cc32xx, efr32, esp32)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 7, 2023
|
Submitted a Pigweed issue here: https://issues.pigweed.dev/issues/294886611 |
0889de6 introduced https://issues.pigweed.dev/issues/294886611 which breaks the configure-based build.
|
PR #28547: Size comparison from 8363494 to 2734c14 Increases above 0.2%:
Increases (51 builds for bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (17 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, nrfconnect, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
saurabhst
approved these changes
Aug 8, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…8547) * Don't bootstrap in minimal-build workflow The configure script is a replacement for running PW bootstrap, so running bootstrap first makes this no longer a valid test of how the configure script sets up the build environment from scratch. * configure: bootstrap pip from pypa.io if necessary This is a workaround for the Debian / Ubuntu missing the ensurepip module used by venv unless python3-venv is installed, which is "suggested" but not required by the python3 package, and hence may or may not be installed in build environments. (https://bugs.launchpad.net/bugs/1290847) Also avoid := syntax which is unavailable on Python 3.7 * configure: use x64 build of zap even on arm (there is no mac arm build) * configure: Add matter_ argument prefixes * Revert pigweed to 0889de6~1 0889de6 introduced https://issues.pigweed.dev/issues/294886611 which breaks the configure-based build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python3package installs on Debian / Ubuntu