-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SmokeCO TC's in chip-all-clusters-app #28548
Conversation
Address Issues: Fixes Cert blocker issues : 28193, 27747, 27746, 27742, 27731
PR #28548: Size comparison from 32efabd to 50b4514 Increases above 0.2%:
Increases (53 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (14 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28548: Size comparison from 32efabd to 265feb3 Increases above 0.2%:
Increases (53 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (14 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I temporarily enabled Unit Testing cluster to test TC-2.2 and TC-2.6 to verify that the changes made to all-cluster-app are working well.
|
examples/all-clusters-app/all-clusters-common/src/smco-stub.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/src/smco-stub.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/SmokeCOTestEventTriggerDelegate.h
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/SmokeCOTestEventTriggerDelegate.h
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
PR #28548: Size comparison from 32efabd to 229b355 Increases above 0.2%:
Increases (52 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6)
Full report (57 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/SmokeCOTestEventTriggerDelegate.cpp
Outdated
Show resolved
Hide resolved
…Delegate.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
This reverts commit 25c27da.
…8548) * Add support for SmokeCO TC's in chip-all-clusters-app Address Issues: Fixes Cert blocker issues : 28193, 27747, 27746, 27742, 27731 * Improve SmokeCO TC support in all-clusters-app * Move priority order to server * Revision per review comments * Make smco-test-event-trigger public * Add deps to tizen * Revision per review comments * Add LogErrorOnFailure * Update src/app/clusters/smoke-co-alarm-server/SmokeCOTestEventTriggerDelegate.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Revert "Add LogErrorOnFailure" This reverts commit 25c27da. * Add ChipLogError * Remove redundant code --------- Co-authored-by: Chris Beach <chrisbeach59@gmail.com> Co-authored-by: Hare <renilr0@outlook.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…8548) * Add support for SmokeCO TC's in chip-all-clusters-app Address Issues: Fixes Cert blocker issues : 28193, 27747, 27746, 27742, 27731 * Improve SmokeCO TC support in all-clusters-app * Move priority order to server * Revision per review comments * Make smco-test-event-trigger public * Add deps to tizen * Revision per review comments * Add LogErrorOnFailure * Update src/app/clusters/smoke-co-alarm-server/SmokeCOTestEventTriggerDelegate.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Revert "Add LogErrorOnFailure" This reverts commit 25c27da. * Add ChipLogError * Remove redundant code --------- Co-authored-by: Chris Beach <chrisbeach59@gmail.com> Co-authored-by: Hare <renilr0@outlook.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Fixes #28193