-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle StopPairing more cleanly in DeviceController #28939
Merged
mergify
merged 2 commits into
project-chip:master
from
ksperling-apple:device-controller-stop-pairing
Aug 30, 2023
Merged
Handle StopPairing more cleanly in DeviceController #28939
mergify
merged 2 commits into
project-chip:master
from
ksperling-apple:device-controller-stop-pairing
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the controller is not left in a state where further commissioning operations after a StopPairing call are rejected because pairing is already "in progress".
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
August 29, 2023 04:08
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
August 29, 2023 04:08
PR #28939: Size comparison from ba6af3c to a44237c Increases (3 builds for linux, telink)
Decreases (2 builds for efr32, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Aug 29, 2023
bzbarsky-apple
approved these changes
Aug 30, 2023
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #28939: Size comparison from ba6af3c to 967a758 Increases above 0.2%:
Increases (53 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (30 builds for bl702, bl702l, cc32xx, efr32, linux, mbed, nrfconnect, psoc6)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
* Handle StopPairing more cleanly in DeviceController This ensures the controller is not left in a state where further commissioning operations after a StopPairing call are rejected because pairing is already "in progress". * Comment typo Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Handle StopPairing more cleanly in DeviceController This ensures the controller is not left in a state where further commissioning operations after a StopPairing call are rejected because pairing is already "in progress". * Comment typo Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the controller is not left in a state where further commissioning operations after a StopPairing call are rejected because pairing is already "in progress".