-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rvc example app #29103
Merged
Merged
Add rvc example app #29103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the mapping mode.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple and
cecille
September 7, 2023 08:34
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
September 7, 2023 08:34
PR #29103: Size comparison from 0e7d3b7 to 76c0c34 Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
plauric
approved these changes
Sep 7, 2023
bzbarsky-apple
approved these changes
Sep 8, 2023
…meip into add_rvc_example_app
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #29103: Size comparison from e29cd6a to 58b7e23 Increases (2 builds for bl702, telink)
Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
* Added an RVC app example containg the RvcRunMode and RvcClean clusters. * Regenerated zap code. * Added the RvcRunMode and RvcClean clusters' logic to the RVC app example. * Added the RvcOpState cluster's logic to the RVC app example. * Added documentation about the RVC example app. * Added an implementation for the GetCoutdownTime virtual function. * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Added constants for the Cluster's endpoints. Adde vendor mode tags for the mapping mode. * Restyled by clang-format * Fixed the feature value for the RvcRun and RvcClean clusters. * Restyled by clang-format * zap regen after pull. * Removed unused clusters form the zap and matter files. * RVC App: Removed unneccissary error checking. * RVC App: Changed how the RVC cluster endpoint IDs are set. * RVC App: refactored method parameter names. * Update examples/rvc-app/linux/include/CHIPProjectAppConfig.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Matt Hazley <hello@matthazley.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Added an RVC app example containg the RvcRunMode and RvcClean clusters. * Regenerated zap code. * Added the RvcRunMode and RvcClean clusters' logic to the RVC app example. * Added the RvcOpState cluster's logic to the RVC app example. * Added documentation about the RVC example app. * Added an implementation for the GetCoutdownTime virtual function. * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Added constants for the Cluster's endpoints. Adde vendor mode tags for the mapping mode. * Restyled by clang-format * Fixed the feature value for the RvcRun and RvcClean clusters. * Restyled by clang-format * zap regen after pull. * Removed unused clusters form the zap and matter files. * RVC App: Removed unneccissary error checking. * RVC App: Changed how the RVC cluster endpoint IDs are set. * RVC App: refactored method parameter names. * Update examples/rvc-app/linux/include/CHIPProjectAppConfig.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Matt Hazley <hello@matthazley.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #28719. There was something strange going on with the CI tests so we are trying to create another PR to see if it will fix things.
Fixes #28564.
This PR adds an example RVC app that integrates the RvcRunMode and RvcOperationalState clusters with logic as would be expected it a typical RVC implementation. Below is a visual representation of the state machine of the RVC example app.