Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Added a way of activating the report on active mode from icd.gni #29234

Merged
merged 6 commits into from
Oct 5, 2023
Merged

[ICD] Added a way of activating the report on active mode from icd.gni #29234

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
07843c0
Added a way of activating the report on active mode from icd manager …
lpbeliveau-silabs Sep 13, 2023
0690f55
Restyled by shfmt
restyled-commits Sep 13, 2023
844a7a1
Moved the ICD_REPORT_ON_ENTER_ACTIVE_MODE in the report scheduler imp…
lpbeliveau-silabs Sep 14, 2023
767d3d7
Moved the report on active define to the app BUILD.gn and removed un-…
lpbeliveau-silabs Oct 2, 2023
28df040
Removed preset
lpbeliveau-silabs Oct 3, 2023
02c6814
Added include AppBuildConfig
lpbeliveau-silabs Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/examples/gn_silabs_example.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ else
# optArgs+="openthread_root=\"//third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread\" openthread_efr32_root=\"//third_party/connectedhomeip/third_party/openthread/ot-efr32/src/src\""
# shift
# ;;
--report_on_active)
optArgs+="chip_report_on_active_mode=true "
shift
;;
lpbeliveau-silabs marked this conversation as resolved.
Show resolved Hide resolved
--release)
optArgs+="is_debug=false disable_lcd=true chip_build_libshell=false enable_openthread_cli=false use_external_flash=false chip_logging=false silabs_log_enabled=false "
shift
Expand Down Expand Up @@ -323,7 +327,7 @@ else
source "$CHIP_ROOT/scripts/activate.sh"
fi

ninja -v -C "$BUILD_DIR"/
ninja -C "$BUILD_DIR"/
#print stats
arm-none-eabi-size -A "$BUILD_DIR"/*.out

Expand Down
1 change: 1 addition & 0 deletions src/app/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ buildconfig_header("app_buildconfig") {
"CHIP_CONFIG_ENABLE_EVENTLIST_ATTRIBUTE=${enable_eventlist_attribute}",
"CHIP_CONFIG_ENABLE_ICD_SERVER=${chip_enable_icd_server}",
"CHIP_CONFIG_ENABLE_READ_CLIENT=${chip_enable_read_client}",
"ICD_REPORT_ON_ENTER_ACTIVE_MODE=${chip_report_on_active_mode}",
lpbeliveau-silabs marked this conversation as resolved.
Show resolved Hide resolved
lpbeliveau-silabs marked this conversation as resolved.
Show resolved Hide resolved
]
}

Expand Down
5 changes: 0 additions & 5 deletions src/app/icd/ICDManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,6 @@
#define ICD_ENFORCE_SIT_SLOW_POLL_LIMIT 0
#endif

#ifndef ICD_REPORT_ON_ENTER_ACTIVE_MODE
// Enabling this makes the device emit subscription reports when transitioning from idle to active mode.
#define ICD_REPORT_ON_ENTER_ACTIVE_MODE 0
#endif

namespace chip {
namespace app {

Expand Down
3 changes: 3 additions & 0 deletions src/app/icd/icd.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ declare_args() {
# Matter SDK Configuration flag to enable ICD client functionality
# TODO - Add Specifics when the design is refined
chip_enable_icd_client = false

# Matter SDK Configuration flag to make the ICD manager emit a report on entering active mode
chip_report_on_active_mode = false
}
Loading