-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align OTA cluster XML with the specification. #29459
Merged
mergify
merged 4 commits into
project-chip:master
from
bzbarsky-apple:align-ota-clusters
Oct 11, 2023
Merged
Align OTA cluster XML with the specification. #29459
mergify
merged 4 commits into
project-chip:master
from
bzbarsky-apple:align-ota-clusters
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
examples
scripts
platform
darwin
esp32
linux
nrf connect
lib
controller
app
telink
shell
tests
test driver
silabs
labels
Sep 26, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro and
cliffamzn
September 26, 2023 18:23
andy31415
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Sep 27, 2023
Applied |
bzbarsky-apple
force-pushed
the
align-ota-clusters
branch
from
October 11, 2023 15:06
8d03728
to
5f7731a
Compare
github-actions
bot
removed
platform
esp32
linux
nrf connect
lib
telink
shell
tests
silabs
labels
Oct 11, 2023
PR #29459: Size comparison from e8f516a to 5f7731a Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tcarmelveilleux
approved these changes
Oct 11, 2023
bzbarsky-apple
force-pushed
the
align-ota-clusters
branch
from
October 11, 2023 15:17
5f7731a
to
02e3357
Compare
PR #29459: Size comparison from e8f516a to 2188f81 Increases (12 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (12 builds for bl702, bl702l, cc32xx, psoc6)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
This fixes the enum names to match. The difference in the ProviderLocation name is being addressed in the spec in CHIP-Specifications/connectedhomeip-spec#7580
bzbarsky-apple
force-pushed
the
align-ota-clusters
branch
from
October 11, 2023 17:17
2188f81
to
e91e9d1
Compare
jmartinez-silabs
approved these changes
Oct 11, 2023
PR #29459: Size comparison from 1f2c1cb to e91e9d1 Increases (13 builds for bl602, bl702, bl702l, cc32xx, psoc6)
Decreases (13 builds for bl702, bl702l, cc32xx, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Align OTA cluster XML with the specification. This fixes the enum names to match. The difference in the ProviderLocation name is being addressed in the spec in CHIP-Specifications/connectedhomeip-spec#7580 * Auto-update ZAP files. * Regenerate generated code. * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
documentation
Improvements or additions to documentation
examples
review - approved
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
test driver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the enum names to match.
The difference in the ProviderLocation name is being addressed in the spec in
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7580
REVIEW NOTE: The first changeset was created manually (though with some
git sed
involved). The second and third are auto-generated.