-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix constexpr complaints on test vectors #29462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29462: Size comparison from 9853ecf to 3fb83ea Decreases (2 builds for bl602, telink)
Full report (60 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
ksperling-apple
approved these changes
Sep 26, 2023
PR #29462: Size comparison from 9853ecf to 3256c21 Increases (10 builds for linux)
Decreases (4 builds for linux)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29462: Size comparison from 9853ecf to 3d21d44 Increases above 0.2%:
Increases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for linux)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
force-pushed
the
fix_constexpr
branch
from
September 28, 2023 01:12
3d21d44
to
3256c21
Compare
cecille
force-pushed
the
fix_constexpr
branch
from
September 28, 2023 01:18
3d21d44
to
448104e
Compare
bzbarsky-apple
approved these changes
Sep 28, 2023
src/credentials/attestation_verifier/CHIPAttCert_test_paa_store.h
Outdated
Show resolved
Hide resolved
PR #29462: Size comparison from beedba2 to 031519c Increases (9 builds for linux)
Decreases (4 builds for linux)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29462: Size comparison from beedba2 to 59fead2 Increases (9 builds for linux)
Decreases (5 builds for bl702, linux)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29462: Size comparison from beedba2 to 6c44978 Increases (9 builds for linux)
Decreases (5 builds for bl602, linux)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
mspang,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
younghak-hwang,
yufengwangca and
yunhanw-google
September 28, 2023 21:04
tehampson
approved these changes
Sep 29, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Fix constexpr complaints on test vectors * Attempt #2 - separate PAAs used in non-test * Things work better when we add all the files * Restyled by whitespace * Restyled by clang-format * add tokenizer * add the gni * add pigweed import * Change filenames * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compiler error on local where const values are being used to initialize a constexpr bytespan.