-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BasicInformation cluster revision from 1 to 2 in zap configura… #29764
Merged
mergify
merged 3 commits into
project-chip:master
from
jmartinez-silabs:basic_info_revision
Oct 14, 2023
Merged
Update BasicInformation cluster revision from 1 to 2 in zap configura… #29764
mergify
merged 3 commits into
project-chip:master
from
jmartinez-silabs:basic_info_revision
Oct 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
October 13, 2023 18:57
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 13, 2023 18:57
PR #29764: Size comparison from 7c4956e to 443bfa4 Full report (2 builds for cc32xx, mbed)
|
PR #29764: Size comparison from 7c4956e to 45b362b Full report (1 build for cc32xx)
|
PR #29764: Size comparison from 7c4956e to 800a3f8 Increases (1 build for bl602)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Oct 13, 2023
bzbarsky-apple
approved these changes
Oct 14, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
project-chip#29764) * Update BasicInformation cluster revision from 1 to 2 in zap configuration * Regen all * google-style kotlin files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
Done with the following script
scripts/tools/zap/update_cluster_revisions.py --cluster-id 0x0028 --new-revision 2 --old-revision 1
and regen all with
./scripts/tools/zap_regen_all.py
The cluster's Xml has already been updated to revision 2 a while back