Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux] Wrap BlueZ connection functions in a class #29798

Merged
merged 17 commits into from
Oct 19, 2023
Merged

[Linux] Wrap BlueZ connection functions in a class #29798

merged 17 commits into from
Oct 19, 2023

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Oct 16, 2023 •
edited
Loading

Problem

BluezConnection struct can be converted to a class in order to narrow "public" interface.

Changes

  • convert BluezConnection struct to class
  • move IO channels creation to BluezConnection via SetupWriteHandler() and SetupNotifyHandler() public API
  • use RAII for managing ConnectionDataBundle and IOChannel members
  • do not use BLE_CONNECTION_OBJECT by internal implementation
  • fix notify IOChannel setup for additional advertising
  • use on-stack array for reading characteristic

Testing

Locally tested BLE commissioning with ble-wifi type.
CI will test potential build brakes.

@arkq
Do not use BLE_CONNECTION_OBJECT by internal implementation
54a4f8d
@arkq
Wrap BluezConnection in a class
0734f48
@arkq
Store const ref to connection in ConnectionDataBundle
0cf9611
@arkq
Simplify get connection MTU method
a734c16
@arkq
Add proxy method for getting device address
f9de24e
@arkq
Allocate ConnectionDataBundle on stack
c29fdd4
@arkq
Add destructor to IOChannel
6985067
@arkq
Remove Bluez from public method names
dffd16b
@arkq
Move IO channels creation to BluezConnection
46bdc20
@arkq
Fix notify callback setup for additional advertising
282dd72
@arkq
Fix FD leak in case of g_variant_lookup failure
fa5c5ac
@arkq
Move IO channel handlers to BluezConnection class
f4a5511
@arkq
Manage IOChannel members with GAutoPtr
c552242
@arkq
Use on-stack array for reading characteristic
0c1373d
@arkq
Document FD closing behavior by setup methods
1c2b99e
@arkq
Fix GSource deleter
7fd333c
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

PR #29798: Size comparison from 48aec5f to 7fd333c

Increases above 0.2%:

platform target config section 48aec5f 7fd333c change % change
linux chip-tool-ipv6only arm64 .got 18400 18504 104 0.6
Increases (10 builds for linux)
platform target config section 48aec5f 7fd333c change % change
linux all-clusters-app debug (read only) 5500417 5502193 1776 0.0
.text 4784179 4786179 2000 0.0
all-clusters-minimal-app debug (read only) 4877609 4879409 1800 0.0
.text 4376483 4378499 2016 0.0
bridge-app debug (read only) 4359329 4361105 1776 0.0
.text 3923779 3925779 2000 0.1
chip-tool debug (read only) 1023238 10234257 1872 0.0
.text 9248339 9250435 2096 0.0
chip-tool-ipv6only arm64 (read only) 10104380 1010529 912 0.0
(read/write) 505320 505400 80 0.0
.got 18400 18504 104 0.6
.text 9023080 9024040 960 0.0
lighting-app debug+rpc+ui (read only) 5217409 5219169 1760 0.0
.text 4638067 4640083 2016 0.0
lock-app debug (read only) 4455577 4457425 1848 0.0
.text 3999587 4001651 2064 0.1
shell debug (read only) 2908033 2909857 1824 0.1
.text 2523554 2525634 2080 0.1
tv-app debug (read only) 5279505 5281633 2128 0.0
.text 4764691 4766947 2256 0.0
tv-casting-app debug (read only) 8183193 8185321 2128 0.0
.text 7443139 7445395 2256 0.0
Decreases (10 builds for linux)
platform target config section 48aec5f 7fd333c change % change
linux all-clusters-app debug (read/write) 420528 420496 -32 -0.0
.got 5368 5360 -8 -0.1
.rodata 335468 335340 -128 -0.0
all-clusters-minimal-app debug .got 5328 5320 -8 -0.2
.rodata 270205 270077 -128 -0.0
bridge-app debug .got 5296 5288 -8 -0.2
.rodata 218109 217981 -128 -0.1
chip-tool debug .got 5792 5784 -8 -0.1
.rodata 386185 386057 -128 -0.0
chip-tool-ipv6only arm64 .data.rel.ro 374144 374120 -24 -0.0
.rodata 314808 314552 -256 -0.1
lighting-app debug+rpc+ui .got 5912 5904 -8 -0.1
.rodata 336308 336148 -160 -0.0
lock-app debug (read/write) 203096 203064 -32 -0.0
.got 5248 5240 -8 -0.2
.rodata 246589 246461 -128 -0.1
shell debug .got 4096 4088 -8 -0.2
.rodata 211200 211040 -160 -0.1
tv-app debug (read/write) 350640 350608 -32 -0.0
.got 5592 5584 -8 -0.1
.rodata 270925 270893 -32 -0.0
tv-casting-app debug .got 5072 5064 -8 -0.2
.rodata 337336 337304 -32 -0.0
Full report (61 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 48aec5f 7fd333c change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 734843 734843 0 0.0
(read/write) 166444 166444 0 0.0
.bss 88860 88860 0 0.0
.data 3420 3420 0 0.0
.rodata 84287 84287 0 0.0
.text 650168 650168 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 756403 756403 0 0.0
(read/write) 176704 176704 0 0.0
.bss 99084 99084 0 0.0
.data 3440 3440 0 0.0
.rodata 79863 79863 0 0.0
.text 676148 676148 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 743907 743907 0 0.0
(read/write) 171184 171184 0 0.0
.bss 93564 93564 0 0.0
.data 3440 3440 0 0.0
.rodata 105951 105951 0 0.0
.text 637564 637564 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 694659 694659 0 0.0
(read/write) 165536 165536 0 0.0
.bss 87728 87728 0 0.0
.data 3408 3408 0 0.0
.rodata 80111 80111 0 0.0
.text 614160 614160 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 680331 680331 0 0.0
(read/write) 165676 165676 0 0.0
.bss 87872 87872 0 0.0
.data 3404 3404 0 0.0
.rodata 75943 75943 0 0.0
.text 604000 604000 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 617522 617522 0 0.0
(read/write) 206896 206896 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200336 200336 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 936286 936286 0 0.0
.debug_aranges 108672 108672 0 0.0
.debug_frame 366108 366108 0 0.0
.debug_info 20540920 20540920 0 0.0
.debug_line 2654058 2654058 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1632224 1632224 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 112029 112029 0 0.0
.debug_str 3437839 3437839 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106162 106162 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 515741 515741 0 0.0
.symtab 298512 298512 0 0.0
.text 509236 509236 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 551935 551935 0 0.0
.app_xip_area 443137 443137 0 0.0
.bss 63768 63768 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538143 538143 0 0.0
.app_xip_area 424545 424545 0 0.0
.bss 68536 68536 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573567 573567 0 0.0
.app_xip_area 466089 466089 0 0.0
.bss 62520 62520 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 549887 549887 0 0.0
.app_xip_area 439329 439329 0 0.0
.bss 65504 65504 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1006568 1006568 0 0.0
.bss 171952 171952 0 0.0
.data 2692 2692 0 0.0
.text 831904 831904 0 0.0
BRD4187C (read/write) 1093064 1093064 0 0.0
.bss 196116 196116 0 0.0
.data 3300 3300 0 0.0
.text 893628 893628 0 0.0
lock-app BRD4161A+wf200 (read/write) 1103656 1103656 0 0.0
.bss 186664 186664 0 0.0
.data 2708 2708 0 0.0
.text 914260 914260 0 0.0
window-app BRD4187C (read/write) 1129396 1129396 0 0.0
.bss 168532 168532 0 0.0
.data 3172 3172 0 0.0
.text 957672 957672 0 0.0
esp32 all-clusters-app c3devkit (read only) 1162956 1162956 0 0.0
(read/write) 1701876 1701876 0 0.0
.dram0.bss 77560 77560 0 0.0
.dram0.data 13068 13068 0 0.0
.flash.rodata 268528 268528 0 0.0
.flash.text 1162956 1162956 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1205895 1205895 0 0.0
(read/write) 551810 551810 0 0.0
.dram0.bss 84208 84208 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 299964 299964 0 0.0
.flash.text 1200511 1200511 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 588628 588628 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70752 70752 0 0.0
.data 2132 2132 0 0.0
.text 588092 588092 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 683868 683868 0 0.0
.bss 66968 66968 0 0.0
.data 2716 2716 0 0.0
.text 570704 570704 0 0.0
light k32w0+release (read only) 588348 588348 0 0.0
(read/write) 87192 87192 0 0.0
.bss 70448 70448 0 0.0
.data 2120 2120 0 0.0
.text 587812 587812 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 775688 775688 0 0.0
.bss 76612 76612 0 0.0
.data 1928 1928 0 0.0
.text 653688 653688 0 0.0
lock k32w0+release (read only) 560164 560164 0 0.0
(read/write) 85020 85020 0 0.0
.bss 68336 68336 0 0.0
.data 2060 2060 0 0.0
.text 559628 559628 0 0.0
linux all-clusters-app debug (read only) 5500417 5502193 1776 0.0
(read/write) 420528 420496 -32 -0.0
.bss 130352 130352 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 278944 278944 0 0.0
.dynamic 624 624 0 0.0
.got 5368 5360 -8 -0.1
.init 27 27 0 0.0
.init_array 1336 1336 0 0.0
.rodata 335468 335340 -128 -0.0
.text 4784179 4786179 2000 0.0
all-clusters-minimal-app debug (read only) 4877609 4879409 1800 0.0
(read/write) 232664 232664 0 0.0
.bss 126480 126480 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 95280 95280 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5320 -8 -0.2
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 270205 270077 -128 -0.0
.text 4376483 4378499 2016 0.0
bridge-app debug (read only) 4359329 4361105 1776 0.0
(read/write) 214968 214968 0 0.0
.bss 118872 118872 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84624 84624 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5288 -8 -0.2
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218109 217981 -128 -0.1
.text 3923779 3925779 2000 0.1
chip-tool debug (read only) 1023238 10234257 1872 0.0
(read/write) 443488 443488 0 0.0
.bss 93688 93688 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 337584 337584 0 0.0
.dynamic 624 624 0 0.0
.got 5792 5784 -8 -0.1
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 386185 386057 -128 -0.0
.text 9248339 9250435 2096 0.0
chip-tool-ipv6only arm64 (read only) 10104380 1010529 912 0.0
(read/write) 505320 505400 80 0.0
.bss 103048 103048 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 374144 374120 -24 -0.0
.dynamic 512 512 0 0.0
.got 18400 18504 104 0.6
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 314808 314552 -256 -0.1
.text 9023080 9024040 960 0.0
lighting-app debug+rpc+ui (read only) 5217409 5219169 1760 0.0
(read/write) 222960 222960 0 0.0
.bss 118160 118160 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 92832 92832 0 0.0
.dynamic 672 672 0 0.0
.got 5912 5904 -8 -0.1
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 336308 336148 -160 -0.0
.text 4638067 4640083 2016 0.0
lock-app debug (read only) 4455577 4457425 1848 0.0
(read/write) 203096 203064 -32 -0.0
.bss 113392 113392 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5240 -8 -0.2
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 246589 246461 -128 -0.1
.text 3999587 4001651 2064 0.1
ota-provider-app debug (read only) 4117745 4117745 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113536 113536 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68656 68656 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 199773 199773 0 0.0
.text 3727411 3727411 0 0.0
ota-requestor-app debug (read only) 4202937 4202937 0 0.0
(read/write) 196216 196216 0 0.0
.bss 114560 114560 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 71600 71600 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203037 203037 0 0.0
.text 3805059 3805059 0 0.0
shell debug (read only) 2908033 2909857 1824 0.1
(read/write) 153096 153096 0 0.0
.bss 60872 60872 0 0.0
.data 816 816 0 0.0
.data.rel.ro 85512 85512 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4088 -8 -0.2
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 211200 211040 -160 -0.1
.text 2523554 2525634 2080 0.1
thermostat-no-ble arm64 (read only) 4346388 4346388 0 0.0
(read/write) 241864 241864 0 0.0
.bss 122168 122168 0 0.0
.data 2792 2792 0 0.0
.data.rel.ro 100528 100528 0 0.0
.dynamic 512 512 0 0.0
.got 11912 11912 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 160820 160820 0 0.0
.text 3850952 3850952 0 0.0
tv-app debug (read only) 5279505 5281633 2128 0.0
(read/write) 350640 350608 -32 -0.0
.bss 241824 241824 0 0.0
.data 5024 5024 0 0.0
.data.rel.ro 96384 96384 0 0.0
.dynamic 624 624 0 0.0
.got 5592 5584 -8 -0.1
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 270925 270893 -32 -0.0
.text 4764691 4766947 2256 0.0
tv-casting-app debug (read only) 8183193 8185321 2128 0.0
(read/write) 313376 313376 0 0.0
.bss 155872 155872 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 148208 148208 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5064 -8 -0.2
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 337336 337304 -32 -0.0
.text 7443139 7445395 2256 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522104 2522104 0 0.0
.bss 219048 219048 0 0.0
.data 5136 5136 0 0.0
.text 1484788 1484788 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1228404 1228404 0 0.0
bss 154441 154441 0 0.0
rodata 142736 142736 0 0.0
text 852228 852228 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1347904 1347904 0 0.0
bss 140451 140451 0 0.0
rodata 136896 136896 0 0.0
text 779864 779864 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160236 1160236 0 0.0
bss 153938 153938 0 0.0
rodata 113712 113712 0 0.0
text 813636 813636 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837568 837568 0 0.0
(read/write) 1779020 1779020 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193236 193236 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2536 2536 0 0.0
.debug_abbrev 1378455 1378455 0 0.0
.debug_aranges 145376 145376 0 0.0
.debug_frame 481888 481888 0 0.0
.debug_info 32105245 32105245 0 0.0
.debug_line 4035031 4035031 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2315295 2315295 0 0.0
.debug_rnglists 155971 155971 0 0.0
.debug_str 4191722 4191722 0 0.0
.heap 837568 837568 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 844681 844681 0 0.0
.symtab 514048 514048 0 0.0
.text 0 0 0 0.0
1574860 1574860 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840160 840160 0 0.0
(read/write) 1680980 1680980 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190708 190708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1258889 1258889 0 0.0
.debug_aranges 137120 137120 0 0.0
.debug_frame 460108 460108 0 0.0
.debug_info 28446822 28446822 0 0.0
.debug_line 3793061 3793061 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2187421 2187421 0 0.0
.debug_rnglists 147432 147432 0 0.0
.debug_str 3992868 3992868 0 0.0
.heap 840160 840160 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 741294 741294 0 0.0
.symtab 474752 474752 0 0.0
.text 1479412 1479412 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846488 846488 0 0.0
(read/write) 1607412 1607412 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1100264 1100264 0 0.0
.debug_aranges 127184 127184 0 0.0
.debug_frame 423040 423040 0 0.0
.debug_info 23577233 23577233 0 0.0
.debug_line 3368438 3368438 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2024145 2024145 0 0.0
.debug_rnglists 136984 136984 0 0.0
.debug_str 3799926 3799926 0 0.0
.heap 846488 846488 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 654386 654386 0 0.0
.symtab 436208 436208 0 0.0
.text 1412172 1412172 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 819224 819224 0 0.0
(read/write) 1640308 1640308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2376 2376 0 0.0
.debug_abbrev 1093282 1093282 0 0.0
.debug_aranges 125872 125872 0 0.0
.debug_frame 418276 418276 0 0.0
.debug_info 23387240 23387240 0 0.0
.debug_line 3320825 3320825 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2000613 2000613 0 0.0
.debug_rnglists 134989 134989 0 0.0
.debug_str 3762418 3762418 0 0.0
.heap 819224 819224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 628018 628018 0 0.0
.symtab 427824 427824 0 0.0
.text 1417804 1417804 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1175948 1175948 0 0.0
.bss 100600 100600 0 0.0
.data 744 744 0 0.0
.text 622792 622792 0 0.0
lock-app qpg6105+debug (read/write) 1132612 1132612 0 0.0
.bss 95304 95304 0 0.0
.data 748 748 0 0.0
.text 579452 579452 0 0.0
telink air-quality-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 856144 856144 0 0.0
bss 77996 77996 0 0.0
text 603774 603774 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1131472 1131472 0 0.0
bss 113148 113148 0 0.0
text 785798 785798 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1076116 1076116 0 0.0
bss 122236 122236 0 0.0
text 743880 743880 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 931432 931432 0 0.0
bss 106876 106876 0 0.0
text 640958 640958 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 859504 859504 0 0.0
bss 78120 78120 0 0.0
text 606840 606840 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 961712 961712 0 0.0
bss 88184 88184 0 0.0
text 683314 683314 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1087352 1087352 0 0.0
bss 112384 112384 0 0.0
text 761518 761518 0 0.0
lock-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 915788 915788 0 0.0
bss 78812 78812 0 0.0
text 636350 636350 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944780 944780 0 0.0
bss 104976 104976 0 0.0
text 656724 656724 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 863380 863380 0 0.0
bss 78228 78228 0 0.0
text 611046 611046 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 804240 804240 0 0.0
bss 66248 66248 0 0.0
text 578082 578082 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819904 819904 0 0.0
bss 66652 66652 0 0.0
text 588662 588662 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 708928 708928 0 0.0
bss 86424 86424 0 0.0
text 461962 461962 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 861896 861896 0 0.0
bss 78204 78204 0 0.0
text 610164 610164 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 847184 847184 0 0.0
bss 77932 77932 0 0.0
text 597580 597580 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825292 825292 0 0.0
bss 66536 66536 0 0.0
text 593406 593406 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 822748 822748 0 0.0
bss 66888 66888 0 0.0
text 590454 590454 0 0.0

@arkq arkq mentioned this pull request Oct 18, 2023
Merged
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

PR #29798: Size comparison from 2e5c2a7 to a4e33f9

Increases above 0.2%:

platform target config section 2e5c2a7 a4e33f9 change % change
linux chip-tool-ipv6only arm64 .got 18400 18504 104 0.6
Increases (10 builds for linux)
platform target config section 2e5c2a7 a4e33f9 change % change
linux all-clusters-app debug (read only) 5469009 5470801 1792 0.0
.text 4759731 4761747 2016 0.0
all-clusters-minimal-app debug (read only) 4877641 4879441 1800 0.0
.text 4376515 4378531 2016 0.0
bridge-app debug (read only) 4359281 4361057 1776 0.0
.text 3923731 3925731 2000 0.1
chip-tool debug (read only) 10232273 10234145 1872 0.0
.text 9248147 9250243 2096 0.0
chip-tool-ipv6only arm64 (read only) 10104524 10105420 896 0.0
(read/write) 505384 505464 80 0.0
.got 18400 18504 104 0.6
.text 9023128 9024088 960 0.0
lighting-app debug+rpc+ui (read only) 5217393 5219153 1760 0.0
.text 4638051 4640067 2016 0.0
lock-app debug (read only) 4455529 4457377 1848 0.0
.text 3999539 4001603 2064 0.1
shell debug (read only) 2875921 2877761 1840 0.1
.text 2498546 2500610 2064 0.1
tv-app debug (read only) 5279457 5281585 2128 0.0
.text 4764643 4766899 2256 0.0
tv-casting-app debug (read only) 8183161 8185289 2128 0.0
.text 7443107 7445363 2256 0.0
Decreases (10 builds for linux)
platform target config section 2e5c2a7 a4e33f9 change % change
linux all-clusters-app debug (read/write) 417528 417496 -32 -0.0
.got 5368 5360 -8 -0.1
.rodata 330476 330348 -128 -0.0
all-clusters-minimal-app debug .got 5328 5320 -8 -0.2
.rodata 270205 270077 -128 -0.0
bridge-app debug .got 5296 5288 -8 -0.2
.rodata 218109 217981 -128 -0.1
chip-tool debug .got 5792 5784 -8 -0.1
.rodata 386217 386089 -128 -0.0
chip-tool-ipv6only arm64 .data.rel.ro 374208 374184 -24 -0.0
.rodata 314856 314584 -272 -0.1
lighting-app debug+rpc+ui .got 5912 5904 -8 -0.1
.rodata 336308 336148 -160 -0.0
lock-app debug (read/write) 203096 203064 -32 -0.0
.got 5248 5240 -8 -0.2
.rodata 246589 246461 -128 -0.1
shell debug .got 4096 4088 -8 -0.2
.rodata 206112 205984 -128 -0.1
tv-app debug (read/write) 350640 350608 -32 -0.0
.got 5592 5584 -8 -0.1
.rodata 270925 270893 -32 -0.0
tv-casting-app debug .got 5072 5064 -8 -0.2
.rodata 337336 337304 -32 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2e5c2a7 a4e33f9 change % change
bl602 lighting-app bl602 (read/write) 1388654 1388654 0 0.0
.bss 88168 88168 0 0.0
.data 9368 9368 0 0.0
.text 1065242 1065242 0 0.0
bl602+mfd (read/write) 1402990 1402990 0 0.0
.bss 88336 88336 0 0.0
.data 9344 9344 0 0.0
.text 1080474 1080474 0 0.0
bl602+rpc (read/write) 1435666 1435666 0 0.0
.bss 96200 96200 0 0.0
.data 9744 9744 0 0.0
.text 1096718 1096718 0 0.0
bl702 lighting-app bl702 (read/write) 1210159 1210159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 32573 32573 0 0.0
.bss_psram 65728 65728 0 0.0
.comment 48 48 0 0.0
.data 3576 3576 0 0.0
.debug_abbrev 1540091 1540091 0 0.0
.debug_aranges 138736 138736 0 0.0
.debug_frame 508336 508336 0 0.0
.debug_info 41458377 41458377 0 0.0
.debug_line 5437405 5437405 0 0.0
.debug_loc 3651606 3651606 0 0.0
.debug_ranges 444560 444560 0 0.0
.debug_str 4067340 4067340 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106600 106600 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 598151 598151 0 0.0
.symtab 178896 178896 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
972304 972304 0 0.0
bl702+mfd (read/write) 1221187 1221187 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 32749 32749 0 0.0
.bss_psram 65728 65728 0 0.0
.comment 48 48 0 0.0
.data 3560 3560 0 0.0
.debug_abbrev 1542167 1542167 0 0.0
.debug_aranges 139904 139904 0 0.0
.debug_frame 513740 513740 0 0.0
.debug_info 41499383 41499383 0 0.0
.debug_line 5477578 5477578 0 0.0
.debug_loc 3689691 3689691 0 0.0
.debug_ranges 446800 446800 0 0.0
.debug_str 4072871 4072871 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105540 105540 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 601911 601911 0 0.0
.symtab 180656 180656 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
984248 984248 0 0.0
bl702+rpc (read/write) 1310427 1310427 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41037 41037 0 0.0
.bss_psram 65712 65712 0 0.0
.comment 48 48 0 0.0
.data 4128 4128 0 0.0
.debug_abbrev 1721048 1721048 0 0.0
.debug_aranges 147336 147336 0 0.0
.debug_frame 537348 537348 0 0.0
.debug_info 46602425 46602425 0 0.0
.debug_line 5867678 5867678 0 0.0
.debug_loc 3859103 3859103 0 0.0
.debug_ranges 472112 472112 0 0.0
.debug_str 4495180 4495180 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 164 164 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121500 121500 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 662108 662108 0 0.0
.symtab 198016 198016 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
1048110 1048110 0 0.0
bl706-eth (read only) 3318 3318 0 0.0
(read/write) 1037315 1037315 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 30006 30006 0 0.0
.bss_psram 97671 97671 0 0.0
.comment 48 48 0 0.0
.data 3248 3248 0 0.0
.debug_abbrev 1082038 1082038 0 0.0
.debug_aranges 115112 115112 0 0.0
.debug_frame 424972 424972 0 0.0
.debug_info 22576536 22576536 0 0.0
.debug_line 4291928 4291928 0 0.0
.debug_loc 3147619 3147619 0 0.0
.debug_ranges 380680 380680 0 0.0
.debug_str 3639691 3639691 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 96124 96124 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 464952 464952 0 0.0
.symtab 139936 139936 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3318 3318 0 0.0
.text 0 0 0 0.0
784932 784932 0 0.0
bl706-wifi (read only) 3846 3846 0 0.0
(read/write) 1205646 1205646 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 14597 14597 0 0.0
.bss_psram 98439 98439 0 0.0
.comment 48 48 0 0.0
.data 3560 3560 0 0.0
.debug_abbrev 1174427 1174427 0 0.0
.debug_aranges 119288 119288 0 0.0
.debug_frame 617056 617056 0 0.0
.debug_info 23741972 23741972 0 0.0
.debug_line 4535967 4535967 0 0.0
.debug_loc 3247588 3247588 0 0.0
.debug_ranges 390736 390736 0 0.0
.debug_str 3711982 3711982 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109252 109252 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 505679 505679 0 0.0
.symtab 152800 152800 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3846 3846 0 0.0
.text 0 0 0 0.0
953328 953328 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1171792 1171792 0 0.0
.boot2 328 328 0 0.0
.bss 20464 20464 0 0.0
.bss_psram 78848 78848 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1538608 1538608 0 0.0
.debug_aranges 133784 133784 0 0.0
.debug_frame 489528 489528 0 0.0
.debug_info 41252821 41252821 0 0.0
.debug_line 5351449 5351449 0 0.0
.debug_loc 3597983 3597983 0 0.0
.debug_ranges 451552 451552 0 0.0
.debug_str 4094091 4094091 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100580 100580 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 600464 600464 0 0.0
.symtab 178512 178512 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
956790 956790 0 0.0
bl702l+mfd (read only) 278 278 0 0.0
(read/write) 1182912 1182912 0 0.0
.boot2 328 328 0 0.0
.bss 20640 20640 0 0.0
.bss_psram 78848 78848 0 0.0
.comment 48 48 0 0.0
.data 4496 4496 0 0.0
.debug_abbrev 1540699 1540699 0 0.0
.debug_aranges 134952 134952 0 0.0
.debug_frame 494928 494928 0 0.0
.debug_info 41295870 41295870 0 0.0
.debug_line 5391499 5391499 0 0.0
.debug_loc 3636068 3636068 0 0.0
.debug_ranges 453792 453792 0 0.0
.debug_str 4099612 4099612 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99520 99520 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 604292 604292 0 0.0
.symtab 180304 180304 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
968826 968826 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 734851 734851 0 0.0
(read/write) 166436 166436 0 0.0
.bss 88852 88852 0 0.0
.data 3420 3420 0 0.0
.rodata 84287 84287 0 0.0
.text 650176 650176 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 756443 756443 0 0.0
(read/write) 176720 176720 0 0.0
.bss 99100 99100 0 0.0
.data 3440 3440 0 0.0
.rodata 79863 79863 0 0.0
.text 676188 676188 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 743907 743907 0 0.0
(read/write) 171176 171176 0 0.0
.bss 93556 93556 0 0.0
.data 3440 3440 0 0.0
.rodata 105951 105951 0 0.0
.text 637564 637564 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 694651 694651 0 0.0
(read/write) 165528 165528 0 0.0
.bss 87720 87720 0 0.0
.data 3408 3408 0 0.0
.rodata 80111 80111 0 0.0
.text 614152 614152 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 680331 680331 0 0.0
(read/write) 165668 165668 0 0.0
.bss 87864 87864 0 0.0
.data 3404 3404 0 0.0
.rodata 75943 75943 0 0.0
.text 604000 604000 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 617522 617522 0 0.0
(read/write) 206896 206896 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200336 200336 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 936286 936286 0 0.0
.debug_aranges 108672 108672 0 0.0
.debug_frame 366108 366108 0 0.0
.debug_info 20540920 20540920 0 0.0
.debug_line 2654062 2654062 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1632230 1632230 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 112029 112029 0 0.0
.debug_str 3437839 3437839 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106162 106162 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 515741 515741 0 0.0
.symtab 298512 298512 0 0.0
.text 509236 509236 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 551975 551975 0 0.0
.app_xip_area 443193 443193 0 0.0
.bss 63752 63752 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538159 538159 0 0.0
.app_xip_area 424577 424577 0 0.0
.bss 68520 68520 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573583 573583 0 0.0
.app_xip_area 466121 466121 0 0.0
.bss 62504 62504 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 549903 549903 0 0.0
.app_xip_area 439361 439361 0 0.0
.bss 65488 65488 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1006560 1006560 0 0.0
.bss 171952 171952 0 0.0
.data 2692 2692 0 0.0
.text 831896 831896 0 0.0
BRD4187C (read/write) 1093072 1093072 0 0.0
.bss 196116 196116 0 0.0
.data 3300 3300 0 0.0
.text 893636 893636 0 0.0
lock-app BRD4161A+wf200 (read/write) 1103656 1103656 0 0.0
.bss 186664 186664 0 0.0
.data 2708 2708 0 0.0
.text 914260 914260 0 0.0
window-app BRD4187C (read/write) 1129396 1129396 0 0.0
.bss 168532 168532 0 0.0
.data 3172 3172 0 0.0
.text 957672 957672 0 0.0
esp32 all-clusters-app c3devkit (read only) 1159774 1159774 0 0.0
(read/write) 1700500 1700500 0 0.0
.dram0.bss 77176 77176 0 0.0
.dram0.data 13020 13020 0 0.0
.flash.rodata 266432 266432 0 0.0
.flash.text 1159774 1159774 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1202931 1202931 0 0.0
(read/write) 549956 549956 0 0.0
.dram0.bss 83824 83824 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 297732 297732 0 0.0
.flash.text 1197547 1197547 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 588660 588660 0 0.0
(read/write) 87492 87492 0 0.0
.bss 70736 70736 0 0.0
.data 2132 2132 0 0.0
.text 588124 588124 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 683852 683852 0 0.0
.bss 66952 66952 0 0.0
.data 2716 2716 0 0.0
.text 570704 570704 0 0.0
light k32w0+release (read only) 588380 588380 0 0.0
(read/write) 87176 87176 0 0.0
.bss 70432 70432 0 0.0
.data 2120 2120 0 0.0
.text 587844 587844 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 775672 775672 0 0.0
.bss 76620 76620 0 0.0
.data 1928 1928 0 0.0
.text 653664 653664 0 0.0
lock k32w0+release (read only) 560196 560196 0 0.0
(read/write) 85004 85004 0 0.0
.bss 68320 68320 0 0.0
.data 2060 2060 0 0.0
.text 559660 559660 0 0.0
linux all-clusters-app debug (read only) 5469009 5470801 1792 0.0
(read/write) 417528 417496 -32 -0.0
.bss 129264 129264 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 277120 277120 0 0.0
.dynamic 624 624 0 0.0
.got 5368 5360 -8 -0.1
.init 27 27 0 0.0
.init_array 1248 1248 0 0.0
.rodata 330476 330348 -128 -0.0
.text 4759731 4761747 2016 0.0
all-clusters-minimal-app debug (read only) 4877641 4879441 1800 0.0
(read/write) 232664 232664 0 0.0
.bss 126480 126480 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 95280 95280 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5320 -8 -0.2
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 270205 270077 -128 -0.0
.text 4376515 4378531 2016 0.0
bridge-app debug (read only) 4359281 4361057 1776 0.0
(read/write) 214968 214968 0 0.0
.bss 118872 118872 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84624 84624 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5288 -8 -0.2
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218109 217981 -128 -0.1
.text 3923731 3925731 2000 0.1
chip-tool debug (read only) 10232273 10234145 1872 0.0
(read/write) 443552 443552 0 0.0
.bss 93688 93688 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 337648 337648 0 0.0
.dynamic 624 624 0 0.0
.got 5792 5784 -8 -0.1
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 386217 386089 -128 -0.0
.text 9248147 9250243 2096 0.0
chip-tool-ipv6only arm64 (read only) 10104524 10105420 896 0.0
(read/write) 505384 505464 80 0.0
.bss 103048 103048 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 374208 374184 -24 -0.0
.dynamic 512 512 0 0.0
.got 18400 18504 104 0.6
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 314856 314584 -272 -0.1
.text 9023128 9024088 960 0.0
lighting-app debug+rpc+ui (read only) 5217393 5219153 1760 0.0
(read/write) 222960 222960 0 0.0
.bss 118160 118160 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 92832 92832 0 0.0
.dynamic 672 672 0 0.0
.got 5912 5904 -8 -0.1
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 336308 336148 -160 -0.0
.text 4638051 4640067 2016 0.0
lock-app debug (read only) 4455529 4457377 1848 0.0
(read/write) 203096 203064 -32 -0.0
.bss 113392 113392 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5240 -8 -0.2
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 246589 246461 -128 -0.1
.text 3999539 4001603 2064 0.1
ota-provider-app debug (read only) 4117777 4117777 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113536 113536 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68656 68656 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 199773 199773 0 0.0
.text 3727443 3727443 0 0.0
ota-requestor-app debug (read only) 4202969 4202969 0 0.0
(read/write) 196216 196216 0 0.0
.bss 114560 114560 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 71600 71600 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203037 203037 0 0.0
.text 3805091 3805091 0 0.0
shell debug (read only) 2875921 2877761 1840 0.1
(read/write) 150032 150032 0 0.0
.bss 59784 59784 0 0.0
.data 816 816 0 0.0
.data.rel.ro 83624 83624 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4088 -8 -0.2
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 206112 205984 -128 -0.1
.text 2498546 2500610 2064 0.1
thermostat-no-ble arm64 (read only) 4346452 4346452 0 0.0
(read/write) 241864 241864 0 0.0
.bss 122168 122168 0 0.0
.data 2792 2792 0 0.0
.data.rel.ro 100528 100528 0 0.0
.dynamic 512 512 0 0.0
.got 11912 11912 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 160820 160820 0 0.0
.text 3851016 3851016 0 0.0
tv-app debug (read only) 5279457 5281585 2128 0.0
(read/write) 350640 350608 -32 -0.0
.bss 241824 241824 0 0.0
.data 5024 5024 0 0.0
.data.rel.ro 96384 96384 0 0.0
.dynamic 624 624 0 0.0
.got 5592 5584 -8 -0.1
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 270925 270893 -32 -0.0
.text 4764643 4766899 2256 0.0
tv-casting-app debug (read only) 8183161 8185289 2128 0.0
(read/write) 313376 313376 0 0.0
.bss 155872 155872 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 148208 148208 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5064 -8 -0.2
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 337336 337304 -32 -0.0
.text 7443107 7445363 2256 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522104 2522104 0 0.0
.bss 219048 219048 0 0.0
.data 5136 5136 0 0.0
.text 1484788 1484788 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1220928 1220928 0 0.0
bss 154069 154069 0 0.0
rodata 140204 140204 0 0.0
text 847700 847700 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1342680 1342680 0 0.0
bss 140079 140079 0 0.0
rodata 135648 135648 0 0.0
text 776304 776304 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160444 1160444 0 0.0
bss 153994 153994 0 0.0
rodata 113712 113712 0 0.0
text 813720 813720 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 838048 838048 0 0.0
(read/write) 1769516 1769516 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 192796 192796 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2496 2496 0 0.0
.debug_abbrev 1326686 1326686 0 0.0
.debug_aranges 143000 143000 0 0.0
.debug_frame 474408 474408 0 0.0
.debug_info 30613445 30613445 0 0.0
.debug_line 3942950 3942950 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2287248 2287248 0 0.0
.debug_rnglists 153904 153904 0 0.0
.debug_str 4160418 4160418 0 0.0
.heap 838048 838048 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 829691 829691 0 0.0
.symtab 506320 506320 0 0.0
.text 0 0 0 0.0
1565836 1565836 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840160 840160 0 0.0
(read/write) 1680980 1680980 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190708 190708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1258889 1258889 0 0.0
.debug_aranges 137120 137120 0 0.0
.debug_frame 460108 460108 0 0.0
.debug_info 28446838 28446838 0 0.0
.debug_line 3793071 3793071 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2187403 2187403 0 0.0
.debug_rnglists 147432 147432 0 0.0
.debug_str 3992963 3992963 0 0.0
.heap 840160 840160 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 741294 741294 0 0.0
.symtab 474752 474752 0 0.0
.text 1479412 1479412 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846488 846488 0 0.0
(read/write) 1607412 1607412 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1100264 1100264 0 0.0
.debug_aranges 127184 127184 0 0.0
.debug_frame 423040 423040 0 0.0
.debug_info 23577249 23577249 0 0.0
.debug_line 3368448 3368448 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2024127 2024127 0 0.0
.debug_rnglists 136984 136984 0 0.0
.debug_str 3800021 3800021 0 0.0
.heap 846488 846488 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 654386 654386 0 0.0
.symtab 436208 436208 0 0.0
.text 1412172 1412172 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 819224 819224 0 0.0
(read/write) 1640308 1640308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2376 2376 0 0.0
.debug_abbrev 1093282 1093282 0 0.0
.debug_aranges 125872 125872 0 0.0
.debug_frame 418276 418276 0 0.0
.debug_info 23387240 23387240 0 0.0
.debug_line 3320828 3320828 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2000602 2000602 0 0.0
.debug_rnglists 134989 134989 0 0.0
.debug_str 3762418 3762418 0 0.0
.heap 819224 819224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 628018 628018 0 0.0
.symtab 427824 427824 0 0.0
.text 1417804 1417804 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1175996 1175996 0 0.0
.bss 100608 100608 0 0.0
.data 744 744 0 0.0
.text 622840 622840 0 0.0
lock-app qpg6105+debug (read/write) 1132620 1132620 0 0.0
.bss 95288 95288 0 0.0
.data 748 748 0 0.0
.text 579460 579460 0 0.0
telink air-quality-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 856136 856136 0 0.0
bss 77996 77996 0 0.0
text 603762 603762 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1122940 1122940 0 0.0
bss 112724 112724 0 0.0
text 780402 780402 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1076136 1076136 0 0.0
bss 122236 122236 0 0.0
text 743904 743904 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 931432 931432 0 0.0
bss 106876 106876 0 0.0
text 640958 640958 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 859488 859488 0 0.0
bss 78120 78120 0 0.0
text 606828 606828 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 961672 961672 0 0.0
bss 88184 88184 0 0.0
text 683308 683308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1087388 1087388 0 0.0
bss 112384 112384 0 0.0
text 761600 761600 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 918012 918012 0 0.0
bss 78812 78812 0 0.0
text 637760 637760 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944760 944760 0 0.0
bss 104976 104976 0 0.0
text 656730 656730 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 863364 863364 0 0.0
bss 78228 78228 0 0.0
text 611034 611034 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 804232 804232 0 0.0
bss 66248 66248 0 0.0
text 578070 578070 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819888 819888 0 0.0
bss 66652 66652 0 0.0
text 588650 588650 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 708928 708928 0 0.0
bss 86424 86424 0 0.0
text 461962 461962 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 861880 861880 0 0.0
bss 78204 78204 0 0.0
text 610152 610152 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 847176 847176 0 0.0
bss 77932 77932 0 0.0
text 597568 597568 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825276 825276 0 0.0
bss 66536 66536 0 0.0
text 593394 593394 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 822740 822740 0 0.0
bss 66888 66888 0 0.0
text 590442 590442 0 0.0

@mergify mergify bot merged commit 9f37258 into project-chip:master Oct 19, 2023
56 checks passed
@arkq arkq deleted the bluez-connection branch October 19, 2023 20:41
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@arkq @HunsupJung
[Linux] Wrap BlueZ connection functions in a class (project-chip#29798)
6e76c31 
* Do not use BLE_CONNECTION_OBJECT by internal implementation

* Wrap BluezConnection in a class

* Store const ref to connection in ConnectionDataBundle

* Simplify get connection MTU method

* Add proxy method for getting device address

* Allocate ConnectionDataBundle on stack

* Add destructor to IOChannel

* Remove Bluez from public method names

* Move IO channels creation to BluezConnection

* Fix notify callback setup for additional advertising

* Fix FD leak in case of g_variant_lookup failure

* Move IO channel handlers to BluezConnection class

* Manage IOChannel members with GAutoPtr

* Use on-stack array for reading characteristic

* Document FD closing behavior by setup methods

* Fix GSource deleter
shripad621git pushed a commit to shripad621git/connectedhomeip that referenced this pull request Oct 31, 2023
@arkq @shripad621git
[Linux] Wrap BlueZ connection functions in a class (project-chip#29798)
40790d1 
* Do not use BLE_CONNECTION_OBJECT by internal implementation

* Wrap BluezConnection in a class

* Store const ref to connection in ConnectionDataBundle

* Simplify get connection MTU method

* Add proxy method for getting device address

* Allocate ConnectionDataBundle on stack

* Add destructor to IOChannel

* Remove Bluez from public method names

* Move IO channels creation to BluezConnection

* Fix notify callback setup for additional advertising

* Fix FD leak in case of g_variant_lookup failure

* Move IO channel handlers to BluezConnection class

* Manage IOChannel members with GAutoPtr

* Use on-stack array for reading characteristic

* Document FD closing behavior by setup methods

* Fix GSource deleter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track linux platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkq @woody-apple