Adding laundry-dryer-controls cluster XML #30098
Conversation
|
Erik Hove seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Created XML and generated code.
eahove
force-pushed
the
LaundryDryerControlsClusterXML
branch
from
1ded04d
to
54aac74
Compare
| @@ -40,15 +41,18 @@ jobs: | |||
| env: | |||
| BUILD_VARIANT: ${{matrix.build_variant}} | |||
| CHIP_TOOL_VARIANT: ${{matrix.chip_tool}} | |||
| TSAN_OPTIONS: "halt_on_error=1 suppressions=scripts/tests/chiptest/tsan-linux-suppressions.txt" | |||
| TSAN_OPTIONS: | |||
There was a problem hiding this comment.
Whatever auto-formatter is being used here disagrees with previous auto-formatters. Please undo all the unrelated changes.
| <configurator> | ||
| <domain name="CHIP" /> | ||
|
|
||
| <enum name="DrynessLevelEnum" type="enum8"> |
There was a problem hiding this comment.
This is not what the spec has, as far as I can tell. What exact spec version is this targeting, if it's not master or 0.7 ballot? That needs to be clearly stated in the PR for this to be reviewable.
There was a problem hiding this comment.
This is based on an updated version of the spec that is still in PR:
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7766
Created XML for the laundry-dryer-controls cluster and related generated code. For 0.7 ballot.
This is based on the updated spec from PR:
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7766