Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a IsValidUtf8 equivalent with unit tests #30386

Merged
merged 17 commits into from
Nov 9, 2023
Merged

Define a IsValidUtf8 equivalent with unit tests #30386

merged 17 commits into from
Nov 9, 2023

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Nov 9, 2023 •
edited
Loading

provide a chip::Utf8::IsValid implementation

It seems we want to start have some encoding validations, at least outgoing (and maybe inside the cert) so that bugs like #30342 are not possible.

Having UTF8 validation seems very beneficial.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited
Loading

PR #30386: Size comparison from f50e12b to 967c32b

Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section f50e12b 967c32b change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 563986 563986 0 0.0
(read/write) 206496 206496 0 0.0
.bss 199956 199956 0 0.0
.data 1416 1416 0 0.0
.rodata 83690 83690 0 0.0
.text 478172 478172 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620250 620250 0 0.0
(read/write) 206900 206900 0 0.0
.bss 200336 200336 0 0.0
.data 1444 1444 0 0.0
.rodata 106306 106306 0 0.0
.text 511824 511824 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525552 2525552 0 0.0
.bss 219064 219064 0 0.0
.data 5136 5136 0 0.0
.text 1488236 1488236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1054364 1054364 0 0.0
bss 128343 128343 0 0.0
rodata 104028 104028 0 0.0
text 774400 774400 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1181196 1181196 0 0.0
bss 120545 120545 0 0.0
rodata 138220 138220 0 0.0
text 772092 772092 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1039692 1039692 0 0.0
bss 128636 128636 0 0.0
rodata 99300 99300 0 0.0
text 764168 764168 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178464 1178464 0 0.0
.bss 100664 100664 0 0.0
.data 748 748 0 0.0
.text 625304 625304 0 0.0
lock-app qpg6105+debug (read/write) 1139220 1139220 0 0.0
.bss 95408 95408 0 0.0
.data 780 780 0 0.0
.text 586060 586060 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

PR #30386: Size comparison from f50e12b to 6e2f7d3

Full report (2 builds for cc32xx)
platform target config section f50e12b 6e2f7d3 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 563986 563986 0 0.0
(read/write) 206496 206496 0 0.0
.bss 199956 199956 0 0.0
.data 1416 1416 0 0.0
.rodata 83690 83690 0 0.0
.text 478172 478172 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620250 620250 0 0.0
(read/write) 206900 206900 0 0.0
.bss 200336 200336 0 0.0
.data 1444 1444 0 0.0
.rodata 106306 106306 0 0.0
.text 511824 511824 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited
Loading

PR #30386: Size comparison from f50e12b to 69135af

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section f50e12b 69135af change % change
bl602 lighting-app bl602 (read/write) 1407550 1407550 0 0.0
.bss 84504 84504 0 0.0
.data 9376 9376 0 0.0
.rodata 156376 156376 0 0.0
.text 1076640 1076640 0 0.0
bl602+mfd (read/write) 1421990 1421990 0 0.0
.bss 84672 84672 0 0.0
.data 9344 9344 0 0.0
.rodata 155336 155336 0 0.0
.text 1091992 1091992 0 0.0
bl602+rpc (read/write) 1454570 1454570 0 0.0
.bss 92536 92536 0 0.0
.data 9744 9744 0 0.0
.rodata 163492 163492 0 0.0
.text 1108128 1108128 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1173715 1173715 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106116 106116 0 0.0
.text 947134 947134 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1184839 1184839 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105056 105056 0 0.0
.text 959198 959198 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1273271 1273271 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121016 121016 0 0.0
.text 1022200 1022200 0 0.0
bl706-eth (read/write) 992649 992649 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99204 99204 0 0.0
.text 739606 739606 0 0.0
bl706-wifi (read/write) 1227806 1227806 0 0.0
.bss 10657 10657 0 0.0
.data 3568 3568 0 0.0
.rodata 120064 120064 0 0.0
.text 964026 964026 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1143428 1143428 0 0.0
.bss 16408 16408 0 0.0
.data 4920 4920 0 0.0
.rodata 100120 100120 0 0.0
.text 940228 940228 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1154888 1154888 0 0.0
.bss 16584 16584 0 0.0
.data 4904 4904 0 0.0
.rodata 99060 99060 0 0.0
.text 952604 952604 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 737451 737451 0 0.0
(read/write) 166528 166528 0 0.0
.bss 88940 88940 0 0.0
.data 3424 3424 0 0.0
.rodata 84599 84599 0 0.0
.text 652464 652464 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759171 759171 0 0.0
(read/write) 176820 176820 0 0.0
.bss 99188 99188 0 0.0
.data 3444 3444 0 0.0
.rodata 80175 80175 0 0.0
.text 678604 678604 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746443 746443 0 0.0
(read/write) 171276 171276 0 0.0
.bss 93644 93644 0 0.0
.data 3444 3444 0 0.0
.rodata 106231 106231 0 0.0
.text 639820 639820 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 697211 697211 0 0.0
(read/write) 165628 165628 0 0.0
.bss 87808 87808 0 0.0
.data 3412 3412 0 0.0
.rodata 80359 80359 0 0.0
.text 616464 616464 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 682899 682899 0 0.0
(read/write) 165760 165760 0 0.0
.bss 87952 87952 0 0.0
.data 3408 3408 0 0.0
.rodata 76199 76199 0 0.0
.text 606312 606312 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 563986 563986 0 0.0
(read/write) 206496 206496 0 0.0
.bss 199956 199956 0 0.0
.data 1416 1416 0 0.0
.rodata 83690 83690 0 0.0
.text 478172 478172 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620250 620250 0 0.0
(read/write) 206900 206900 0 0.0
.bss 200336 200336 0 0.0
.data 1444 1444 0 0.0
.rodata 106306 106306 0 0.0
.text 511824 511824 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 554735 554735 0 0.0
.app_xip_area 445809 445809 0 0.0
.bss 63840 63840 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540903 540903 0 0.0
.app_xip_area 427177 427177 0 0.0
.bss 68608 68608 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576591 576591 0 0.0
.app_xip_area 468993 468993 0 0.0
.bss 62584 62584 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 552623 552623 0 0.0
.app_xip_area 441937 441937 0 0.0
.bss 65568 65568 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1008692 1008692 0 0.0
.bss 171920 171920 0 0.0
.data 2696 2696 0 0.0
.text 834056 834056 0 0.0
BRD4187C (read/write) 1094460 1094460 0 0.0
.bss 195564 195564 0 0.0
.data 3304 3304 0 0.0
.text 895572 895572 0 0.0
lock-app BRD4161A+wf200 (read/write) 1105368 1105368 0 0.0
.bss 186640 186640 0 0.0
.data 2712 2712 0 0.0
.text 915996 915996 0 0.0
window-app BRD4187C (read/write) 1131104 1131104 0 0.0
.bss 167972 167972 0 0.0
.data 3176 3176 0 0.0
.text 959936 959936 0 0.0
esp32 all-clusters-app c3devkit (read only) 1129862 1129862 0 0.0
(read/write) 1670084 1670084 0 0.0
.dram0.bss 71848 71848 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241360 241360 0 0.0
.flash.text 1129862 1129862 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1175071 1175071 0 0.0
(read/write) 520080 520080 0 0.0
.dram0.bss 78496 78496 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273200 273200 0 0.0
.flash.text 1169687 1169687 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 591436 591436 0 0.0
(read/write) 87600 87600 0 0.0
.bss 70840 70840 0 0.0
.data 2136 2136 0 0.0
.text 590900 590900 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 686512 686512 0 0.0
.bss 67040 67040 0 0.0
.data 2720 2720 0 0.0
.text 573272 573272 0 0.0
light k32w0+release (read only) 591140 591140 0 0.0
(read/write) 87276 87276 0 0.0
.bss 70528 70528 0 0.0
.data 2124 2124 0 0.0
.text 590604 590604 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 778516 778516 0 0.0
.bss 76716 76716 0 0.0
.data 1932 1932 0 0.0
.text 656408 656408 0 0.0
lock k32w0+release (read only) 562948 562948 0 0.0
(read/write) 85104 85104 0 0.0
.bss 68416 68416 0 0.0
.data 2064 2064 0 0.0
.text 562412 562412 0 0.0
linux air-purifier-app debug (read only) 2477461 2477461 0 0.0
(read/write) 126280 126280 0 0.0
.bss 46656 46656 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72168 72168 0 0.0
.dynamic 608 608 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 177128 177128 0 0.0
.text 2126533 2126533 0 0.0
all-clusters-app debug (read only) 5279265 5279265 0 0.0
(read/write) 418800 418800 0 0.0
.bss 128880 128880 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 278832 278832 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1208 1208 0 0.0
.rodata 299484 299484 0 0.0
.text 4600115 4600115 0 0.0
all-clusters-minimal-app debug (read only) 4892153 4892153 0 0.0
(read/write) 233080 233080 0 0.0
.bss 126704 126704 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95440 95440 0 0.0
.dynamic 624 624 0 0.0
.got 5320 5320 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 270061 270061 0 0.0
.text 4390995 4390995 0 0.0
bridge-app debug (read only) 4374281 4374281 0 0.0
(read/write) 215128 215128 0 0.0
.bss 118904 118904 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84768 84768 0 0.0
.dynamic 624 624 0 0.0
.got 5288 5288 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218101 218101 0 0.0
.text 3938547 3938547 0 0.0
chip-tool debug (read only) 10360913 10360913 0 0.0
(read/write) 448896 448896 0 0.0
.bss 93752 93752 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 342920 342920 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 391529 391529 0 0.0
.text 9363699 9363699 0 0.0
chip-tool-ipv6only arm64 (read only) 10238360 10238360 0 0.0
(read/write) 515072 515072 0 0.0
.bss 103112 103112 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 380480 380480 0 0.0
.dynamic 512 512 0 0.0
.got 18624 18624 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 317744 317744 0 0.0
.text 9141688 9141688 0 0.0
lighting-app debug+rpc+ui (read only) 5235073 5235073 0 0.0
(read/write) 223136 223136 0 0.0
.bss 118208 118208 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 92976 92976 0 0.0
.dynamic 672 672 0 0.0
.got 5904 5904 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 336820 336820 0 0.0
.text 4655027 4655027 0 0.0
lock-app debug (read only) 4473977 4473977 0 0.0
(read/write) 203304 203304 0 0.0
.bss 113472 113472 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79432 79432 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247381 247381 0 0.0
.text 4016995 4016995 0 0.0
ota-provider-app debug (read only) 4132361 4132361 0 0.0
(read/write) 192192 192192 0 0.0
.bss 113568 113568 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68784 68784 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200085 200085 0 0.0
.text 3741427 3741427 0 0.0
ota-requestor-app debug (read only) 4218665 4218665 0 0.0
(read/write) 196440 196440 0 0.0
.bss 114592 114592 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 71744 71744 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203861 203861 0 0.0
.text 3819651 3819651 0 0.0
shell debug (read only) 2741177 2741177 0 0.0
(read/write) 148504 148504 0 0.0
.bss 59528 59528 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82400 82400 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 179264 179264 0 0.0
.text 2392114 2392114 0 0.0
thermostat-no-ble arm64 (read only) 4370504 4370504 0 0.0
(read/write) 247144 247144 0 0.0
.bss 122184 122184 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 101776 101776 0 0.0
.dynamic 512 512 0 0.0
.got 11928 11928 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161428 161428 0 0.0
.text 3870072 3870072 0 0.0
tv-app debug (read only) 5243353 5243353 0 0.0
(read/write) 344624 344624 0 0.0
.bss 242080 242080 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90240 90240 0 0.0
.dynamic 624 624 0 0.0
.got 5528 5528 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 266909 266909 0 0.0
.text 4741811 4741811 0 0.0
tv-casting-app debug (read only) 8299185 8299185 0 0.0
(read/write) 315640 315640 0 0.0
.bss 155936 155936 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 150384 150384 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 339496 339496 0 0.0
.text 7551571 7551571 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525552 2525552 0 0.0
.bss 219064 219064 0 0.0
.data 5136 5136 0 0.0
.text 1488236 1488236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1054364 1054364 0 0.0
bss 128343 128343 0 0.0
rodata 104028 104028 0 0.0
text 774400 774400 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1181196 1181196 0 0.0
bss 120545 120545 0 0.0
rodata 138220 138220 0 0.0
text 772092 772092 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1039692 1039692 0 0.0
bss 128636 128636 0 0.0
rodata 99300 99300 0 0.0
text 764168 764168 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837624 837624 0 0.0
(read/write) 1732588 1732588 0 0.0
.bss 193236 193236 0 0.0
.data 2480 2480 0 0.0
.text 1528484 1528484 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839344 839344 0 0.0
(read/write) 1696428 1696428 0 0.0
.bss 191516 191516 0 0.0
.data 2480 2480 0 0.0
.text 1494044 1494044 0 0.0
light cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1622612 1622612 0 0.0
.bss 185076 185076 0 0.0
.data 2368 2368 0 0.0
.text 1426780 1426780 0 0.0
lock cy8ckit_062s2_43012 (read only) 818632 818632 0 0.0
(read/write) 1655460 1655460 0 0.0
.bss 212324 212324 0 0.0
.data 2384 2384 0 0.0
.text 1432364 1432364 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178464 1178464 0 0.0
.bss 100664 100664 0 0.0
.data 748 748 0 0.0
.text 625304 625304 0 0.0
lock-app qpg6105+debug (read/write) 1139220 1139220 0 0.0
.bss 95408 95408 0 0.0
.data 780 780 0 0.0
.text 586060 586060 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 811322 811322 0 0.0
bss 53132 53132 0 0.0
text 606044 606044 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1071412 1071412 0 0.0
bss 99388 99388 0 0.0
text 755036 755036 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1076320 1076320 0 0.0
bss 109084 109084 0 0.0
text 746708 746708 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 930220 930220 0 0.0
bss 93684 93684 0 0.0
text 643244 643244 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 814566 814566 0 0.0
bss 53240 53240 0 0.0
text 609094 609094 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 968828 968828 0 0.0
bss 77040 77040 0 0.0
text 687042 687042 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1086128 1086128 0 0.0
bss 99192 99192 0 0.0
text 763800 763800 0 0.0
lock-app-dfu tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 871950 871950 0 0.0
bss 53940 53940 0 0.0
text 638942 638942 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943508 943508 0 0.0
bss 91792 91792 0 0.0
text 658978 658978 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 871212 871212 0 0.0
bss 67076 67076 0 0.0
text 615618 615618 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 811776 811776 0 0.0
bss 55320 55320 0 0.0
text 582596 582596 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 827476 827476 0 0.0
bss 55724 55724 0 0.0
text 593210 593210 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705712 705712 0 0.0
bss 73232 73232 0 0.0
text 462250 462250 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 816294 816294 0 0.0
bss 53332 53332 0 0.0
text 611824 611824 0 0.0
temperature-measurement-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 802234 802234 0 0.0
bss 53052 53052 0 0.0
text 599840 599840 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 832868 832868 0 0.0
bss 55608 55608 0 0.0
text 597952 597952 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 830336 830336 0 0.0
bss 55960 55960 0 0.0
text 595002 595002 0 0.0

@cecille
Copy link
Contributor

cecille commented Nov 9, 2023

Spec reference from Boris, btw. A.11.2. UTF-8 and Octet Strings. https://github.com/CHIP-Specifications/chip-test-plans/issues/3680

@andy31415
Copy link
Contributor Author

Spec reference from Boris, btw. A.11.2. UTF-8 and Octet Strings. CHIP-Specifications/chip-test-plans#3680

I may cover that out of the box once I add this to our TLV bits. I was planning to:

  • add a config to check this on TLVWrite (and enable by default)
  • add a config to check this on TLVRead (and disable by default because we now have to be lenient in controllers, but enable by default on chip-tool to make cert tests fail if a device does this)

@mergify mergify bot merged commit b0f5983 into project-chip:master Nov 9, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
lib review - approved support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @cecille @tcarmelveilleux @saurabhst