-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Add data version filter support in IM #30427
[Android] Add data version filter support in IM #30427
Conversation
e1aba4b
to
d57cf4a
Compare
PR #30427: Size comparison from f06d952 to d57cf4a Increases (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for bl702l, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
d57cf4a
to
a09217a
Compare
PR #30427: Size comparison from be5a949 to a09217a Increases (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for bl702l, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
a09217a
to
13a79be
Compare
a56ac8f
to
1c77fc4
Compare
PR #30427: Size comparison from be5a949 to 1c77fc4 Increases (23 builds for cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (2 builds for linux)
Full report (30 builds for cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
1c77fc4
to
01c9d8a
Compare
PR #30427: Size comparison from be5a949 to 01c9d8a Increases (14 builds for cc13x4_26x4, cc32xx, k32w, nrfconnect, qpg)
Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
01c9d8a
to
a214863
Compare
PR #30427: Size comparison from be5a949 to a214863 Increases (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for bl702l, linux)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
a214863
to
13fe92c
Compare
PR #30427: Size comparison from be5a949 to 13fe92c Increases (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for bl702l, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -693,7 +693,7 @@ CHIP_ERROR ReadClient::ProcessAttributeReportIBs(TLV::TLVReader & aAttributeRepo | |||
ReturnErrorOnFailure(data.GetDataVersion(&version)); | |||
attributePath.mDataVersion.SetValue(version); | |||
|
|||
if (mReadPrepareParams.mpDataVersionFilterList != nullptr) | |||
if (mReadPrepareParams.mpDataVersionFilterList != nullptr && mReadPrepareParams.mDataVersionFilterListSize != 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunhanw-google Why was this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, it is not needed, but i think it is better to have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
Add data version filter support in Android controller's read/subscribe API.
fixes: #25903