Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icd] integrate ICD management command into CHIP tool #30863

Merged
merged 35 commits into from
Dec 12, 2023
Merged

[icd] integrate ICD management command into CHIP tool #30863

merged 35 commits into from
Dec 12, 2023

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Dec 7, 2023 •
edited by yunhanw-google
Loading

This PR adds the code to persist ICD information after successfully commissioned an ICD device.

This PR also adds a new command set icd to chip-tool, and provides list command currently.

Example output of chip-tool icd list:

  +-----------------------------------------------------------------------------+
  | Known ICDs:                                                                 |
  +-----------------------------------------------------------------------------+
  | Fabric Index:Node ID |   Start Counter |  Counter Offset | MonitoredSubject |
  +-----------------------------------------------------------------------------+
  |   1:00000000000030AE |               0 |               0 | 000000000001B669 |
  | Symmetric Key:                             b47914a840034891086307703f0c2bcf |
  +-----------------------------------------------------------------------------+
  |   1:000000000000486E |               0 |               0 | 000000000001B669 |
  | Symmetric Key:                             758336c24898dec72da580cf7040b3d0 |
  +-----------------------------------------------------------------------------+
  |   2:00000000000180EE |               0 |               0 | 000000000001B669 |
  | Symmetric Key:                             22a56cb594166422534ae0e4d46629c9 |
  +-----------------------------------------------------------------------------+

Note: Symmetric Key will only be printed when DefaultSessionKeystore is RawKeySessionKeystore

#29393

@erjiaqing erjiaqing force-pushed the feature/icd/chip-tool-icd-list branch from 256a47d to 4793823 Compare December 7, 2023 04:06
yunhanw-google and others added 14 commits December 11, 2023 17:23
@yunhanw-google
update description
f08e04f
@yunhanw-google @bzbarsky-apple
Update src/app/icd/client/DefaultICDClientStorage.h
f308a6c 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@yunhanw-google @bzbarsky-apple
Update src/app/icd/client/DefaultICDClientStorage.h
0705a8b 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@yunhanw-google @bzbarsky-apple
Update examples/chip-tool/commands/common/CHIPCommand.cpp
44ab95b 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@yunhanw-google @bzbarsky-apple
Update examples/chip-tool/commands/icd/ICDCommand.cpp
0368a1e 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@yunhanw-google
address comments
f181fb7
@yunhanw-google
update file description
535671b
@yunhanw-google
add missing change
371579f
@restyled-commits @yunhanw-google
Restyled by whitespace
ef3e4e5
@yunhanw-google @bzbarsky-apple
Update examples/chip-tool/commands/common/CHIPCommand.cpp
a38ba96 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@yunhanw-google
fix the assert text
2386736
@yunhanw-google
update comments
e348529
@yunhanw-google
address comment
a9e5645
@restyled-commits @yunhanw-google
Restyled by clang-format
10ea5cd
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

PR #30863: Size comparison from bc746ae to 10ea5cd

Increases above 0.2%:

platform target config section bc746ae 10ea5cd change % change
linux chip-tool debug (read only) 11652665 11682569 29904 0.3
.init_array 776 784 8 1.0
.rodata 421897 424393 2496 0.6
.text 10541987 10568339 26352 0.2
chip-tool-ipv6only arm64 (read only) 11380352 11410720 30368 0.3
(read/write) 569336 571848 2512 0.4
.got 19744 19816 72 0.4
.text 10169512 10198072 28560 0.3
Increases (3 builds for linux)
platform target config section bc746ae 10ea5cd change % change
linux chip-tool debug (read only) 11652665 11682569 29904 0.3
(read/write) 503368 503952 584 0.1
.bss 94072 94200 128 0.1
.data.rel.ro 397056 397520 464 0.1
.init_array 776 784 8 1.0
.rodata 421897 424393 2496 0.6
.text 10541987 10568339 26352 0.2
chip-tool-ipv6only arm64 (read only) 11380352 11410720 30368 0.3
(read/write) 569336 571848 2512 0.4
.bss 103352 103448 96 0.1
.data 4280 4288 8 0.2
.data.rel.ro 435904 436312 408 0.1
.got 19744 19816 72 0.4
.rodata 344200 344792 592 0.2
.text 10169512 10198072 28560 0.3
tv-casting-app debug (read only) 9561945 9562057 112 0.0
.rodata 362408 362632 224 0.1
Decreases (2 builds for efr32, linux)
platform target config section bc746ae 10ea5cd change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114448 1114440 -8 -0.0
.text 923060 923052 -8 -0.0
linux tv-casting-app debug .text 8735827 8735715 -112 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section bc746ae 10ea5cd change % change
bl602 lighting-app bl602 (read/write) 1417862 1417862 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156892 156892 0 0.0
.text 1085746 1085746 0 0.0
bl602+mfd (read/write) 1432582 1432582 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155852 155852 0 0.0
.text 1101368 1101368 0 0.0
bl602+rpc (read/write) 1465646 1465646 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164516 164516 0 0.0
.text 1117490 1117490 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1182871 1182871 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106268 106268 0 0.0
.text 955448 955448 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1194003 1194003 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105208 105208 0 0.0
.text 967510 967510 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274887 1274887 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121688 121688 0 0.0
.text 1030510 1030510 0 0.0
bl706-eth (read/write) 1002497 1002497 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99600 99600 0 0.0
.text 748344 748344 0 0.0
bl706-wifi (read/write) 1240630 1240630 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120580 120580 0 0.0
.text 975636 975636 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1152580 1152580 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100272 100272 0 0.0
.text 948574 948574 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1164028 1164028 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99212 99212 0 0.0
.text 960948 960948 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771768 771768 0 0.0
(read/write) 168100 168100 0 0.0
.bss 90436 90436 0 0.0
.data 3460 3460 0 0.0
.rodata 89520 89520 0 0.0
.text 681980 681980 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787824 787824 0 0.0
(read/write) 178328 178328 0 0.0
.bss 100612 100612 0 0.0
.data 3488 3488 0 0.0
.rodata 83768 83768 0 0.0
.text 703792 703792 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776072 776072 0 0.0
(read/write) 172784 172784 0 0.0
.bss 95068 95068 0 0.0
.data 3488 3488 0 0.0
.rodata 110376 110376 0 0.0
.text 665432 665432 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728688 728688 0 0.0
(read/write) 167096 167096 0 0.0
.bss 89208 89208 0 0.0
.data 3448 3448 0 0.0
.rodata 85096 85096 0 0.0
.text 643324 643324 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714224 714224 0 0.0
(read/write) 167276 167276 0 0.0
.bss 89392 89392 0 0.0
.data 3444 3444 0 0.0
.rodata 80928 80928 0 0.0
.text 633028 633028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566962 566962 0 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83922 83922 0 0.0
.text 480916 480916 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620298 620298 0 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105786 105786 0 0.0
.text 512388 512388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561351 561351 0 0.0
.app_xip_area 451609 451609 0 0.0
.bss 64656 64656 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543567 543567 0 0.0
.app_xip_area 429089 429089 0 0.0
.bss 69352 69352 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562335 562335 0 0.0
.app_xip_area 454049 454049 0 0.0
.bss 63272 63272 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557799 557799 0 0.0
.app_xip_area 446289 446289 0 0.0
.bss 66392 66392 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016988 1016988 0 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841680 841680 0 0.0
BRD4187C (read/write) 1100988 1100988 0 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901468 901468 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114448 1114440 -8 -0.0
.bss 188656 188656 0 0.0
.data 2712 2712 0 0.0
.text 923060 923052 -8 -0.0
window-app BRD4187C (read/write) 1135712 1135712 0 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964288 964288 0 0.0
esp32 all-clusters-app c3devkit (read only) 1137748 1137748 0 0.0
(read/write) 1671092 1671092 0 0.0
.dram0.bss 72864 72864 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241376 241376 0 0.0
.flash.text 1137748 1137748 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1182671 1182671 0 0.0
(read/write) 520292 520292 0 0.0
.dram0.bss 79512 79512 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272412 272412 0 0.0
.flash.text 1177287 1177287 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605000 605000 0 0.0
(read/write) 81736 81736 0 0.0
.bss 69584 69584 0 0.0
.data 2168 2168 0 0.0
.text 604464 604464 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690704 690704 0 0.0
.bss 67600 67600 0 0.0
.data 2716 2716 0 0.0
.text 576912 576912 0 0.0
light k32w0+release (read only) 594944 594944 0 0.0
(read/write) 79112 79112 0 0.0
.bss 67008 67008 0 0.0
.data 2120 2120 0 0.0
.text 594408 594408 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782516 782516 0 0.0
.bss 77276 77276 0 0.0
.data 1928 1928 0 0.0
.text 659856 659856 0 0.0
lock k32w0+release (read only) 576104 576104 0 0.0
(read/write) 79216 79216 0 0.0
.bss 67136 67136 0 0.0
.data 2096 2096 0 0.0
.text 575568 575568 0 0.0
linux air-purifier-app debug (read only) 2525661 2525661 0 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72776 72776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179272 179272 0 0.0
.text 2171029 2171029 0 0.0
all-clusters-app debug (read only) 5380697 5380697 0 0.0
(read/write) 453576 453576 0 0.0
.bss 131600 131600 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 310904 310904 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1232 1232 0 0.0
.rodata 309884 309884 0 0.0
.text 4663587 4663587 0 0.0
all-clusters-minimal-app debug (read only) 4952889 4952889 0 0.0
(read/write) 234656 234656 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95912 95912 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272845 272845 0 0.0
.text 4447619 4447619 0 0.0
bridge-app debug (read only) 4416617 4416617 0 0.0
(read/write) 215896 215896 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85232 85232 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219157 219157 0 0.0
.text 3978931 3978931 0 0.0
chip-tool debug (read only) 11652665 11682569 29904 0.3
(read/write) 503368 503952 584 0.1
.bss 94072 94200 128 0.1
.data 4994 4994 0 0.0
.data.rel.ro 397056 397520 464 0.1
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 784 8 1.0
.rodata 421897 424393 2496 0.6
.text 10541987 10568339 26352 0.2
chip-tool-ipv6only arm64 (read only) 11380352 11410720 30368 0.3
(read/write) 569336 571848 2512 0.4
.bss 103352 103448 96 0.1
.data 4280 4288 8 0.2
.data.rel.ro 435904 436312 408 0.1
.dynamic 512 512 0 0.0
.got 19744 19816 72 0.4
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 344200 344792 592 0.2
.text 10169512 10198072 28560 0.3
lighting-app debug+rpc+ui (read only) 5302305 5302305 0 0.0
(read/write) 224968 224968 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93632 93632 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340340 340340 0 0.0
.text 4717219 4717219 0 0.0
lock-app debug (read only) 4501681 4501681 0 0.0
(read/write) 203616 203616 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4044659 4044659 0 0.0
ota-provider-app debug (read only) 4165809 4165809 0 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69248 69248 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3772675 3772675 0 0.0
ota-requestor-app debug (read only) 4255313 4255313 0 0.0
(read/write) 196976 196976 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72240 72240 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205141 205141 0 0.0
.text 3853939 3853939 0 0.0
shell debug (read only) 2787865 2787865 0 0.0
(read/write) 151592 151592 0 0.0
.bss 62152 62152 0 0.0
.data 768 768 0 0.0
.data.rel.ro 82864 82864 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 181792 181792 0 0.0
.text 2435170 2435170 0 0.0
thermostat-no-ble arm64 (read only) 4405296 4405296 0 0.0
(read/write) 245192 245192 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3902648 3902648 0 0.0
tv-app debug (read only) 5384297 5384297 0 0.0
(read/write) 348896 348896 0 0.0
.bss 244384 244384 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92216 92216 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272853 272853 0 0.0
.text 4873635 4873635 0 0.0
tv-casting-app debug (read only) 9561945 9562057 112 0.0
(read/write) 338168 338168 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 172664 172664 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 362408 362632 224 0.1
.text 8735827 8735715 -112 -0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526040 2526040 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488724 1488724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1062456 1062456 0 0.0
bss 129375 129375 0 0.0
rodata 104392 104392 0 0.0
text 781104 781104 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1189032 1189032 0 0.0
bss 121585 121585 0 0.0
rodata 138460 138460 0 0.0
text 778648 778648 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046728 1046728 0 0.0
bss 129348 129348 0 0.0
rodata 99432 99432 0 0.0
text 770320 770320 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835880 835880 0 0.0
(read/write) 1743436 1743436 0 0.0
.bss 194988 194988 0 0.0
.data 2472 2472 0 0.0
.text 1537588 1537588 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705924 1705924 0 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502108 1502108 0 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630884 1630884 0 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433756 1433756 0 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657796 1657796 0 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433548 1433548 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116748 1116748 0 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 629124 629124 0 0.0
lock-app qpg6105+debug (read/write) 1080500 1080500 0 0.0
.bss 97352 97352 0 0.0
.data 784 784 0 0.0
.text 592880 592880 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820830 820830 0 0.0
bss 54904 54904 0 0.0
text 613512 613512 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1080344 1080344 0 0.0
bss 100388 100388 0 0.0
text 762378 762378 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083928 1083928 0 0.0
bss 109764 109764 0 0.0
text 753428 753428 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934568 934568 0 0.0
bss 94272 94272 0 0.0
text 646848 646848 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821066 821066 0 0.0
bss 54948 54948 0 0.0
text 613882 613882 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 978216 978216 0 0.0
bss 78932 78932 0 0.0
text 694030 694030 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092916 1092916 0 0.0
bss 99836 99836 0 0.0
text 769740 769740 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 964348 964348 0 0.0
bss 97196 97196 0 0.0
text 647584 647584 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948244 948244 0 0.0
bss 92380 92380 0 0.0
text 662956 662956 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 879864 879864 0 0.0
bss 68924 68924 0 0.0
text 621890 621890 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 820476 820476 0 0.0
bss 57160 57160 0 0.0
text 588766 588766 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705584 705584 0 0.0
bss 73588 73588 0 0.0
text 462084 462084 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822802 822802 0 0.0
bss 55084 55084 0 0.0
text 616626 616626 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877569 877569 0 0.0
bss 60636 60636 0 0.0
text 630506 630506 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844848 844848 0 0.0
bss 57456 57456 0 0.0
text 607232 607232 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839124 839124 0 0.0
bss 57808 57808 0 0.0
text 601266 601266 0 0.0

@yunhanw-google yunhanw-google merged commit cce6c24 into project-chip:master Dec 12, 2023
57 checks passed
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
1c5e0c5 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
431fcc0 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
ffef3e9 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
313a585 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
68458bd 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
5ceab01 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
0e0dc19 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
3ed9aa7 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
2d72a55 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
704a2ec 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
thivya-amazon pushed a commit to thivya-amazon/connectedhomeip that referenced this pull request Dec 12, 2023
@erjiaqing @thivya-amazon
[icd] integrate ICD management command into CHIP tool (project-chip#3…
7a84cdc 
…0863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build
@joonhaengHeo joonhaengHeo mentioned this pull request Dec 21, 2023
Closed
yunhanw-google added a commit that referenced this pull request Jan 10, 2024
@thivya-amazon @restyled-commits
@jepenven-silabs @yunhanw-google @erjiaqing @mkardous-silabs
Icd handler (#30731)
4838490 
* ICDHandler initialization

* ICDHandler initialization

* Restyled by gn

* Update src/app/icd/ICDHandler.cpp

Co-authored-by: Jean-Francois Penven <67962328+jepenven-silabs@users.noreply.github.com>

* ICDHandler initialization

* ICDHandler initialization

* ICDHandler initialization

* Restyled by gn

* ICDHandler initialization

* ICDHandler initialization

* Restyled by gn

* ICDHandler initialization

* Restyled by gn

* ICDHandler initialization

* ICDHandler initialization

* ICDHandler initialization

* ICDHandler initialization

* ICDHandler initialization

* Moved counter validation to DefaultICDClientStorage.

* Renamed ICDHandler to CheckInHandler

* Included CheckInDelegate in BUILD.gn

* Restyled by gn

* Added DefaultCheckInDelegate

* Restyled by whitespace

* Restyled by gn

* Modified error codes

* Updated variables

* Added condition for VerifyOrReturnError

* Resolve conflicts with master branch

* Added CheckInHandler init in chiptool

* Restyled by clang-format

* Restyled by gn

* Added include file

* Modified the access operator

* Added ICD client deps for tv-casting-app

* Restyled by gn

* Added unit test case for ProcessCheckInPayload

* Updated doxygen comments

* Addressed review comments

* Addressed review comments

* Addressed review comments.

* Moved checkin counter validation to CheckInHandler.

* Removed TestDefaultICDClientStorage from iotsdk.

* Restyled by gn

* add CheckInExchangeDispatch to accept unsecure check-in message

* Restyled by clang-format

* Removed DefaultICDClientInfoPersistentStorage.cpp.

* Addressed a few review comments.

* Modified a macro to make sure it is taken as a 64-bit interger.

* Restyled by clang-format

* Removed redundant error code CHIP_ERROR_DUPLICATE_MESSAGE

* Restyled by clang-format

* Modified the datatype for checkInCounter to CounterType from auto.

* Added code to refresh key.

* ICDHandler initialization

* ICDHandler initialization

* Resolve conflicts with master branch

* Added CheckInHandler init in chiptool

* Moved checkin counter validation to CheckInHandler.

* [icd] integrate ICD management command into CHIP tool (#30863)

* [icd] integrate ICD management command into CHIP tool

* Delete entry on failure

* Fix build

* ICDHandler initialization

* Added CheckInHandler init in chiptool

* Fixing merge conflicts

* Added OnRefreshKey callback

* Restyled by gn

* Modified APPDATA_LENGTh macro to inline consexpr variable.

* Modified CheckInDelegate and CheckInHandler to static members in chiptool.

* Return CHIP_NO_ERROR for failures in processing checkin message.

* Addressed review comments

* Fixed a spelling error

* Moved variable definition

* Reenable TestDefaultClientStorage for open iot.

* Restyled by gn

* Modified code to use updated API

* Removed obsolete comments

* Added comments

* Addressed review comments

* Improve ICDClientStorage (#30931)

* Added const qualifier to payload

* Return CHIP_NO_ERROR for duplicate check in message and log error.

* Return CHIP_NO_ERROR on duplicate checkin messages

* Added OnRefreshKeyRetrieve and addressed review comments

* Update src/lib/core/CHIPError.h

Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Added a temporary suppression of error for including <unordered_map>

* Added a comment to suppress Lint error

* Addressed review comments

* Addressed review comments

* Addressed review comments.

* Removed code pertaining to key refresh. Will be a separate PR.

* Added a link to an issue

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Jean-Francois Penven <67962328+jepenven-silabs@users.noreply.github.com>
Co-authored-by: yunhanw <yunhanw@google.com>
Co-authored-by: Song GUO <songguo@google.com>
Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples icd Intermittently Connected Devices review - approved tools
Projects
[Feature] Intermittently Connected Devices (ICD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erjiaqing @yunhanw-google @bzbarsky-apple @restyled-commits