Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Add a menuconfig option to enable/disable persist subscription #30889

Merged
merged 2 commits into from
Feb 6, 2024
+15 −2
Merged

ESP32: Add a menuconfig option to enable/disable persist subscription #30889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c38b21c
ESP32: Add a menuconfig option to enable/disable persist subscription
wqx6 Dec 8, 2023
bedcaa2
enable persistent subscription by default
wqx6 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/esp32/components/chip/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,12 @@ if ((CONFIG_BT_ENABLED) AND (CONFIG_ENABLE_CHIPOBLE))
endif()
endif()

if (CONFIG_ENABLE_PERSIST_SUBSCRIPTIONS)
chip_gn_arg_append("chip_persist_subscriptions" "true")
else()
chip_gn_arg_append("chip_persist_subscriptions" "false")
endif()

if (CONFIG_ENABLE_ESP32_BLE_CONTROLLER)
chip_gn_arg_append("chip_enable_ble_controller" "true")
endif()
Expand Down
7 changes: 7 additions & 0 deletions config/esp32/components/chip/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ menu "CHIP Core"
help
Some device types don't require the read client. Enabling this option may save some flash/ram.

config ENABLE_PERSIST_SUBSCRIPTIONS
bool "Enable persist subscriptions"
default y
help
Enable persist subscriptions to make the device resume the subscriptions from the persist
subscriptions information after reboot.

config BUILD_CHIP_TESTS
bool "Build CHIP tests"
default n
Expand Down
4 changes: 2 additions & 2 deletions src/platform/device.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ declare_args() {

# Enable Subscription persistence / resumption for CI and supported platforms
if (chip_device_platform == "darwin" || chip_device_platform == "linux" ||
chip_device_platform == "esp32" || chip_device_platform == "fake" ||
chip_device_platform == "efr32" || chip_device_platform == "SiWx917") {
chip_device_platform == "fake" || chip_device_platform == "efr32" ||
wqx6 marked this conversation as resolved.
Show resolved Hide resolved
chip_device_platform == "SiWx917") {
chip_persist_subscriptions = true
} else {
chip_persist_subscriptions = false
Expand Down
Loading