Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused files from src/app/zap-templates/zcl/data-model/draft/ #30895

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Remove unused files from src/app/zap-templates/zcl/data-model/draft/ #30895

merged 4 commits into from
Dec 8, 2023

Conversation

andy31415
Copy link
Contributor

Changes

  • remove EN50523-appliance-identification.xml and meter-identification.xml as I found no references to them
  • remove all of src/app/zap-templates/zcl/data-model/draft/types/ as I did not see those types referenced and they do not contain a cluster code anyway (so generated code should not contain them).
  • update a comment that was referencing drafts (but did not update availability.yaml since I was unsure there ... that comment already seemed somewhat obsolete, but maybe it references that the types themselves are drafts)

Testing

Zap regeneration has no diffs (was mostly concerned about darwin API since it references drafts ... however it seems the types it references are not actually in draft anymore.

CI should still pass

@github-actions github-actions bot added the app label Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

PR #30895: Size comparison from 78fb77f to 6e98350

Decreases (1 build for efr32)
platform target config section 78fb77f 6e98350 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114016 1114008 -8 -0.0
.text 922660 922652 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 78fb77f 6e98350 change % change
bl602 lighting-app bl602 (read/write) 1413742 1413742 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156892 156892 0 0.0
.text 1081626 1081626 0 0.0
bl602+mfd (read/write) 1428206 1428206 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155852 155852 0 0.0
.text 1096990 1096990 0 0.0
bl602+rpc (read/write) 1461526 1461526 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164516 164516 0 0.0
.text 1113370 1113370 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1178419 1178419 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106268 106268 0 0.0
.text 950994 950994 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1189295 1189295 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105208 105208 0 0.0
.text 962802 962802 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1270431 1270431 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121688 121688 0 0.0
.text 1026056 1026056 0 0.0
bl706-eth (read/write) 998373 998373 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99600 99600 0 0.0
.text 744218 744218 0 0.0
bl706-wifi (read/write) 1235010 1235010 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120580 120580 0 0.0
.text 970016 970016 0 0.0
bl702l lighting-app bl702l (read/write) 1148636 1148636 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100272 100272 0 0.0
.text 944120 944120 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1159576 1159576 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99212 99212 0 0.0
.text 956496 956496 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742212 742212 0 0.0
(read/write) 167116 167116 0 0.0
.bss 89532 89532 0 0.0
.data 3420 3420 0 0.0
.rodata 84648 84648 0 0.0
.text 657176 657176 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759420 759420 0 0.0
(read/write) 177344 177344 0 0.0
.bss 99708 99708 0 0.0
.data 3448 3448 0 0.0
.rodata 79728 79728 0 0.0
.text 679304 679304 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746404 746404 0 0.0
(read/write) 171800 171800 0 0.0
.bss 94164 94164 0 0.0
.data 3448 3448 0 0.0
.rodata 105504 105504 0 0.0
.text 640508 640508 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 700004 700004 0 0.0
(read/write) 166120 166120 0 0.0
.bss 88312 88312 0 0.0
.data 3408 3408 0 0.0
.rodata 80440 80440 0 0.0
.text 619176 619176 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685524 685524 0 0.0
(read/write) 166292 166292 0 0.0
.bss 88488 88488 0 0.0
.data 3404 3404 0 0.0
.rodata 76280 76280 0 0.0
.text 608856 608856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566578 566578 0 0.0
(read/write) 207620 207620 0 0.0
.bss 201084 201084 0 0.0
.data 1412 1412 0 0.0
.rodata 83922 83922 0 0.0
.text 480536 480536 0 0.0
lock CC3235SF_LAUNCHXL (read only) 619818 619818 0 0.0
(read/write) 208016 208016 0 0.0
.bss 201448 201448 0 0.0
.data 1448 1448 0 0.0
.rodata 105786 105786 0 0.0
.text 511912 511912 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 560975 560975 0 0.0
.app_xip_area 451265 451265 0 0.0
.bss 64624 64624 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543079 543079 0 0.0
.app_xip_area 428633 428633 0 0.0
.bss 69320 69320 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561951 561951 0 0.0
.app_xip_area 453697 453697 0 0.0
.bss 63240 63240 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557263 557263 0 0.0
.app_xip_area 445785 445785 0 0.0
.bss 66360 66360 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016428 1016428 0 0.0
.bss 172568 172568 0 0.0
.data 2688 2688 0 0.0
.text 841152 841152 0 0.0
BRD4187C (read/write) 1100620 1100620 0 0.0
.bss 196172 196172 0 0.0
.data 3296 3296 0 0.0
.text 901132 901132 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114016 1114008 -8 -0.0
.bss 188624 188624 0 0.0
.data 2712 2712 0 0.0
.text 922660 922652 -8 -0.0
window-app BRD4187C (read/write) 1135128 1135128 0 0.0
.bss 168204 168204 0 0.0
.data 3168 3168 0 0.0
.text 963736 963736 0 0.0
esp32 all-clusters-app c3devkit (read only) 1136056 1136056 0 0.0
(read/write) 1670548 1670548 0 0.0
.dram0.bss 72536 72536 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241152 241152 0 0.0
.flash.text 1136056 1136056 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1181367 1181367 0 0.0
(read/write) 519744 519744 0 0.0
.dram0.bss 79192 79192 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272184 272184 0 0.0
.flash.text 1175983 1175983 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 594816 594816 0 0.0
(read/write) 88128 88128 0 0.0
.bss 71376 71376 0 0.0
.data 2128 2128 0 0.0
.text 594280 594280 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690448 690448 0 0.0
.bss 67584 67584 0 0.0
.data 2716 2716 0 0.0
.text 576672 576672 0 0.0
light k32w0+release (read only) 594512 594512 0 0.0
(read/write) 87804 87804 0 0.0
.bss 71064 71064 0 0.0
.data 2116 2116 0 0.0
.text 593976 593976 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782252 782252 0 0.0
.bss 77252 77252 0 0.0
.data 1928 1928 0 0.0
.text 659616 659616 0 0.0
lock k32w0+release (read only) 565904 565904 0 0.0
(read/write) 85600 85600 0 0.0
.bss 68920 68920 0 0.0
.data 2056 2056 0 0.0
.text 565368 565368 0 0.0
linux air-purifier-app debug (read only) 2524413 2524413 0 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72776 72776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179272 179272 0 0.0
.text 2169781 2169781 0 0.0
all-clusters-app debug (read only) 5368425 5368425 0 0.0
(read/write) 449600 449600 0 0.0
.bss 130064 130064 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 308472 308472 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 308476 308476 0 0.0
.text 4654931 4654931 0 0.0
all-clusters-minimal-app debug (read only) 4951433 4951433 0 0.0
(read/write) 234656 234656 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95912 95912 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272813 272813 0 0.0
.text 4446195 4446195 0 0.0
bridge-app debug (read only) 4415305 4415305 0 0.0
(read/write) 215896 215896 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85232 85232 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219125 219125 0 0.0
.text 3977651 3977651 0 0.0
chip-tool debug (read only) 11583073 11583073 0 0.0
(read/write) 500520 500520 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 394208 394208 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 418761 418761 0 0.0
.text 10479155 10479155 0 0.0
chip-tool-ipv6only arm64 (read only) 11317072 11317072 0 0.0
(read/write) 567120 567120 0 0.0
.bss 103352 103352 0 0.0
.data 4280 4280 0 0.0
.data.rel.ro 432952 432952 0 0.0
.dynamic 512 512 0 0.0
.got 19696 19696 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 341544 341544 0 0.0
.text 10112776 10112776 0 0.0
lighting-app debug+rpc+ui (read only) 5300865 5300865 0 0.0
(read/write) 224968 224968 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93632 93632 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340244 340244 0 0.0
.text 4715875 4715875 0 0.0
lock-app debug (read only) 4499809 4499809 0 0.0
(read/write) 203616 203616 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4042787 4042787 0 0.0
ota-provider-app debug (read only) 4164561 4164561 0 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69248 69248 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3771427 3771427 0 0.0
ota-requestor-app debug (read only) 4253985 4253985 0 0.0
(read/write) 196976 196976 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72240 72240 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205109 205109 0 0.0
.text 3852643 3852643 0 0.0
shell debug (read only) 2779105 2779105 0 0.0
(read/write) 149792 149792 0 0.0
.bss 60616 60616 0 0.0
.data 768 768 0 0.0
.data.rel.ro 82608 82608 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 181024 181024 0 0.0
.text 2427394 2427394 0 0.0
thermostat-no-ble arm64 (read only) 4403968 4403968 0 0.0
(read/write) 246504 246504 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162316 162316 0 0.0
.text 3901336 3901336 0 0.0
tv-app debug (read only) 5382729 5382729 0 0.0
(read/write) 348896 348896 0 0.0
.bss 244384 244384 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92216 92216 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272853 272853 0 0.0
.text 4872067 4872067 0 0.0
tv-casting-app debug (read only) 9494249 9494249 0 0.0
(read/write) 337336 337336 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 171832 171832 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 359976 359976 0 0.0
.text 8672579 8672579 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525656 2525656 0 0.0
.bss 220184 220184 0 0.0
.data 5144 5144 0 0.0
.text 1488340 1488340 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060796 1060796 0 0.0
bss 129029 129029 0 0.0
rodata 104172 104172 0 0.0
text 779924 779924 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1187352 1187352 0 0.0
bss 121239 121239 0 0.0
rodata 138300 138300 0 0.0
text 777492 777492 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046424 1046424 0 0.0
bss 129316 129316 0 0.0
rodata 99432 99432 0 0.0
text 770012 770012 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836224 836224 0 0.0
(read/write) 1741156 1741156 0 0.0
.bss 194644 194644 0 0.0
.data 2472 2472 0 0.0
.text 1535652 1535652 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837944 837944 0 0.0
(read/write) 1705460 1705460 0 0.0
.bss 192924 192924 0 0.0
.data 2472 2472 0 0.0
.text 1501676 1501676 0 0.0
light cy8ckit_062s2_43012 (read only) 844632 844632 0 0.0
(read/write) 1630420 1630420 0 0.0
.bss 186348 186348 0 0.0
.data 2360 2360 0 0.0
.text 1433324 1433324 0 0.0
lock cy8ckit_062s2_43012 (read only) 817512 817512 0 0.0
(read/write) 1657268 1657268 0 0.0
.bss 213444 213444 0 0.0
.data 2384 2384 0 0.0
.text 1433052 1433052 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116364 1116364 0 0.0
.bss 101200 101200 0 0.0
.data 740 740 0 0.0
.text 628740 628740 0 0.0
lock-app qpg6105+debug (read/write) 1080004 1080004 0 0.0
.bss 97336 97336 0 0.0
.data 784 784 0 0.0
.text 592384 592384 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819998 819998 0 0.0
bss 54904 54904 0 0.0
text 612678 612678 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1077860 1077860 0 0.0
bss 100072 100072 0 0.0
text 760584 760584 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083096 1083096 0 0.0
bss 109764 109764 0 0.0
text 752594 752594 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933864 933864 0 0.0
bss 94272 94272 0 0.0
text 646142 646142 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820210 820210 0 0.0
bss 54948 54948 0 0.0
text 613024 613024 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 977240 977240 0 0.0
bss 78932 78932 0 0.0
text 693056 693056 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092140 1092140 0 0.0
bss 99836 99836 0 0.0
text 768962 768962 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 963476 963476 0 0.0
bss 97196 97196 0 0.0
text 646710 646710 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 947516 947516 0 0.0
bss 92380 92380 0 0.0
text 662232 662232 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 878992 878992 0 0.0
bss 68924 68924 0 0.0
text 621014 621014 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819596 819596 0 0.0
bss 57160 57160 0 0.0
text 587890 587890 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705416 705416 0 0.0
bss 73588 73588 0 0.0
text 461916 461916 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821866 821866 0 0.0
bss 55084 55084 0 0.0
text 615696 615696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876697 876697 0 0.0
bss 60636 60636 0 0.0
text 629638 629638 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 843944 843944 0 0.0
bss 57456 57456 0 0.0
text 606326 606326 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838260 838260 0 0.0
bss 57808 57808 0 0.0
text 600402 600402 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the types stuff was for "if we ever actually have this cluster, it will need this type defined".... But removing is probably fine.

@mergify mergify bot merged commit ecd27c4 into project-chip:master Dec 8, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pidarped pidarped pidarped approved these changes

@cecille cecille cecille approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andy31415 @pidarped @cecille @bzbarsky-apple @andreilitvin