Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle [example/nrfconnect] Added support for sending UDP broadcast messages. #3111

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Oct 7, 2020

A duplicate of #3110 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

kkasperczyk-no and others added 2 commits October 7, 2020 09:16
nrfconnect platform doesn't support sending UDP broadcast messages
periodically by PublishService as other platforms do (e.h. nrf5)

* Added Service component with PublishService implementation
to support sending UDP broadcast messages.
@restyled-io restyled-io bot added the restyled label Oct 7, 2020
@restyled-io restyled-io bot closed this Oct 7, 2020
@restyled-io restyled-io bot deleted the restyled/pull-3110 branch October 7, 2020 07:24
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-lock.elf text 316 316
chip-lock.elf rodata 40 40
chip-lock.elf [LOAD #3 [RW]] 0 16
chip-lock.elf bss 0 16
chip-lock.elf [LOAD #1 [RWX]] 4 4
chip-lighting.elf text 316 316
chip-lighting.elf rodata 36 36
chip-lighting.elf bss 0 16
chip-lighting.elf [LOAD #1 [RWX]] 4 4
chip-lighting.elf [LOAD #3 [RW]] 0 -16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,34873
.debug_line,0,4410
.debug_abbrev,0,2788
.debug_loc,0,319
text,316,316
.debug_str,0,313
.strtab,0,230
.symtab,0,176
.debug_ranges,0,120
.debug_frame,0,60
rodata,40,40
.debug_aranges,0,32
[LOAD #3 [RW]],16,0
bss,16,0
[LOAD #1 [RWX]],4,4
[Unmapped],0,-5

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,34877
.debug_line,0,4420
.debug_abbrev,0,2788
text,316,316
.debug_loc,0,315
.debug_str,0,313
.strtab,0,230
.symtab,0,176
.debug_ranges,0,120
.debug_frame,0,60
rodata,36,36
.debug_aranges,0,32
bss,16,0
[LOAD #1 [RWX]],4,4
[Unmapped],0,-7
[LOAD #3 [RW]],-16,0


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants