Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make attribute-storage.h API surface smaller #31568

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Make attribute-storage.h API surface smaller #31568

merged 4 commits into from
Jan 22, 2024

Conversation

andy31415
Copy link
Contributor

Moved several seemingly private APIs internally as static functions (may get a bit of size gains here), removed a seemingly unused getter by index (however the count is still used in scenes ... some review will be needed to understand if that usage is a bug or not - it seems odd to need the total count if all accessors use client or server indices)

@github-actions github-actions bot added the app label Jan 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

PR #31568: Size comparison from 0f31a82 to f23feaa

Increases (1 build for cc32xx)
platform target config section 0f31a82 f23feaa change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 623514 623530 16 0.0
.text 515084 515100 16 0.0
Decreases (40 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, nrfconnect, qpg, telink)
platform target config section 0f31a82 f23feaa change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780720 780704 -16 -0.0
.text 690024 690008 -16 -0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 796520 796504 -16 -0.0
.text 711636 711620 -16 -0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 784912 784896 -16 -0.0
.text 673356 673340 -16 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 737552 737536 -16 -0.0
.text 651280 651264 -16 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 723184 723168 -16 -0.0
.text 641072 641056 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 563535 563519 -16 -0.0
.app_xip_area 453457 453441 -16 -0.0
lock cyw930739m2evb_01 (read/write) 545647 545631 -16 -0.0
.app_xip_area 430833 430817 -16 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 564751 564735 -16 -0.0
.app_xip_area 456129 456113 -16 -0.0
switch cyw930739m2evb_01 (read/write) 560103 560079 -24 -0.0
.app_xip_area 448249 448225 -24 -0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1045064 1045056 -8 -0.0
.text 849468 849460 -8 -0.0
BRD4187C (read/write) 1107360 1107328 -32 -0.0
.text 908808 908776 -32 -0.0
lock-app BRD4161A+wf200 (read/write) 1119404 1119372 -32 -0.0
.text 928400 928368 -32 -0.0
window-app BRD4187C (read/write) 1141256 1141248 -8 -0.0
.text 970804 970796 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1194676 1194652 -24 -0.0
.flash.text 1194676 1194652 -24 -0.0
m5stack (read only) 1238563 1238511 -52 -0.0
.flash.text 1232399 1232347 -52 -0.0
k32w contact k32w0+release (read only) 608144 608128 -16 -0.0
.text 607608 607592 -16 -0.0
k32w1+release (read/write) 693804 693780 -24 -0.0
.text 579784 579760 -24 -0.0
light k32w0+release (read only) 597496 597480 -16 -0.0
.text 596960 596944 -16 -0.0
k32w1+release (read/write) 785744 785728 -16 -0.0
.text 662856 662840 -16 -0.0
lock k32w0+release (read only) 578800 578784 -16 -0.0
.text 578264 578248 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1093184 1093168 -16 -0.0
text 804620 804604 -16 -0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1213800 1213784 -16 -0.0
text 800412 800396 -16 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1042504 1042488 -16 -0.0
text 766176 766160 -16 -0.0
qpg lighting-app qpg6105+debug (read/write) 1119608 1119592 -16 -0.0
.text 631988 631972 -16 -0.0
lock-app qpg6105+debug (read/write) 1083600 1083584 -16 -0.0
.text 595976 595960 -16 -0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 823970 823946 -24 -0.0
text 615930 615908 -22 -0.0
all-clusters-app tlsr9518adk80d (read/write) 1110708 1110684 -24 -0.0
text 785698 785676 -22 -0.0
all-clusters-minimal-app tlsr9528a (read/write) 1087644 1087628 -16 -0.0
text 756192 756170 -22 -0.0
bridge-app tlsr9518adk80d (read/write) 933284 933260 -24 -0.0
text 647142 647120 -22 -0.0
contact-sensor-app tlsr9528a_retention (read/write) 824206 824182 -24 -0.0
text 616300 616278 -22 -0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 982100 982076 -24 -0.0
text 696962 696940 -22 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1096264 1096240 -24 -0.0
text 772338 772316 -22 -0.0
lock-app-dfu tlsr9528a (read/write) 967980 967956 -24 -0.0
text 650098 650076 -22 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 951596 951572 -24 -0.0
text 665494 665472 -22 -0.0
pump-app tlsr9528a (read/write) 883108 883092 -16 -0.0
text 624416 624394 -22 -0.0
pump-controller-app tlsr9518adk80d (read/write) 823760 823736 -24 -0.0
text 591340 591318 -22 -0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 825942 825918 -24 -0.0
text 619046 619024 -22 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 881213 881189 -24 -0.0
text 633354 633332 -22 -0.0
thermostat tlsr9518adk80d (read/write) 848468 848452 -16 -0.0
text 610096 610074 -22 -0.0
window-covering tlsr9518adk80d (read/write) 842324 842300 -24 -0.0
text 603760 603738 -22 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0f31a82 f23feaa change % change
bl602 lighting-app bl602 (read/write) 1422490 1422490 0 0.0
.bss 85328 85328 0 0.0
.data 9488 9488 0 0.0
.rodata 157260 157260 0 0.0
.text 1089772 1089772 0 0.0
bl602+mfd (read/write) 1436962 1436962 0 0.0
.bss 85496 85496 0 0.0
.data 9456 9456 0 0.0
.rodata 156220 156220 0 0.0
.text 1105140 1105140 0 0.0
bl602+rpc (read/write) 1470250 1470250 0 0.0
.bss 93360 93360 0 0.0
.data 9864 9864 0 0.0
.rodata 164828 164828 0 0.0
.text 1121532 1121532 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1187343 1187343 0 0.0
.bss 11133 11133 0 0.0
.data 3664 3664 0 0.0
.rodata 106644 106644 0 0.0
.text 959114 959114 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1198475 1198475 0 0.0
.bss 11309 11309 0 0.0
.data 3648 3648 0 0.0
.rodata 105584 105584 0 0.0
.text 971178 971178 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1278959 1278959 0 0.0
.bss 19597 19597 0 0.0
.data 4224 4224 0 0.0
.rodata 122016 122016 0 0.0
.text 1033924 1033924 0 0.0
bl706-eth (read/write) 1006433 1006433 0 0.0
.bss 23692 23692 0 0.0
.data 3240 3240 0 0.0
.rodata 99964 99964 0 0.0
.text 751600 751600 0 0.0
bl706-wifi (read/write) 1237726 1237726 0 0.0
.bss 10577 10577 0 0.0
.data 3680 3680 0 0.0
.rodata 120944 120944 0 0.0
.text 980152 980152 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1156720 1156720 0 0.0
.bss 16328 16328 0 0.0
.data 5032 5032 0 0.0
.rodata 100648 100648 0 0.0
.text 951992 951992 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1168172 1168172 0 0.0
.bss 16504 16504 0 0.0
.data 5008 5008 0 0.0
.rodata 99588 99588 0 0.0
.text 964368 964368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780720 780704 -16 -0.0
(read/write) 168864 168864 0 0.0
.bss 90884 90884 0 0.0
.data 3552 3552 0 0.0
.rodata 90432 90432 0 0.0
.text 690024 690008 -16 -0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 796520 796504 -16 -0.0
(read/write) 179100 179100 0 0.0
.bss 101060 101060 0 0.0
.data 3580 3580 0 0.0
.rodata 84616 84616 0 0.0
.text 711636 711620 -16 -0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 784912 784896 -16 -0.0
(read/write) 173556 173556 0 0.0
.bss 95516 95516 0 0.0
.data 3580 3580 0 0.0
.rodata 111288 111288 0 0.0
.text 673356 673340 -16 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 737552 737536 -16 -0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86008 86008 0 0.0
.text 651280 651264 -16 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 723184 723168 -16 -0.0
(read/write) 168048 168048 0 0.0
.bss 89848 89848 0 0.0
.data 3536 3536 0 0.0
.rodata 81848 81848 0 0.0
.text 641072 641056 -16 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 570154 570154 0 0.0
(read/write) 207888 207888 0 0.0
.bss 201172 201172 0 0.0
.data 1592 1592 0 0.0
.rodata 84434 84434 0 0.0
.text 483596 483596 0 0.0
lock CC3235SF_LAUNCHXL (read only) 623514 623530 16 0.0
(read/write) 208288 208288 0 0.0
.bss 201648 201648 0 0.0
.data 1520 1520 0 0.0
.rodata 106306 106306 0 0.0
.text 515084 515100 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 563535 563519 -16 -0.0
.app_xip_area 453457 453441 -16 -0.0
.bss 64920 64920 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 545647 545631 -16 -0.0
.app_xip_area 430833 430817 -16 -0.0
.bss 69616 69616 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 564751 564735 -16 -0.0
.app_xip_area 456129 456113 -16 -0.0
.bss 63504 63504 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 560103 560079 -24 -0.0
.app_xip_area 448249 448225 -24 -0.0
.bss 66624 66624 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1045064 1045056 -8 -0.0
.bss 192800 192800 0 0.0
.data 2776 2776 0 0.0
.text 849468 849460 -8 -0.0
BRD4187C (read/write) 1107360 1107328 -32 -0.0
.bss 195148 195148 0 0.0
.data 3384 3384 0 0.0
.text 908808 908776 -32 -0.0
lock-app BRD4161A+wf200 (read/write) 1119404 1119372 -32 -0.0
.bss 188184 188184 0 0.0
.data 2800 2800 0 0.0
.text 928400 928368 -32 -0.0
window-app BRD4187C (read/write) 1141256 1141248 -8 -0.0
.bss 167140 167140 0 0.0
.data 3292 3292 0 0.0
.text 970804 970796 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1194676 1194652 -24 -0.0
(read/write) 1744072 1744072 0 0.0
.dram0.bss 73352 73352 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 247592 247592 0 0.0
.flash.text 1194676 1194652 -24 -0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1238563 1238511 -52 -0.0
(read/write) 529032 529032 0 0.0
.dram0.bss 80216 80216 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 277764 277764 0 0.0
.flash.text 1232399 1232347 -52 -0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 608144 608128 -16 -0.0
(read/write) 81324 81324 0 0.0
.bss 69104 69104 0 0.0
.data 2236 2236 0 0.0
.text 607608 607592 -16 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 693804 693780 -24 -0.0
.bss 67760 67760 0 0.0
.data 2788 2788 0 0.0
.text 579784 579760 -24 -0.0
light k32w0+release (read only) 597496 597480 -16 -0.0
(read/write) 79340 79340 0 0.0
.bss 67168 67168 0 0.0
.data 2188 2188 0 0.0
.text 596960 596944 -16 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 785744 785728 -16 -0.0
.bss 77436 77436 0 0.0
.data 2000 2000 0 0.0
.text 662856 662840 -16 -0.0
lock k32w0+release (read only) 578800 578784 -16 -0.0
(read/write) 78756 78756 0 0.0
.bss 66608 66608 0 0.0
.data 2164 2164 0 0.0
.text 578264 578248 -16 -0.0
linux air-purifier-app debug (read only) 2544389 2544389 0 0.0
(read/write) 127200 127200 0 0.0
.bss 46272 46272 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 72856 72856 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 180776 180776 0 0.0
.text 2188309 2188309 0 0.0
all-clusters-app debug (read only) 5694441 5694441 0 0.0
(read/write) 465800 465800 0 0.0
.bss 132080 132080 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 321992 321992 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1296 1296 0 0.0
.rodata 335612 335612 0 0.0
.text 4939107 4939107 0 0.0
all-clusters-minimal-app debug (read only) 5089737 5089737 0 0.0
(read/write) 234712 234712 0 0.0
.bss 127216 127216 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 96040 96040 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 282541 282541 0 0.0
.text 4574883 4574883 0 0.0
bridge-app debug (read only) 4518625 4518625 0 0.0
(read/write) 215984 215984 0 0.0
.bss 117816 117816 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85312 85312 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 226485 226485 0 0.0
.text 4073571 4073571 0 0.0
chip-tool debug (read only) 12046153 12046153 0 0.0
(read/write) 514240 514240 0 0.0
.bss 94200 94200 0 0.0
.data 5058 5058 0 0.0
.data.rel.ro 407760 407760 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 437209 437209 0 0.0
.text 10905859 10905859 0 0.0
chip-tool-ipv6only arm64 (read only) 11588528 11588528 0 0.0
(read/write) 582488 582488 0 0.0
.bss 103256 103256 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 447256 447256 0 0.0
.dynamic 512 512 0 0.0
.got 20256 20256 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 345644 345644 0 0.0
.text 10358508 10358508 0 0.0
lighting-app debug+rpc+ui (read only) 5444689 5444689 0 0.0
(read/write) 224912 224912 0 0.0
.bss 118880 118880 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 93728 93728 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 350644 350644 0 0.0
.text 4849379 4849379 0 0.0
lock-app debug (read only) 4584193 4584193 0 0.0
(read/write) 203608 203608 0 0.0
.bss 113248 113248 0 0.0
.data 4096 4096 0 0.0
.data.rel.ro 79544 79544 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 253109 253109 0 0.0
.text 4121059 4121059 0 0.0
ota-provider-app debug (read only) 4241369 4241369 0 0.0
(read/write) 192688 192688 0 0.0
.bss 113248 113248 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206005 206005 0 0.0
.text 3843491 3843491 0 0.0
ota-requestor-app debug (read only) 4355945 4355945 0 0.0
(read/write) 196968 196968 0 0.0
.bss 114144 114144 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 211893 211893 0 0.0
.text 3947875 3947875 0 0.0
shell debug (read only) 2845953 2845953 0 0.0
(read/write) 154496 154496 0 0.0
.bss 62184 62184 0 0.0
.data 1344 1344 0 0.0
.data.rel.ro 85192 85192 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 187360 187360 0 0.0
.text 2486450 2486450 0 0.0
thermostat-no-ble arm64 (read only) 4415976 4415976 0 0.0
(read/write) 246712 246712 0 0.0
.bss 121624 121624 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 102824 102824 0 0.0
.dynamic 512 512 0 0.0
.got 12096 12096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 157436 157436 0 0.0
.text 3915932 3915932 0 0.0
tv-app debug (read only) 5511177 5511177 0 0.0
(read/write) 349232 349232 0 0.0
.bss 243136 243136 0 0.0
.data 6464 6464 0 0.0
.data.rel.ro 92344 92344 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 281589 281589 0 0.0
.text 4991651 4991651 0 0.0
tv-casting-app debug (read only) 9945457 9945457 0 0.0
(read/write) 342288 342288 0 0.0
.bss 155936 155936 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 176576 176576 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 376680 376680 0 0.0
.text 9096883 9096883 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2528800 2528800 0 0.0
.bss 220384 220384 0 0.0
.data 5208 5208 0 0.0
.text 1491484 1491484 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1093184 1093168 -16 -0.0
bss 129786 129786 0 0.0
rodata 111056 111056 0 0.0
text 804620 804604 -16 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1213800 1213784 -16 -0.0
bss 121924 121924 0 0.0
rodata 140972 140972 0 0.0
text 800412 800396 -16 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1042504 1042488 -16 -0.0
bss 129516 129516 0 0.0
rodata 99080 99080 0 0.0
text 766176 766160 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835368 835368 0 0.0
(read/write) 1788292 1788292 0 0.0
.bss 195332 195332 0 0.0
.data 2640 2640 0 0.0
.text 1581932 1581932 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837672 837672 0 0.0
(read/write) 1710420 1710420 0 0.0
.bss 193052 193052 0 0.0
.data 2616 2616 0 0.0
.text 1506364 1506364 0 0.0
light cy8ckit_062s2_43012 (read only) 844360 844360 0 0.0
(read/write) 1634852 1634852 0 0.0
.bss 186548 186548 0 0.0
.data 2432 2432 0 0.0
.text 1437484 1437484 0 0.0
lock cy8ckit_062s2_43012 (read only) 817240 817240 0 0.0
(read/write) 1661708 1661708 0 0.0
.bss 213644 213644 0 0.0
.data 2456 2456 0 0.0
.text 1437220 1437220 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1119608 1119592 -16 -0.0
.bss 102224 102224 0 0.0
.data 808 808 0 0.0
.text 631988 631972 -16 -0.0
lock-app qpg6105+debug (read/write) 1083600 1083584 -16 -0.0
.bss 98520 98520 0 0.0
.data 852 852 0 0.0
.text 595976 595960 -16 -0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823970 823946 -24 -0.0
bss 51020 51020 0 0.0
text 615930 615908 -22 -0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1110708 1110684 -24 -0.0
bss 100768 100768 0 0.0
text 785698 785676 -22 -0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1087644 1087628 -16 -0.0
bss 109912 109912 0 0.0
text 756192 756170 -22 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933284 933260 -24 -0.0
bss 92988 92988 0 0.0
text 647142 647120 -22 -0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824206 824182 -24 -0.0
bss 51064 51064 0 0.0
text 616300 616278 -22 -0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 982100 982076 -24 -0.0
bss 79108 79108 0 0.0
text 696962 696940 -22 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1096264 1096240 -24 -0.0
bss 100056 100056 0 0.0
text 772338 772316 -22 -0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 967980 967956 -24 -0.0
bss 97408 97408 0 0.0
text 650098 650076 -22 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951596 951572 -24 -0.0
bss 92564 92564 0 0.0
text 665494 665472 -22 -0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 883108 883092 -16 -0.0
bss 69136 69136 0 0.0
text 624416 624394 -22 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 823760 823736 -24 -0.0
bss 57380 57380 0 0.0
text 591340 591318 -22 -0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705844 705844 0 0.0
bss 73640 73640 0 0.0
text 462234 462234 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825942 825918 -24 -0.0
bss 51200 51200 0 0.0
text 619046 619024 -22 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 881213 881189 -24 -0.0
bss 60848 60848 0 0.0
text 633354 633332 -22 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 848468 848452 -16 -0.0
bss 57668 57668 0 0.0
text 610096 610074 -22 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 842324 842300 -24 -0.0
bss 57984 57984 0 0.0
text 603760 603738 -22 -0.0

@mergify mergify bot merged commit 9238d4b into project-chip:master Jan 22, 2024
57 checks passed
plan44 added a commit to plan44/connectedhomeip that referenced this pull request Sep 6, 2024
@plan44
[attribute storage] re-publish emberAfEndpointIsEnabled as bridge n…
7cd5117 
…eeds to be able to check enabled state

- this was made static in "9238d4b - Make attribute-storage.h API surface smaller (project-chip#31568)"
- bridge app needs to be able to check enabled state for internal consistency check when dynamically handling endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @Damian-Nordic @jmartinez-silabs @andreilitvin