Refactored mDNS Browse Interface #32866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tools
examples
platform
darwin
lib
controller
shell
protocols
labels
|
PR #32866: Size comparison from 9080cd3 to 6bb3a19 Increases (46 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, nxp, qpg, stm32, telink)
Decreases (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, stm32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
su-shanka
force-pushed
the
feature/mdns_delegate_refactor
branch
2 times, most recently
from
e1b9f7f to
4e7ede7
Compare
su-shanka
force-pushed
the
feature/mdns_delegate_refactor
branch
from
4e7ede7 to
a6049d0
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Apr 5, 2024
|
PR #32866: Size comparison from 9b9ed65 to a6049d0 Increases (45 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, linux, nrfconnect, nxp, qpg, stm32, telink)
Decreases (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, linux, mbed, nrfconnect, psoc6, stm32)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Damian-Nordic
approved these changes
Apr 9, 2024
shaoltan-amazon
pushed a commit
to shaoltan-amazon/connectedhomeip
that referenced
this pull request
Apr 10, 2024
* Refactored mDNS Browse Interface and necessary renaming done * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
| @@ -220,13 +220,13 @@ struct CommissionNodeData | |||
| char deviceName[kMaxDeviceNameLen + 1] = {}; | |||
| char pairingInstruction[kMaxPairingInstructionLen + 1] = {}; | |||
|
|
|||
| CommissionNodeData() {} | |||
| DnssdNodeData() {} | |||
There was a problem hiding this comment.
So the problem is: most of the fields of this struct are meaningless for an operational discovery, no? This struct is very much commissionee-discovery specific. So naming it general "DnssdNodeData" (but leaving the "specific to commisionable/commissioning node discovery" comment above, and having all its fields be about commissionees) does not make sense.
Also, CommonResolutionData is also "dnssd node data", but it's the data that is common to all discovery types, right?
There was a problem hiding this comment.
I missed that during the first view - my thought on the PR was that this is common data, however this clearly is not, like commissionerPasscode is clearly not an operational discovery item.
Comment on lines
322
to
327
| /// Callbacks for discovering nodes advertising non-operational status: | ||
| /// - Commissioners | ||
| /// - Nodes in commissioning modes over IP (e.g. ethernet devices, devices already | ||
| /// connected to thread/wifi or devices with a commissioning window open) | ||
| class CommissioningResolveDelegate | ||
| class DiscoverNodeDelegate | ||
| { |
There was a problem hiding this comment.
Also, the comments here no longer match the code...
There was a problem hiding this comment.
As requested this PR does not have the functional changes of operational discovery support so comment is not updated here. However, I have updated the comment for the delegate in the functional PR.
kurvaSai
pushed a commit
to SiliconLabs/matter-for-unify
that referenced
this pull request
May 29, 2024
* Refactored mDNS Browse Interface and necessary renaming done * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
su-shanka
added a commit
to SiliconLabs/matter-for-unify
that referenced
this pull request
May 30, 2024
* Refactored mDNS Browse Interface and necessary renaming done * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the existing browse/discover interface in Resolver class to a common interface for all types of node browse and made the delegates common for all browse.
This also contains renaming changes across all files where resolver interfaces are used.