-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 32957 : Matter TV: commissioner passcode flow does not accept CommissionerPasscodeReady flag #32958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
April 12, 2024 00:31
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 12, 2024 00:31
chrisdecenzo
changed the title
Fix 32957 : Matter TV: commissioner passcode flow does not accept CommissionerPasscodeReady flag
IGNORE - Fix 32957 : Matter TV: commissioner passcode flow does not accept CommissionerPasscodeReady flag
Apr 12, 2024
chrisdecenzo
changed the title
IGNORE - Fix 32957 : Matter TV: commissioner passcode flow does not accept CommissionerPasscodeReady flag
Fix 32957 : Matter TV: commissioner passcode flow does not accept CommissionerPasscodeReady flag
Apr 12, 2024
PR #32958: Size comparison from 1db304a to b5c1885 Full report (19 builds for cc13x4_26x4, cc32xx, cyw30739, mbed, nrfconnect, psoc6)
|
andy31415
reviewed
Apr 12, 2024
src/protocols/user_directed_commissioning/UserDirectedCommissioningServer.cpp
Outdated
Show resolved
Hide resolved
PR #32958: Size comparison from 1db304a to 6e9862c Full report (9 builds for cc13x4_26x4, mbed, nrfconnect)
|
sharadb-amazon
approved these changes
Apr 12, 2024
PR #32958: Size comparison from 1db304a to 4a46ba5 Increases above 0.2%:
Increases (16 builds for linux, mbed, stm32)
Decreases (14 builds for linux, mbed, nrfconnect, stm32)
Full report (19 builds for linux, mbed, nrfconnect, stm32)
|
PR #32958: Size comparison from 1db304a to d2c0375 Increases (20 builds for bl602, bl702, bl702l, cyw30739, efr32, linux, mbed, psoc6, stm32)
Decreases (42 builds for bl602, bl702, bl702l, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, stm32, telink)
Full report (48 builds for bl602, bl702, bl702l, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, stm32, telink)
|
Co-authored-by: Restyled.io <commits@restyled.io>
PR #32958: Size comparison from 1db304a to 45fccb1 Increases (1 build for mbed)
Decreases (4 builds for mbed, nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
PR #32958: Size comparison from 1db304a to 30be958 Increases above 0.2%:
Increases (9 builds for cc13x4_26x4, efr32, linux, mbed)
Decreases (13 builds for cc13x4_26x4, efr32, linux, mbed, nrfconnect)
Full report (14 builds for cc13x4_26x4, efr32, linux, mbed, nrfconnect)
|
yunhanw-google
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32957
The tv-app sample app is not handling the CommissionerPasscodeReady flag
Start tv-app:
Start tv-casting-app:
Enable commissioner passcode commissioning in casting app
tv-casting-app shell> cast setusecommissionerpasscode 1
Trigger first UDC for commissioner passcode commissioning in casting app
tv-casting-app shell> cast request 0
Accept request to cast on tv
tv-app shell> controller ux ok
Set passcode in casting app which also updates state to set the passcode ready flag
tv-casting-app shell> cast setcommissionerpasscode 12345678
Trigger second UDC for commissioner passcode commissioning in casting app, which will have the passcode ready flag
tv-casting-app shell> cast request 0