-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Convert TestICDManager to gtest #33269
Merged
mergify
merged 7 commits into
project-chip:master
from
mkardous-silabs:feature/convert_icd_manager_tests
May 4, 2024
Merged
[ICD] Convert TestICDManager to gtest #33269
mergify
merged 7 commits into
project-chip:master
from
mkardous-silabs:feature/convert_icd_manager_tests
May 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33269: Size comparison from f6b3594 to 22a9898 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
May 2, 2024
andy31415
reviewed
May 2, 2024
PR #33269: Size comparison from f6b3594 to d0c1af3 Decreases (6 builds for cc32xx, mbed, qpg, stm32)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
andy31415
approved these changes
May 2, 2024
jmartinez-silabs
approved these changes
May 2, 2024
PR #33269: Size comparison from f6b3594 to 61860b3 Increases (3 builds for bl702l, linux)
Decreases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Alami-Amine
reviewed
May 3, 2024
PR #33269: Size comparison from f6b3594 to 7bc4b27 Increases (9 builds for linux)
Decreases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goal of the PR is to convert the TestICDManager file to gtest.
PR changes :
Note to reviewers
Created
ICDConfigurationDataTestAccess
to be able to access a private method from the ICDConfigurationData class without making all tests that need API friends with it.Tests
Unit test themselves