-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add add some basic information cluster attributes to cmd line args to the reference app #33303
base: master
Are you sure you want to change the base?
add add some basic information cluster attributes to cmd line args to the reference app #33303
Conversation
chaitanya jandhyala seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
src/include/platform/internal/GenericDeviceInstanceInfoProvider.ipp
Outdated
Show resolved
Hide resolved
src/include/platform/internal/GenericDeviceInstanceInfoProvider.ipp
Outdated
Show resolved
Hide resolved
src/include/platform/internal/GenericConfigurationManagerImpl.h
Outdated
Show resolved
Hide resolved
src/include/platform/internal/GenericConfigurationManagerImpl.ipp
Outdated
Show resolved
Hide resolved
src/include/platform/internal/GenericConfigurationManagerImpl.ipp
Outdated
Show resolved
Hide resolved
PR #33303: Size comparison from f0ba374 to 736e622 Increases above 0.2%:
Increases (14 builds for linux)
Decreases (1 build for linux)
Full report (14 builds for linux)
|
src/include/platform/internal/GenericDeviceInstanceInfoProvider.ipp
Outdated
Show resolved
Hide resolved
src/include/platform/internal/GenericDeviceInstanceInfoProvider.ipp
Outdated
Show resolved
Hide resolved
if (options.vendorName.HasValue()) | ||
{ | ||
chip::Span<const char> vendor_name(options.vendorName.Value().c_str(), options.vendorName.Value().size()); | ||
VerifyOrDie(configManager.StoreVendorName(vendor_name) == CHIP_NO_ERROR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these verify or die calls, is the user going to be able to tell what went wrong? This can happen fairly easily, right? If the user enters a too-long name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify or die, throws error if the user does not provide value to cmd line arg. if the user enters too long name, it doesn't throw error, but when we read from the basic information cluster, we get IM Error 0x00000501: General error: 0x01 (FAILURE). BTW its same API used for other cmd line args.
a2fa434
to
feb127e
Compare
PR #33303: Size comparison from 47097e0 to feb127e Increases above 0.2%:
Full report (16 builds for linux)
|
7c72d86
to
cfc477f
Compare
PR #33303: Size comparison from 1919112 to cfc477f Increases above 0.2%:
Full report (28 builds for efr32, linux, nxp, qpg, telink)
|
cfc477f
to
a37f7ac
Compare
PR #33303: Size comparison from 8786012 to a37f7ac Increases above 0.2%:
Full report (62 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nxp, qpg, stm32, telink)
|
PR #33303: Size comparison from 8786012 to 4c42a96 Increases above 0.2%:
Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33303: Size comparison from 8786012 to 44fa365 Increases above 0.2%:
Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
e5dbc7c
to
7760323
Compare
PR #33303: Size comparison from 74768a8 to 7760323 Increases above 0.2%:
Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… and software_version_string to read from config in reference linux and darwin platform
…e pointer/length arguments
PR #33303: Size comparison from 24fd0d6 to c4c0e91 Full report (15 builds for cc13x4_26x4, cc32xx, nxp, qpg, stm32)
|
…nectedhomeip into serial_number_args_to_app
PR #33303: Size comparison from a7bbd7b to cea2b21 Increases above 0.2%:
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, qpg, stm32, telink, tizen)
|
… and software_version_string to read from config in reference linux and darwin platform
fixed #33302