-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux tv-casting-app v1.3 Commissioner-Generated passcode follow up #33525
Linux tv-casting-app v1.3 Commissioner-Generated passcode follow up #33525
Conversation
PR #33525: Size comparison from 6bd80b0 to 85788c7 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
PR #33525: Size comparison from 6bd80b0 to 4918b5e Increases above 0.2%:
Increases (1 build for stm32)
Decreases (1 build for stm32)
Full report (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #33525: Size comparison from 6bd80b0 to 996ddae Increases above 0.2%:
Increases (1 build for stm32)
Decreases (2 builds for efr32, stm32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as general readability - I am not familiar with the implementation details of the casting code.
Head branch was pushed to by a user without write access
996ddae
to
9dac379
Compare
PR #33525: Size comparison from eb515e1 to 9dac379 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Linux tv-casting-app example app, addressed post merge comments on PR 33479 and changed the CastingPlayer endpoint for demo interactions.
Change summary
Testing
Verified and tested locally with the Linux, Android and iOS tv-casting-app example mobile apps, and the Linux tv-app (CastingPlayer). With the Linux example tv-casting-app app, we are able to successfully commission using the commissioner generated passcode flow as follows: