Feature/enhanced setup flow feature #34065
Open
+1,419
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
|
|
||
| if (CHIP_NO_ERROR == LoadAcceptance(mLatchedAcceptance)) | ||
| { | ||
| mTemporalAcceptance.SetValue(mLatchedAcceptance.Value()); |
There was a problem hiding this comment.
Why is the temporary one needed to be set on load?
There was a problem hiding this comment.
BTW suggest logging on failure to load, to understand whether it's missing or bad version/fornat.
| if (!mRequiredAcknowledgements.HasValue()) | ||
| { | ||
| outState = TermsAndConditionsState::OK; | ||
| return CHIP_NO_ERROR; |
There was a problem hiding this comment.
Since this always returns CHIP_NO_ERROR, why not simply return a TermsAndConditionsState rather than requiring a CHIP_ERROR check and then an output variable check?
Comment on lines
302
to
315
| if (CHIP_NO_ERROR != err) | ||
| { | ||
| // | ||
| } |
There was a problem hiding this comment.
Why this empty block?
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
hiroto-kanda
reviewed
Sep 6, 2024
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
tcarmelveilleux
dismissed
robszewczyk’s stale review
Currently being reviewed by tcarmelveilleux
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
6813e2f
to
a51e3ef
Compare
|
PR #34065: Size comparison from e96ddd9 to a51e3ef Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
xshuqun
reviewed
Sep 10, 2024
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
a51e3ef
to
cfac90b
Compare
|
PR #34065: Size comparison from b1829ff to cfac90b Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
cfac90b
to
c9ecc20
Compare
|
PR #34065: Size comparison from 16e4e9b to c9ecc20 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
c9ecc20
to
ec5ebbb
Compare
|
PR #34065: Size comparison from b0f5275 to ec5ebbb Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
ec5ebbb
to
21e867a
Compare
|
PR #34065: Size comparison from dfb01fb to 21e867a Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
21e867a
to
896a9d8
Compare
|
PR #34065: Size comparison from 9c6c365 to 896a9d8 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
896a9d8
to
158a29b
Compare
|
PR #34065: Size comparison from 4ec1716 to 158a29b Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This commit introduces the initial logic for handling Terms and Conditions (TC) acknowledgements in the General Commissioning cluster. The logic includes support for setting and checking TC acknowledgements and versions during the commissioning process. Changes include: - Handling TC acknowledgements and TC acknowledgement version in the pairing command. - Logic to read TC attributes and check TC acceptance in the General Commissioning server. - Introduction of classes to manage TC acceptance logic. - Initialization and use of TC providers in the server setup. - Addition of a new commissioning stage for TC acknowledgements in the commissioning flow. The feature logic is currently disabled and will be enabled in an example in a subsequent commit.
swan-amazon
force-pushed
the
feature/enhanced-setup-flow-feature
branch
from
158a29b
to
6b1115e
Compare
|
PR #34065: Size comparison from 43e447c to 6b1115e Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Terms and Conditions Acknowledgements in Commissioning Process
Fixes #34064
Add support for setting Terms and Conditions acknowledgements
acknowledgment version in the General Commissioning cluster.
acknowledgements.
Enhance setup flow handling
Conditions acknowledgements.
Conditions acknowledgements.
Handle setting Terms and Conditions acknowledgements
commissioning process.
Zap regen