Split the targets for nullable support #34198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tcarmelveilleux
commented
Jul 4, 2024
tcarmelveilleux
commented
- Fixes a prior circular dependency on nullable scalar traits
- Allows portable code to only depend on the nullable support without needing to also include any code-generated artifacts
- Fixes a prior circular dependency on nullable scalar traits - Allows portable code to only depend on the nullable support without needing to also include any code-generated artifacts
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
reviewed
Jul 4, 2024
andy31415
reviewed
Jul 4, 2024
andy31415
approved these changes
Jul 4, 2024
|
PR #34198: Size comparison from 896d771 to aec9d3c Full report (6 builds for esp32, mbed, nrfconnect)
|
|
PR #34198: Size comparison from 896d771 to 9af9b6c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
github-actions
bot
added
documentation
|
PR #34198: Size comparison from 896d771 to 6d4871d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 5, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
* Split the targets for nullable support - Fixes a prior circular dependency on nullable scalar traits - Allows portable code to only depend on the nullable support without needing to also include any code-generated artifacts * Restyled by gn * Address review comments * Apply review comments * Fix dependency on tests * Fix OpenIOT SDK unit tests --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.