Fixing crashes when comparing objects to nil #34321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiel-apple
approved these changes
Jul 12, 2024
|
PR #34321: Size comparison from 707e431 to 0d29207 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 15, 2024
* Fixing nil check crashes * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Comment on lines
+2369
to
+2374
| if (!path) | ||
| return NO; | ||
|
|
||
| return (path.endpoint && [_endpoint isEqualToNumber:path.endpoint]) | ||
| && (path.cluster && [_cluster isEqualToNumber:path.cluster]) | ||
| && (path.event && [_event isEqualToNumber:path.event]); |
There was a problem hiding this comment.
Same comments as for attribute request paths.
woody-apple
added a commit
that referenced
this pull request
Jul 17, 2024
This reverts commit 2d789f4.
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
* Fixing nil check crashes * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Aug 14, 2024
* Fixing nil check crashes * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Sep 16, 2024
* Fixing nil check crashes * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nil checks are good :)