Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements the Commissioner Control Cluster in Matter SDK #34375

Merged
merged 14 commits into from
Jul 26, 2024
Merged

Implements the Commissioner Control Cluster in Matter SDK #34375

merged 14 commits into from
Jul 26, 2024

Conversation

yufengwangca
Copy link
Contributor

Implements https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/9089

This PR contains the implementation of the Commissioner Control Cluster server itself. The actual usage of this cluster across multiple example applications (Fabric Admin and Fabric Bridge), will be addressed in a follow-up PR.

Fixes #33222

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

PR #34375: Size comparison from a30dd12 to d8d794d

Increases above 0.2%:

platform target config section a30dd12 d8d794d change % change
linux fabric-bridge-app debug FLASH 4247344 4256896 9552 0.2
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a30dd12 d8d794d change % change
bl602 lighting-app bl602 FLASH 1271504 1271504 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1286018 1286018 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310720 1310720 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092614 1092614 0 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1103308 1103308 0 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1182424 1182424 0 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 875744 875744 0 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1128170 1128170 0 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1079500 1079500 0 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1090762 1090762 0 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798604 798604 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816572 816572 0 0.0
RAM 116948 116948 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808260 808260 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760940 760940 0 0.0
RAM 105328 105328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746652 746652 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606482 606482 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651806 651806 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667713 667713 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644509 644509 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609329 609329 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625057 625057 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593429 593429 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924668 924660 -8 -0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 733916 733908 -8 -0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012700 1012692 -8 -0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90860 90860 0 0.0
FLASH 1470728 1470728 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117340 117340 0 0.0
FLASH 1539579 1539579 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2531376 2531376 0 0.0
RAM 125112 125112 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5592478 5592478 0 0.0
RAM 493240 493240 0 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5065568 5065568 0 0.0
RAM 235704 235704 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4479776 4479776 0 0.0
RAM 212832 212832 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11797879 11797879 0 0.0
RAM 547618 547618 0 0.0
chip-tool-ipv6only arm64 unknown 20128 20128 0 0.0
FLASH 10908108 10908108 0 0.0
RAM 596616 596616 0 0.0
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10877607 10877607 0 0.0
RAM 544394 544394 0 0.0
fabric-bridge-app debug unknown 4544 4544 0 0.0
FLASH 4247344 4256896 9552 0.2
RAM 198872 199064 192 0.1
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5384162 5384162 0 0.0
RAM 224136 224136 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4546128 4546128 0 0.0
RAM 200456 200456 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4199216 4199216 0 0.0
RAM 194544 194544 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4324544 4324544 0 0.0
RAM 199168 199168 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2805869 2805869 0 0.0
RAM 153008 153008 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4169772 4169772 0 0.0
RAM 235840 235840 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5627776 5627776 0 0.0
RAM 342120 342120 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9967950 9967950 0 0.0
RAM 402936 402936 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1502972 0 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882696 882696 0 0.0
RAM 142229 142229 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953128 953128 0 0.0
RAM 140657 140657 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828172 828172 0 0.0
RAM 141123 141123 0 0.0
nxp contact k32w0+release FLASH 576164 576164 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591568 591568 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610408 610408 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 675192 675192 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1615620 1615620 0 0.0
RAM 209692 209692 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536508 1536508 0 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463108 0 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463868 1463868 0 0.0
RAM 224388 224388 0 0.0
qpg lighting-app qpg6105+debug FLASH 651460 651460 0 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 611992 611992 0 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473784 473784 0 0.0
RAM 144196 144196 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632984 632984 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658842 658842 0 0.0
RAM 148408 148408 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779144 779144 0 0.0
RAM 113212 113212 0 0.0
bridge-app tlsr9258a FLASH 675976 675976 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634568 634568 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720428 720428 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613948 613948 0 0.0
RAM 144636 144636 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801730 801730 0 0.0
RAM 103040 103040 0 0.0
lock-app-dfu tlsr9528a FLASH 666384 666384 0 0.0
RAM 69852 69852 0 0.0
ota-requestor-app tlsr9258a FLASH 695308 695308 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616842 616842 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607226 607226 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466356 466356 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641186 641186 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651052 651052 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 626116 626116 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 519342 519342 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1639396 1639396 0 0.0
RAM 48548 48548 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16293278 16293278 0 0.0
RAM 7156300 7156300 0 0.0

@github-actions GitHub Actions
Copy link

PR #34375: Size comparison from c7659cb to 2970c78

Full report (4 builds for cc32xx, mbed, stm32)
platform target config section c7659cb 2970c78 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606634 606490 -144 -0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651974 651830 -144 -0.0
RAM 204780 204780 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503164 1502972 -192 -0.0
RAM 226648 226648 0 0.0
stm32 light STM32WB5MM-DK FLASH 473960 473776 -184 -0.0
RAM 144196 144196 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

PR #34375: Size comparison from 3418614 to 4fa28cd

Increases above 0.2%:

platform target config section 3418614 4fa28cd change % change
linux fabric-bridge-app debug FLASH 4363580 4373370 9790 0.2
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 3418614 4fa28cd change % change
bl602 lighting-app bl602 FLASH 1271432 1271432 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1285690 1285690 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310648 1310648 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092284 1092284 0 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1103234 1103234 0 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1182350 1182350 0 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 875672 875672 0 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1127848 1127848 0 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1079426 1079426 0 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1090688 1090688 0 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798588 798588 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816396 816396 0 0.0
RAM 116948 116948 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808244 808244 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760940 760940 0 0.0
RAM 105328 105328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746636 746636 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606490 606490 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651830 651830 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667769 667769 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687621 687621 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687621 687621 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644557 644557 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609377 609377 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629005 629005 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629005 629005 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625097 625097 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644805 644805 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644805 644805 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593469 593469 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613313 613313 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613313 613313 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924668 924660 -8 -0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 733916 733908 -8 -0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012692 1012692 0 0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90924 90924 0 0.0
FLASH 1471138 1471138 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117404 0 0.0
FLASH 1540087 1540087 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2628179 2628179 0 0.0
RAM 124496 124496 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5761200 5761200 0 0.0
RAM 493984 493984 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5219084 5219084 0 0.0
RAM 234992 234992 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4615816 4615816 0 0.0
RAM 212256 212256 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12220814 12220814 0 0.0
RAM 548018 548018 0 0.0
chip-tool-ipv6only arm64 unknown 20144 20144 0 0.0
FLASH 10916332 10916332 0 0.0
RAM 597872 597872 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11233855 11233855 0 0.0
RAM 544858 544858 0 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4363580 4373370 9790 0.2
RAM 198272 198496 224 0.1
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5540161 5540161 0 0.0
RAM 223520 223520 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4674762 4674762 0 0.0
RAM 199952 199952 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4316790 4316790 0 0.0
RAM 194128 194128 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4455408 4455408 0 0.0
RAM 198680 198680 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2905069 2905069 0 0.0
RAM 152920 152920 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4170060 4170060 0 0.0
RAM 235840 235840 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5816799 5816799 0 0.0
RAM 341360 341360 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10361805 10361805 0 0.0
RAM 402232 402232 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1502972 0 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883084 883084 0 0.0
RAM 142259 142259 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953360 953360 0 0.0
RAM 140687 140687 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828144 828144 0 0.0
RAM 141123 141123 0 0.0
nxp contact k32w0+release FLASH 575972 575972 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591544 591544 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610352 610352 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 675176 675176 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1615996 1615996 0 0.0
RAM 209764 209764 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536500 1536500 0 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463108 0 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463860 1463860 0 0.0
RAM 224388 224388 0 0.0
qpg lighting-app qpg6105+debug FLASH 651460 651460 0 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 611976 611976 0 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473776 473776 0 0.0
RAM 144196 144196 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632974 632974 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658862 658862 0 0.0
RAM 148436 148436 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779134 779134 0 0.0
RAM 113212 113212 0 0.0
bridge-app tlsr9258a FLASH 675966 675966 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634558 634558 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720418 720418 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613938 613938 0 0.0
RAM 144636 144636 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801720 801720 0 0.0
RAM 103040 103040 0 0.0
lock-app-dfu tlsr9528a FLASH 666374 666374 0 0.0
RAM 69852 69852 0 0.0
ota-requestor-app tlsr9258a FLASH 695298 695298 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616832 616832 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607216 607216 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466466 466466 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641176 641176 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651042 651042 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 626106 626106 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 519332 519332 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1640004 1640004 0 0.0
RAM 48620 48620 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16308990 16308990 0 0.0
RAM 7161784 7161784 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

PR #34375: Size comparison from c024e4f to 10a55bb

Increases above 0.2%:

platform target config section c024e4f 10a55bb change % change
linux fabric-bridge-app debug FLASH 4363704 4372532 8828 0.2
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c024e4f 10a55bb change % change
bl602 lighting-app bl602 FLASH 1271432 1271432 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1285690 1285690 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310648 1310648 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092338 1092338 0 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1103288 1103288 0 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1182404 1182404 0 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 875672 875672 0 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1127848 1127848 0 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1079480 1079480 0 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1090742 1090742 0 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798620 798620 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816428 816428 0 0.0
RAM 116948 116948 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808276 808276 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760972 760972 0 0.0
RAM 105328 105328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746676 746676 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606490 606490 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651830 651830 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667801 667801 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687653 687653 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687653 687653 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644597 644597 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609409 609409 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629045 629045 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629045 629045 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625137 625137 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644845 644845 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644845 644845 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593509 593509 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613353 613353 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613353 613353 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924668 924660 -8 -0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 733916 733908 -8 -0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012724 1012724 0 0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90924 90924 0 0.0
FLASH 1471138 1471138 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117404 0 0.0
FLASH 1540099 1540099 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2628303 2628303 0 0.0
RAM 124496 124496 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5761324 5761324 0 0.0
RAM 493920 493920 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5219208 5219208 0 0.0
RAM 234992 234992 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4615940 4615940 0 0.0
RAM 212256 212256 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12220054 12220054 0 0.0
RAM 548018 548018 0 0.0
chip-tool-ipv6only arm64 unknown 20136 20136 0 0.0
FLASH 10934844 10934844 0 0.0
RAM 597928 597928 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11232675 11232675 0 0.0
RAM 544858 544858 0 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4363704 4372532 8828 0.2
RAM 198272 198496 224 0.1
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5540273 5540273 0 0.0
RAM 223520 223520 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4674762 4674762 0 0.0
RAM 199952 199952 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4316914 4316914 0 0.0
RAM 194128 194128 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4455564 4455564 0 0.0
RAM 198680 198680 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2905197 2905197 0 0.0
RAM 152920 152920 0 0.0
thermostat-no-ble arm64 unknown 9176 9176 0 0.0
FLASH 4186284 4186284 0 0.0
RAM 235936 235936 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5816927 5816927 0 0.0
RAM 341360 341360 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10360973 10360973 0 0.0
RAM 402232 402232 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1502972 0 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883084 883084 0 0.0
RAM 142259 142259 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953360 953360 0 0.0
RAM 140687 140687 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828144 828144 0 0.0
RAM 141123 141123 0 0.0
nxp contact k32w0+release FLASH 575972 575972 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591544 591544 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610352 610352 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 675176 675176 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1615996 1615996 0 0.0
RAM 209764 209764 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536500 1536500 0 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463108 0 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463860 1463860 0 0.0
RAM 224388 224388 0 0.0
qpg lighting-app qpg6105+debug FLASH 651492 651492 0 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 612008 612008 0 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473808 473808 0 0.0
RAM 144196 144196 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632974 632974 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658862 658862 0 0.0
RAM 148436 148436 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779134 779134 0 0.0
RAM 113212 113212 0 0.0
bridge-app tlsr9258a FLASH 675966 675966 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634558 634558 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720418 720418 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613938 613938 0 0.0
RAM 144636 144636 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801720 801720 0 0.0
RAM 103040 103040 0 0.0
lock-app-dfu tlsr9528a FLASH 666374 666374 0 0.0
RAM 69852 69852 0 0.0
ota-requestor-app tlsr9258a FLASH 695298 695298 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616832 616832 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607216 607216 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466518 466518 0 0.0
RAM 72488 72488 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641176 641176 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651042 651042 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 626106 626106 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 519332 519332 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1640060 1640060 0 0.0
RAM 48620 48620 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16295166 16295166 0 0.0
RAM 7161492 7161492 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

PR #34375: Size comparison from d62f5a6 to d96cfbc

Increases above 0.2%:

platform target config section d62f5a6 d96cfbc change % change
linux fabric-bridge-app debug FLASH 4363704 4373152 9448 0.2
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section d62f5a6 d96cfbc change % change
bl602 lighting-app bl602 FLASH 1271470 1271470 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1285728 1285728 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310686 1310686 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092376 1092376 0 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1103326 1103326 0 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1182442 1182442 0 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 875672 875672 0 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1127888 1127888 0 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1079518 1079518 0 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1090780 1090780 0 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798692 798692 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816508 816508 0 0.0
RAM 116948 116948 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808356 808356 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761052 761052 0 0.0
RAM 105328 105328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746756 746756 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606490 606490 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651830 651830 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667817 667817 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687669 687669 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687669 687669 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644605 644605 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609425 609425 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629053 629053 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629053 629053 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625145 625145 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644853 644853 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644853 644853 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593517 593517 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613361 613361 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613361 613361 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924656 924656 0 0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 734020 734012 -8 -0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012756 1012748 -8 -0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90924 90924 0 0.0
FLASH 1471198 1471198 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117404 0 0.0
FLASH 1540159 1540159 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2628447 2628447 0 0.0
RAM 124496 124496 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5761468 5761468 0 0.0
RAM 493984 493984 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5219352 5219352 0 0.0
RAM 234992 234992 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4616084 4616084 0 0.0
RAM 212256 212256 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12220198 12220198 0 0.0
RAM 548018 548018 0 0.0
chip-tool-ipv6only arm64 unknown 20136 20136 0 0.0
FLASH 10934668 10934668 0 0.0
RAM 598048 598048 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11232819 11232819 0 0.0
RAM 544858 544858 0 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4363704 4373152 9448 0.2
RAM 198272 198496 224 0.1
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5540417 5540417 0 0.0
RAM 223520 223520 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4674906 4674906 0 0.0
RAM 199952 199952 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4316914 4316914 0 0.0
RAM 194128 194128 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4455564 4455564 0 0.0
RAM 198680 198680 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2905341 2905341 0 0.0
RAM 152984 152984 0 0.0
thermostat-no-ble arm64 unknown 9176 9176 0 0.0
FLASH 4186284 4186284 0 0.0
RAM 235936 235936 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5817071 5817071 0 0.0
RAM 341360 341360 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10361117 10361117 0 0.0
RAM 402232 402232 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503156 1503156 0 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883128 883128 0 0.0
RAM 142263 142263 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953380 953380 0 0.0
RAM 140691 140691 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828144 828144 0 0.0
RAM 141123 141123 0 0.0
nxp contact k32w0+release FLASH 575956 575956 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591536 591536 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610336 610336 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 675168 675168 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1616084 1616084 0 0.0
RAM 209764 209764 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536540 1536540 0 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463140 1463140 0 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463892 1463892 0 0.0
RAM 224388 224388 0 0.0
qpg lighting-app qpg6105+debug FLASH 651500 651500 0 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 612016 612016 0 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473888 473888 0 0.0
RAM 144196 144196 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632962 632962 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658850 658850 0 0.0
RAM 148440 148440 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779122 779122 0 0.0
RAM 113212 113212 0 0.0
bridge-app tlsr9258a FLASH 675954 675954 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634546 634546 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720406 720406 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613926 613926 0 0.0
RAM 144636 144636 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801708 801708 0 0.0
RAM 103040 103040 0 0.0
lock-app-dfu tlsr9528a FLASH 666362 666362 0 0.0
RAM 69852 69852 0 0.0
ota-requestor-app tlsr9258a FLASH 695286 695286 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616820 616820 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607204 607204 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466518 466518 0 0.0
RAM 72488 72488 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641164 641164 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651030 651030 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 626094 626094 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 519320 519320 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1640396 1640396 0 0.0
RAM 48620 48620 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16295718 16295718 0 0.0
RAM 7161652 7161652 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Jul 25, 2024
View reviewed changes
src/app/clusters/commissioner-control-server/commissioner-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.h Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.h Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.h Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/commissioner-control-server/commissioner-control-server.h Show resolved Hide resolved
@tehampson tehampson enabled auto-merge (squash) July 26, 2024 03:24
@tehampson tehampson merged commit 7d26280 into project-chip:master Jul 26, 2024
69 checks passed
@yufengwangca yufengwangca deleted the pr/cluster/commissioner branch July 26, 2024 11:43
arkq
arkq reviewed Jul 26, 2024
View reviewed changes
examples/fabric-bridge-app/fabric-bridge-common/fabric-bridge-app.matter
@@ -1647,6 +1698,21 @@ endpoint 0 {
handle command KeySetReadAllIndices;
handle command KeySetReadAllIndicesResponse;
}

server cluster CommissionerControl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tehampson Is that OK, that the CommissionerControl is on endpoint 0? In the spec, the CommissionerControl should be on Aggregator endpoint, which is endpoint 1 here.

j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
@yufengwangca @tehampson
@bzbarsky-apple @restyled-commits @j-ororke
Implements the Commissioner Control Cluster in Matter SDK (project-ch…
1eecb25 
…ip#34375)


Co-authored-by: Terence Hampson <thampson@google.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Jul 31, 2024
@yufengwangca @tehampson
@bzbarsky-apple @restyled-commits @rochaferraz
Implements the Commissioner Control Cluster in Matter SDK (project-ch…
d9557cf 
…ip#34375)


Co-authored-by: Terence Hampson <thampson@google.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq left review comments

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tehampson tehampson tehampson approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Implements the Commissioner Control Cluster in Matter SDK
6 participants
@yufengwangca @tcarmelveilleux @arkq @tehampson @bzbarsky-apple @restyled-commits