Fix Darwin build for missing mDNS impl #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
sagar-apple
approved these changes
Oct 26, 2020
bzbarsky-apple
approved these changes
Oct 26, 2020
|
Build breakage => hotfix. @pan-apple please make sure there's an issue filed tracking Darwin mDNS implementation. |
Added this comment to an existing issue: #3121 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIP doesn't build on
macOS.Summary of Changes
Darwinplatform manager is dependent on POSIX. Recently,mDNSwas added for POSIX, but it doesn't work for Darwin platform. There's a conditional preprocessor, that enables themDNSin this file. The code is unconditionally including some headers, which is causing build issues.For now, this change puts the header inclusion in the same conditional checks. This fixes the immediate build issue. Eventually, we need to add
mDNSimplementation for Darwin target.Fixes #3437