-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One more decouple from ember from src/app and ensure we can compile without ember-compatibility-functions.cpp
#35919
Merged
mergify
merged 13 commits into
project-chip:master
from
andy31415:no_compat_functions_on_data_model_interface
Oct 8, 2024
Merged
One more decouple from ember from src/app and ensure we can compile without ember-compatibility-functions.cpp
#35919
mergify
merged 13 commits into
project-chip:master
from
andy31415:no_compat_functions_on_data_model_interface
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
pullapprove
bot
added
review - pending
app
github
workflows
and removed
app
github
workflows
labels
Oct 4, 2024
PR #35919: Size comparison from 86a5270 to f481739 Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35919: Size comparison from 86a5270 to 6950b7c Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Oct 5, 2024
PR #35919: Size comparison from 86a5270 to 96f9e52 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 7, 2024
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
tcarmelveilleux
approved these changes
Oct 7, 2024
PR #35919: Size comparison from 86a5270 to e17f4d5 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final decouple step so that
ember-compatibility-functions.cpp
is not needed as part of data models.Changes
pump-configuration-and-control-server.cpp
that we have to figure out for full support like all-clusters app, I will do that as a followup)