Initial implemention of a push av server #36004
Draft
+971
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 4 of 8 files.
|
|
|
github-actions
bot
added
tools
tests
matter-1.4-te2-script-change
|
PR #36004: Size comparison from a7bbd7b to 2bc6170 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Comment on lines
+40
to
+62
| -f mp4 \ | ||
| -frag_duration "$((1 * 1000 * 1000))" \ | ||
| -min_frag_duration "$((1 * 1000 * 1000))" \ | ||
| -write_prft wallclock \ | ||
| -use_editlist 0 \ | ||
| -movflags "+cmaf+dash+delay_moov+skip_sidx+skip_trailer+frag_custom" \ | ||
| \ | ||
| -method PUT \ | ||
| -multiple_requests 1 \ | ||
| -chunked_post 1 \ | ||
| -send_expect_100 1 \ | ||
| -headers "DASH-IF-Ingest: 1.1" \ | ||
| -headers "Host: localhost:8080" \ | ||
| -content_type "" \ | ||
| -icy 0 \ | ||
| -rw_timeout "$((200 * 1000 * 1000))" \ | ||
| -reconnect 1 \ | ||
| -reconnect_at_eof 1 \ | ||
| -reconnect_on_network_error 1 \ | ||
| -reconnect_on_http_error 4xx,5xx \ | ||
| -reconnect_delay_max 2 \ | ||
| -http_opts $HTTP_OPTS \ | ||
| "$PUBLISHING_ENDPOINT/cmaf/example.str/Switching(video)/video-720p.cmfv" \ |
There was a problem hiding this comment.
From the looks of this, this is generating non multiplexed tracks, aka video and audio are in seperate files instead of interleaved m4s / mp4 content.
There was a problem hiding this comment.
Indeed. I missed the "All content SHALL be sent as a single stream and track." section of the Matter spec and was basing that example of off the DASH Ingest one, which I think do not limit the number of files. Will modify the script to generate one stream instead.
A question that comes to me from having only one stream, do we want to have the ecosystem provide the complete url as opposed to only the base? That may simplify the implementation on the ecosystem implementation, but would also restrict the spec if we want to expand it to include multiple streams in the future.
There was a problem hiding this comment.
Based on my understanding of the DASH spec we are asking the ecosystem to provide the base URL and the camera then only appends the track name (always fixed since we are a single track) and segment number and file extension onto that to form the complete URL.
Right now the interleaved vs separate tracks is an enum in the spec that only defines interleaved (single track), so we have the ability to change in the future if we want.
gmarcosb
added
cameras
and removed
matter-1.4-te2-script-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push AV Server implementation for cameras. This PR is currently a draft to gather early feedback from the camera tiger team. It is not intended to be merged as part of the Matter 1.4 release.
This PR introduce a new tool (
src/tools/push_av_server/server.py) that offer a web server to test the PUSH AV Transport cluster. The tool also manage TLS certificates for both the server itself as well as the cameras uploading to it. The server can be interacted with via HTTP calls when used as a standalone tool (work on a UI is in progress) or via python functions when used as a module (mostly targeting the test harness).Note that test harness integration is mostly a work in progress at this point. The added test file in this PR is only intended as a guide (as well as to provide information onto how the tool can be used in that context) to help develop correct APIs and is not intended to be merged as part of this PR.
The web server provide few checks in term of validation for the ingested media. The idea is to have a server permissive enough that record as much information as possible, and then rely on the actual test to validate that the camera is working as it should.