FanControl: modify percentSetting/percentSpeedSetting return value in case NULL is written (match spec) #36242
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36242: Size comparison from f1457a2 to feb6883 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36242: Size comparison from f1457a2 to d2220b3 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
changed the title
andy31415
changed the title
| @@ -198,7 +198,7 @@ MatterFanControlClusterServerPreAttributeChangedCallback(const ConcreteAttribute | |||
| } | |||
| else | |||
| { | |||
| res = Status::WriteIgnored; | |||
| res = Status::InvalidInState; | |||
There was a problem hiding this comment.
We apparently have no test coverage, since nothing started failing.
Please add a basic YAML test that exercises this.
There was a problem hiding this comment.
I've modified the "TestFanControl.yaml" file to include coverage for this particular case.
|
PR #36242: Size comparison from f1457a2 to 7ff9f2e Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36242: Size comparison from ebfd212 to 5444b69 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the spec, in fan-control cluster, when
NULLis written topercentSettingattribute orspeedSettingattribute by client, it should return INVALID_IN_STATE. But currently WRITE_IGNORED is being returned.The return value in these 2 cases is corrected in this PR.