[ICD] Shutdown icd client storage when destroying android controller #36348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36348: Size comparison from 744f45c to 92b67c7 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
drempelg
approved these changes
Nov 4, 2024
|
PR #36348: Size comparison from 62a4a97 to f43c4ce Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, stm32, telink, tizen)
|
arkq
approved these changes
Nov 5, 2024
yunhanw-google
force-pushed
the
feature/issue_36346
branch
from
f43c4ce
to
bfae9cc
Compare
bzbarsky-apple
approved these changes
Nov 5, 2024
bzbarsky-apple
requested changes
Nov 5, 2024
|
PR #36348: Size comparison from 5158c55 to b2110e3 Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32)
|
|
PR #36348: Size comparison from 5158c55 to f2ea524 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
force-pushed
the
feature/issue_36346
branch
from
f2ea524
to
80a12f6
Compare
|
PR #36348: Size comparison from d6b098b to 80a12f6 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
force-pushed
the
feature/issue_36346
branch
3 times, most recently
from
f9a80bb
to
6e84a78
Compare
yunhanw-google
force-pushed
the
feature/issue_36346
branch
from
27a22de
to
53a7cbf
Compare
yunhanw-google
changed the title
|
PR #36348: Size comparison from dfd3749 to 53a7cbf Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Nov 13, 2024
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #36348: Size comparison from dfd3749 to 09f32d4 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Nov 13, 2024
…roject-chip#36348) * Shutdown DefautICDClientStorage when destorying Android controller * Restyled by whitespace * Update DefaultICDClientStorage.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In android controller , DefaultICDClientStorage has been handled as static instance, which is reused across multiple controllers, without this PR, it would crash when second controller reinitialize the ICDClientStorage
In order to resolve this issue, we need shutdown icd client storage when destroying android controller
fixes: #36346