[Fabric-Admin] Set remote bridge after reverse pair the bridge device #36451
+90
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yufengwangca
force-pushed
the
pr/fa/reverse
branch
from
2142d91
to
43d4602
Compare
|
PR #36451: Size comparison from c3b35eb to 43d4602 Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fa/reverse
branch
from
43d4602
to
37c9f01
Compare
|
PR #36451: Size comparison from c3b35eb to 37c9f01 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fa/reverse
branch
from
37c9f01
to
ceb3042
Compare
|
PR #36451: Size comparison from f10e90f to ceb3042 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fa/reverse
branch
from
ceb3042
to
e67188b
Compare
|
PR #36451: Size comparison from b825bb3 to e67188b Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36451: Size comparison from b825bb3 to bf17cef Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Nov 12, 2024
tehampson
reviewed
Nov 12, 2024
|
PR #36451: Size comparison from 57489d1 to dd08b56 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #36451: Size comparison from 57489d1 to 217bda9 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Nov 15, 2024
|
PR #36451: Size comparison from 57489d1 to e13bfed Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After complete fabric sync setup process from E1 to E2, we not only need to setup the remote fabric bridge in E1, but also need to setup the remote bridge in E2. Otherwise, we can only sync device from E2 to E1, not the other direction.
I don't think we have test case cover this scenario right now, that is why it is not found. #36450 to track this