-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zap_cluster_rev: Add tool to bump cluster revisions on Zap files #36456
Open
soares-sergio
wants to merge
5
commits into
project-chip:master
Choose a base branch
from
soares-sergio:cluster_version_bumper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
zap_cluster_rev: Add tool to bump cluster revisions on Zap files #36456
soares-sergio
wants to merge
5
commits into
project-chip:master
from
soares-sergio:cluster_version_bumper
+175
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
PR #36456: Size comparison from c3b35eb to 53d4c18 Full report (3 builds for cc32xx, stm32)
|
PR #36456: Size comparison from c3b35eb to ab056da Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 12, 2024
save_zap(body, zap_filename) | ||
|
||
# If it's printing only, return the number of outdated clusters, so it can be used as a test | ||
if (args.print_only): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (args.print_only): | |
if args.print_only: |
andy31415
reviewed
Nov 12, 2024
outdated_count += len(outdated_clusters) | ||
print(*outdated_clusters, sep='\n') | ||
|
||
if (args.print_only): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (args.print_only): | |
if args.print_only: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tool that process ZAP files, checks and bumps the cluster revisions to the latest according to the spec.
See README.md for more details.