[scripts] Add core.symlinks=true to submodules init #36498
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
github-actions
bot
added
documentation
|
Seems there's an issue with my baseline. Fixing it. |
marius-alex-tache
force-pushed
the
update-checkout-submodules-script-symlinks
branch
from
5c822c9
to
94113d6
Compare
|
PR #36498: Size comparison from 9a68d62 to c964582 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
scripts/checkout_submodules.py
Outdated
| if core_symlinks == 'false': | ||
| symlinks_cmd = ['git', 'config', '--global', 'core.symlinks'] | ||
| subprocess.check_call(symlinks_cmd + ['true']) | ||
|
|
||
| cmd = ['git', '-C', CHIP_ROOT, 'submodule', '--quiet', 'update', '--init'] |
There was a problem hiding this comment.
This can be simplified by adding -c, core.symlinks=true in the update command.
On Windows, symlinks in submodules are detected as simple text files. Adding this option to the git submodule command correctly detects the symlinks. Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
marius-alex-tache
force-pushed
the
update-checkout-submodules-script-symlinks
branch
from
c964582
to
261fa63
Compare
marius-alex-tache
changed the title
|
PR #36498: Size comparison from acea464 to 261fa63 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Nov 14, 2024
yufengwangca
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, symlinks in submodules are detected as simple text files. Adding this option to the git submodule command correctly detects the symlinks.