-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds SubscriptionInfoProvider API to check if a given fabric has at least 1 subscription #36627
Merged
mkardous-silabs
merged 6 commits into
project-chip:master
from
mkardous-silabs:feature/fabric_sub_check
Nov 27, 2024
Merged
Adds SubscriptionInfoProvider API to check if a given fabric has at least 1 subscription #36627
mkardous-silabs
merged 6 commits into
project-chip:master
from
mkardous-silabs:feature/fabric_sub_check
Nov 27, 2024
+156
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #36627: Size comparison from 9d60489 to ef6c112 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36627: Size comparison from 9d60489 to 92b3ec4 Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, telink, tizen)
|
PR #36627: Size comparison from 9d60489 to 910403d Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
force-pushed
the
feature/fabric_sub_check
branch
from
November 25, 2024 12:39
910403d
to
ef6c112
Compare
mkardous-silabs
force-pushed
the
feature/fabric_sub_check
branch
from
November 26, 2024 21:25
ef6c112
to
925ec22
Compare
PR #36627: Size comparison from ffbc362 to 925ec22 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Nov 26, 2024
PR #36627: Size comparison from ffbc362 to 02bcd1b Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
rcasallas-silabs
approved these changes
Nov 27, 2024
lpbeliveau-silabs
approved these changes
Nov 27, 2024
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
PR #36627: Size comparison from ffbc362 to 9a2f94d Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…east 1 subscription (project-chip#36627) * [SL-UP] Add fabric subscription check to the interaction model engine (project-chip#117) * Remove unwanted change * Restyle * Improve readability * Restyled by clang-format * Update src/app/SubscriptionsInfoProvider.h Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds an API that validates that a given fabric has at least on active subscription.
This can be used in application level logic to help decision talking around that state of a given fabric.
Note to reviewers
The change to the examples linux build.gn was to fix a Nordic Zephyr CI which was complaining about unresolved dependencies.
Tests
Added unit tests that validate the multi fabric and the single fabric cases