Add some additional dataModelProvider settings on server init
#36639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36639: Size comparison from 0ac52eb to 27cdc0f Increases above 0.2%:
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36639: Size comparison from 0ac52eb to 7457fdf Increases above 0.2%:
Full report (16 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
tcarmelveilleux
approved these changes
Nov 26, 2024
|
PR #36639: Size comparison from 0ac52eb to b1499b0 Increases above 0.2%:
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
approved these changes
Nov 26, 2024
tehampson
approved these changes
Nov 26, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ect-chip#36639) * Add some missed registrations of dataModelProvider in server init * Fix commissioner main dependencies (make nrf tests compile) * Move around dependencies - apparently the commissioner main should be public * Fix one more odd dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems in #36558 I have missed some sample applications. Added them back.
Tested compiling and running nrfconnect light example.
also fixes dependencies to get
nrf-native-posix-64-teststo compile