Make AddressResolver not keep duplicate IP addresses in its cache #36861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
…nds like just picking a single address by default is a bit low
This comment was marked as outdated.
This comment was marked as outdated.
bzbarsky-apple
approved these changes
Dec 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
…not have sufficient space. This is a bit concerning ...
|
PR #36861: Size comparison from 43f66f0 to dd3e242 Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36861: Size comparison from 43f66f0 to 7346411 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Dec 17, 2024
cecille
approved these changes
Dec 17, 2024
|
PR #36861: Size comparison from 43f66f0 to 0314215 Full report (7 builds for cc13x4_26x4, cc32xx, stm32)
|
|
PR #36861: Size comparison from 293f65e to 3c2a9cf Full report (28 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #36861: Size comparison from 293f65e to 627a41f Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #36746 by deduplicating IP addresses in AddressResolver results.
Changes
Testing
Unit tests were updated and added to cover the new code. The unit tests were failing before the code was updated. CI will also validate general functionality.