Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default Event scheduler pointer in EventManagement #36906

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Remove default Event scheduler pointer in EventManagement #36906

merged 4 commits into from
Jan 10, 2025

Conversation

yyzhong-g
Copy link
Contributor

@yyzhong-g yyzhong-g commented Dec 19, 2024 •
edited
Loading

Follow up of PR #36831 and fix issue #36890.

Make EventManagement::Init() always takes in a valid pointer to EventScheduler.

Testing

covers by unit tests.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions github-actions bot added the app label Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

PR #36906: Size comparison from b880c14 to 4353715

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section b880c14 4353715 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1354296 1354244 -52 -0.0
RAM 104144 104144 0 0.0
bl702 lighting-app bl702+eth FLASH 652076 651992 -84 -0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829680 829596 -84 -0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1058152 1058068 -84 -0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 979526 979442 -84 -0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840080 840000 -80 -0.0
RAM 123680 123680 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825612 825524 -88 -0.0
RAM 125568 125568 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772488 772408 -80 -0.0
RAM 114044 114044 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756668 756588 -80 -0.0
RAM 114244 114244 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540017 539913 -104 -0.0
RAM 205784 205784 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574329 574217 -112 -0.0
RAM 205928 205928 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681865 681769 -96 -0.0
RAM 78740 78740 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701717 701621 -96 -0.0
RAM 81380 81380 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701717 701621 -96 -0.0
RAM 81380 81380 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658645 658549 -96 -0.0
RAM 73808 73808 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618489 618393 -96 -0.0
RAM 71732 71732 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638117 638021 -96 -0.0
RAM 74276 74276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638117 638021 -96 -0.0
RAM 74276 74276 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637889 637793 -96 -0.0
RAM 74740 74740 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657597 657501 -96 -0.0
RAM 77284 77284 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657597 657501 -96 -0.0
RAM 77284 77284 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614341 614245 -96 -0.0
RAM 68828 68828 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634193 634097 -96 -0.0
RAM 71460 71460 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634193 634097 -96 -0.0
RAM 71460 71460 0 0.0
efr32 lock-app BRD4187C FLASH 932708 932628 -80 -0.0
RAM 160212 160212 0 0.0
BRD4338a FLASH 746704 746648 -56 -0.0
RAM 233340 233340 0 0.0
window-app BRD4187C FLASH 1025376 1025328 -48 -0.0
RAM 128316 128316 0 0.0
esp32 all-clusters-app c3devkit DRAM 95336 95336 0 0.0
FLASH 1541870 1541782 -88 -0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116316 116316 0 0.0
FLASH 1548250 1548230 -20 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2716723 2716789 66 0.0
RAM 130024 130024 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6010172 6010264 92 0.0
RAM 523720 523720 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5346680 5346740 60 0.0
RAM 242808 242808 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4686216 4686276 60 0.0
RAM 218656 218656 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12846546 12846482 -64 -0.0
RAM 582594 582594 0 0.0
chip-tool-ipv6only arm64 unknown 21360 21360 0 0.0
FLASH 10980944 10980944 0 0.0
RAM 633536 633536 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11253095 11253031 -64 -0.0
RAM 582946 582946 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4511608 4511668 60 0.0
RAM 205824 205824 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5608341 5608437 96 0.0
RAM 472792 472792 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5622945 5623009 64 0.0
RAM 228984 228984 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4735488 4735580 92 0.0
RAM 204968 204968 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4361194 4361254 60 0.0
RAM 198656 198656 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4500218 4500310 92 0.0
RAM 203240 203240 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3034109 3034157 48 0.0
RAM 160640 160640 0 0.0
thermostat-no-ble arm64 unknown 9560 9560 0 0.0
FLASH 4105424 4105472 48 0.0
RAM 243288 243288 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5957477 5957525 48 0.0
RAM 596208 596208 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11056349 11056445 96 0.0
RAM 692472 692472 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918208 918148 -60 -0.0
RAM 143316 143316 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890368 890316 -52 -0.0
RAM 141503 141503 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852092 852024 -68 -0.0
RAM 142228 142228 0 0.0
nxp contact k32w0+release FLASH 585712 585728 16 0.0
RAM 71096 71096 0 0.0
mcxw71+release FLASH 600416 600424 8 0.0
RAM 63192 63192 0 0.0
light k32w0+release FLASH 612620 612588 -32 -0.0
RAM 70488 70488 0 0.0
k32w1+release FLASH 686904 686816 -88 -0.0
RAM 48824 48824 0 0.0
lock mcxw71+release FLASH 763312 763208 -104 -0.0
RAM 70860 70860 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647268 1647180 -88 -0.0
RAM 212112 212112 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554708 1554620 -88 -0.0
RAM 208928 208928 0 0.0
light cy8ckit_062s2_43012 FLASH 1470028 1469940 -88 -0.0
RAM 200896 200896 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467748 1467660 -88 -0.0
RAM 225256 225256 0 0.0
qpg lighting-app qpg6105+debug FLASH 664400 664336 -64 -0.0
RAM 105440 105440 0 0.0
lock-app qpg6105+debug FLASH 622212 622140 -72 -0.0
RAM 99892 99892 0 0.0
stm32 light STM32WB5MM-DK FLASH 485112 485040 -72 -0.0
RAM 144896 144896 0 0.0
telink bridge-app tlsr9258a FLASH 683318 683276 -42 -0.0
RAM 91232 91232 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623738 623698 -40 -0.0
RAM 31472 31472 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772556 772514 -42 -0.0
RAM 49332 49332 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711178 711138 -40 -0.0
RAM 73528 73528 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628188 628146 -42 -0.0
RAM 142164 142164 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814206 814164 -42 -0.0
RAM 99708 99708 0 0.0
tizen all-clusters-app arm unknown 5000 5000 0 0.0
FLASH 1735372 1735328 -44 -0.0
RAM 90840 90840 0 0.0
chip-tool-ubsan arm unknown 10808 10808 0 0.0
FLASH 17969006 17968958 -48 -0.0
RAM 7841376 7841376 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

PR #36906: Size comparison from 3f62505 to 8c6daa1

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section 3f62505 8c6daa1 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840400 840320 -80 -0.0
RAM 123712 123712 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825932 825860 -72 -0.0
RAM 125600 125600 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772836 772756 -80 -0.0
RAM 114076 114076 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757016 756936 -80 -0.0
RAM 114276 114276 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540285 540177 -108 -0.0
RAM 205816 205816 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574453 574337 -116 -0.0
RAM 205960 205960 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918156 918092 -64 -0.0
RAM 143332 143332 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890664 890612 -52 -0.0
RAM 141519 141519 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852220 852160 -60 -0.0
RAM 142244 142244 0 0.0
qpg lighting-app qpg6105+debug FLASH 664392 664328 -64 -0.0
RAM 105456 105456 0 0.0
lock-app qpg6105+debug FLASH 622204 622132 -72 -0.0
RAM 99908 99908 0 0.0
stm32 light STM32WB5MM-DK FLASH 485136 485064 -72 -0.0
RAM 144912 144912 0 0.0
tizen all-clusters-app arm unknown 5160 5160 0 0.0
FLASH 1781748 1781696 -52 -0.0
RAM 93720 93720 0 0.0
chip-tool-ubsan arm unknown 10924 10924 0 0.0
FLASH 18121646 18121598 -48 -0.0
RAM 7909212 7909212 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

PR #36906: Size comparison from e3bb3e3 to 9e0c255

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e3bb3e3 9e0c255 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1354946 1354894 -52 -0.0
RAM 104152 104152 0 0.0
bl702 lighting-app bl702+eth FLASH 726512 726430 -82 -0.0
RAM 25361 25361 0 0.0
bl702+wifi FLASH 913126 913044 -82 -0.0
RAM 14101 14101 0 0.0
bl706+mfd+rpc+littlefs FLASH 1173960 1173878 -82 -0.0
RAM 23941 23941 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 1083028 1082946 -82 -0.0
RAM 16612 16612 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840400 840320 -80 -0.0
RAM 123712 123712 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825932 825860 -72 -0.0
RAM 125600 125600 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772836 772756 -80 -0.0
RAM 114076 114076 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757016 756936 -80 -0.0
RAM 114276 114276 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540285 540177 -108 -0.0
RAM 205816 205816 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574453 574337 -116 -0.0
RAM 205960 205960 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681809 681713 -96 -0.0
RAM 78756 78756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701653 701557 -96 -0.0
RAM 81396 81396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701653 701557 -96 -0.0
RAM 81396 81396 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658589 658493 -96 -0.0
RAM 73824 73824 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618425 618329 -96 -0.0
RAM 71748 71748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638053 637957 -96 -0.0
RAM 74292 74292 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638053 637957 -96 -0.0
RAM 74292 74292 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637825 637729 -96 -0.0
RAM 74756 74756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657533 657437 -96 -0.0
RAM 77300 77300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657533 657437 -96 -0.0
RAM 77300 77300 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614445 614349 -96 -0.0
RAM 68844 68844 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634297 634201 -96 -0.0
RAM 71476 71476 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634297 634201 -96 -0.0
RAM 71476 71476 0 0.0
efr32 lock-app BRD4187C FLASH 932740 932660 -80 -0.0
RAM 160228 160228 0 0.0
BRD4338a FLASH 747208 747144 -64 -0.0
RAM 233356 233356 0 0.0
window-app BRD4187C FLASH 1025656 1025576 -80 -0.0
RAM 128332 128332 0 0.0
esp32 all-clusters-app c3devkit DRAM 95352 95352 0 0.0
FLASH 1541996 1541900 -96 -0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116332 116332 0 0.0
FLASH 1548246 1548234 -12 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2731685 2731751 66 0.0
RAM 133160 133160 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6020306 6020366 60 0.0
RAM 526008 526008 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5356400 5356460 60 0.0
RAM 243072 243072 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4704816 4704876 60 0.0
RAM 221824 221824 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12938676 12938644 -32 -0.0
RAM 587002 587002 0 0.0
chip-tool-ipv6only arm64 unknown 21560 21560 0 0.0
FLASH 11053856 11053856 0 0.0
RAM 638064 638064 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11334801 11334769 -32 -0.0
RAM 587346 587346 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4529968 4530028 60 0.0
RAM 208928 208928 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5641333 5641429 96 0.0
RAM 477880 477880 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5640945 5641009 64 0.0
RAM 232072 232072 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4753184 4753276 92 0.0
RAM 208072 208072 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4379730 4379790 60 0.0
RAM 201744 201744 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4518638 4518698 60 0.0
RAM 206312 206312 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3037885 3037949 64 0.0
RAM 160792 160792 0 0.0
thermostat-no-ble arm64 unknown 9584 9584 0 0.0
FLASH 4120104 4120168 64 0.0
RAM 246384 246384 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5990677 5990725 48 0.0
RAM 601312 601312 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11167325 11167421 96 0.0
RAM 700496 700496 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918156 918092 -64 -0.0
RAM 143332 143332 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890664 890612 -52 -0.0
RAM 141519 141519 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852220 852160 -60 -0.0
RAM 142244 142244 0 0.0
nxp contact k32w0+release FLASH 586112 586128 16 0.0
RAM 71112 71112 0 0.0
mcxw71+release FLASH 601624 601640 16 0.0
RAM 63328 63328 0 0.0
light k32w0+release FLASH 612748 612716 -32 -0.0
RAM 70504 70504 0 0.0
k32w1+release FLASH 687384 687304 -80 -0.0
RAM 48920 48920 0 0.0
lock mcxw71+release FLASH 763704 763600 -104 -0.0
RAM 70956 70956 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647684 1647596 -88 -0.0
RAM 212144 212144 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1555316 1555244 -72 -0.0
RAM 208960 208960 0 0.0
light cy8ckit_062s2_43012 FLASH 1470420 1470348 -72 -0.0
RAM 200928 200928 0 0.0
lock cy8ckit_062s2_43012 FLASH 1468156 1468084 -72 -0.0
RAM 225280 225280 0 0.0
qpg lighting-app qpg6105+debug FLASH 664392 664328 -64 -0.0
RAM 105456 105456 0 0.0
lock-app qpg6105+debug FLASH 622204 622132 -72 -0.0
RAM 99908 99908 0 0.0
stm32 light STM32WB5MM-DK FLASH 485136 485064 -72 -0.0
RAM 144912 144912 0 0.0
telink bridge-app tlsr9258a FLASH 683698 683656 -42 -0.0
RAM 91248 91248 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623938 623898 -40 -0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772772 772730 -42 -0.0
RAM 49348 49348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777388 777346 -42 -0.0
RAM 99812 99812 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711380 711340 -40 -0.0
RAM 73544 73544 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628384 628342 -42 -0.0
RAM 142180 142180 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814398 814356 -42 -0.0
RAM 99724 99724 0 0.0
tizen all-clusters-app arm unknown 5160 5160 0 0.0
FLASH 1781748 1781696 -52 -0.0
RAM 93720 93720 0 0.0
chip-tool-ubsan arm unknown 10924 10924 0 0.0
FLASH 18121646 18121598 -48 -0.0
RAM 7909212 7909212 0 0.0

@mergify mergify bot merged commit a219ff7 into project-chip:master Jan 10, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yyzhong-g @andy31415 @bzbarsky-apple @restyled-commits